Re: [Okular-devel] Review Request 124612: WIP: Add basic support for RichMedia annotations in PDF files

2015-08-13 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124612/#review83790 --- Why marked as WIP? What are you planning to improve? - Albert

Re: [Okular-devel] Review Request 124612: WIP: Add basic support for RichMedia annotations in PDF files

2015-08-13 Thread Tobias Koenig
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124612/ --- (Updated Aug. 13, 2015, 2:18 p.m.) Review request for Okular, Albert Asta

Re: [Okular-devel] Review Request 124612: WIP: Add basic support for RichMedia annotations in PDF files

2015-08-13 Thread Tobias Koenig
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124612/ --- (Updated Aug. 13, 2015, 7 a.m.) Review request for Okular, Albert Astals

Re: [Okular-devel] Review Request 124612: WIP: Add basic support for RichMedia annotations in PDF files

2015-08-12 Thread Tobias Koenig
> On Aug. 12, 2015, 8:35 p.m., Albert Astals Cid wrote: > > generators/poppler/generator_pdf.cpp, line 221 > > > > > > Dependeing on what we do on poppler-qt and poppler core on null > > configurations (create a

Re: [Okular-devel] Review Request 124612: WIP: Add basic support for RichMedia annotations in PDF files

2015-08-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124612/#review83749 --- generators/poppler/generator_pdf.cpp (line 221)

Re: [Okular-devel] Review Request 124612: WIP: Add basic support for RichMedia annotations in PDF files

2015-08-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124612/#review83748 --- core/annotations.h (line 1658)

Re: [Okular-devel] Review Request 124612: WIP: Add basic support for RichMedia annotations in PDF files

2015-08-11 Thread Tobias Koenig
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124612/ --- (Updated Aug. 11, 2015, 9:51 a.m.) Review request for Okular, Albert Asta

Re: [Okular-devel] Review Request 124612: WIP: Add basic support for RichMedia annotations in PDF files

2015-08-11 Thread Tobias Koenig
> On Aug. 10, 2015, 9:34 p.m., Albert Astals Cid wrote: > > core/annotations.cpp, line 2968 > > > > > > This and ::store are doing virtually nothing? Well, that is the same code the other annotation classes hav

Re: [Okular-devel] Review Request 124612: WIP: Add basic support for RichMedia annotations in PDF files

2015-08-10 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124612/#review83677 --- core/annotations.h (line 1658)

[Okular-devel] Review Request 124612: WIP: Add basic support for RichMedia annotations in PDF files

2015-08-04 Thread Tobias Koenig
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124612/ --- Review request for Okular. Bugs: https://bugs.kde.org/show_bug.cgi?id=326