Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection

2015-08-27 Thread Jake Linder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/ --- (Updated Aug. 27, 2015, 8:10 p.m.) Status -- This change has been

Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection

2015-08-27 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/#review84488 --- Ship it! Ship It! - Albert Astals Cid On ago. 27, 2015,

Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection

2015-08-27 Thread Jake Linder
On Aug. 27, 2015, 8:10 p.m., Albert Astals Cid wrote: Ship It! \o/ - Jake --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/#review84488

Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection

2015-08-27 Thread Jake Linder
On Aug. 26, 2015, 9:50 p.m., Albert Astals Cid wrote: ui/pageview.cpp, line 494 https://git.reviewboard.kde.org/r/124716/diff/5/?file=397617#file397617line494 Why this? I think it's the default, no? Jake Linder wrote: Dev leftover. Added back. err, eliminated that is. -

Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection

2015-08-27 Thread Jake Linder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/ --- (Updated Aug. 27, 2015, 6:13 a.m.) Review request for Okular and Albert

Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection

2015-08-27 Thread Jake Linder
On Aug. 26, 2015, 9:50 p.m., Albert Astals Cid wrote: Code Looks reasonable (haven't tried yet live) Good. I use it daily and fixed up a few issues I came across, but It's been fairly solid. Thanks for the review. On Aug. 26, 2015, 9:50 p.m., Albert Astals Cid wrote:

Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection

2015-08-26 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/#review84427 --- Code Looks reasonable (haven't tried yet live)

Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection

2015-08-23 Thread Jake Linder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/ --- (Updated Aug. 23, 2015, 6:37 p.m.) Review request for Okular and Albert

Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection

2015-08-20 Thread Jake Linder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/ --- (Updated Aug. 21, 2015, 5:10 a.m.) Review request for Okular and Albert

Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection

2015-08-20 Thread Jake Linder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/ --- (Updated Aug. 21, 2015, 3:11 a.m.) Review request for Okular and Albert

Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection

2015-08-13 Thread Jake Linder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/ --- (Updated Aug. 13, 2015, 3:58 p.m.) Review request for Okular and Albert

[Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection

2015-08-12 Thread Jake Linder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/ --- Review request for Okular and Albert Astals Cid. Bugs: 351156

Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection

2015-08-12 Thread Jake Linder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/ --- (Updated Aug. 12, 2015, 3:11 p.m.) Review request for Okular and Albert