Re: [Okular-devel] Review Request 124961: Interact with hyperlinks in TextSelect mode (supercedes 124723)

2016-07-19 Thread Olivier Churlaud
> On Oct. 18, 2015, 12:17 a.m., Albert Astals Cid wrote: > > If you are doing a text select over a link (i.e. you click and start > > dragging on a link), i think the cursor should go back to the beam cursor, > > what do you think? > > Olivier Churlaud wrote: > @aacid: What is the status

Re: [Okular-devel] Review Request 124961: Interact with hyperlinks in TextSelect mode (supercedes 124723)

2016-07-17 Thread Albert Astals Cid
> On Oct. 17, 2015, 10:17 p.m., Albert Astals Cid wrote: > > If you are doing a text select over a link (i.e. you click and start > > dragging on a link), i think the cursor should go back to the beam cursor, > > what do you think? > > Olivier Churlaud wrote: > @aacid: What is the status

Re: [Okular-devel] Review Request 124961: Interact with hyperlinks in TextSelect mode (supercedes 124723)

2016-07-17 Thread Olivier Churlaud
> On Oct. 18, 2015, 12:17 a.m., Albert Astals Cid wrote: > > If you are doing a text select over a link (i.e. you click and start > > dragging on a link), i think the cursor should go back to the beam cursor, > > what do you think? @aacid: What is the status of this review? - Olivier

Re: [Okular-devel] Review Request 124961: Interact with hyperlinks in TextSelect mode (supercedes 124723)

2015-10-17 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124961/#review86986 --- I think that if you're right clicking on a link while text is

Re: [Okular-devel] Review Request 124961: Interact with hyperlinks in TextSelect mode (supercedes 124723)

2015-10-17 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124961/#review86987 --- If you are doing a text select over a link (i.e. you click

Re: [Okular-devel] Review Request 124961: Interact with hyperlinks in TextSelect mode (supercedes 124723)

2015-09-14 Thread Jake Linder
> On Sept. 14, 2015, 10:44 p.m., Albert Astals Cid wrote: > > This is cool, it touches a bit of a critical code so i'm giving it some > > more review, thanks for the patch :) That big switch is difficult to manage, so careful review is welcome. fwiw, I've been using it without issues since

Re: [Okular-devel] Review Request 124961: Interact with hyperlinks in TextSelect mode (supercedes 124723)

2015-09-14 Thread Jake Linder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124961/ --- (Updated Sept. 15, 2015, 5:41 a.m.) Review request for Okular and Albert

[Okular-devel] Review Request 124961: Interact with hyperlinks in TextSelect mode (supercedes 124723)

2015-08-28 Thread Jake Linder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124961/ --- Review request for Okular and Albert Astals Cid. Bugs: 318078