[Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125397/ --- Review request for Okular. Bugs: 325650 http://bugs.kde.org/show_bug.

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125397/#review92307 --- any feedback? - Fahad Al-Saidi On Sept. 25, 2015, 4:05 p.m

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125397/#review92546 --- Is this something that one would expect to set manually? Shou

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

> On Feb. 19, 2016, 12:27 a.m., Albert Astals Cid wrote: > > Is this something that one would expect to set manually? Shouldn't it be > > detected from the file contents? Or that's just too hard/not optimal? Sorry for late reply. I didn't get notified when you wrote your comment. It is weired

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125397/ --- (Updated June 27, 2016, 12:54 p.m.) Review request for Okular. Changes

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

> On Feb. 19, 2016, 12:27 a.m., Albert Astals Cid wrote: > > conf/dlggeneralbase.ui, line 391 > > > > > > Why did you change the acceletaror? Oops, by mistake. > On Feb. 19, 2016, 12:27 a.m., Albert Astals Cid

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125397/#review97673 --- Mostly style correction. Then I think it will be fine. (I'll

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125397/ --- (Updated July 21, 2016, 5:07 a.m.) Review request for Okular and Albert A

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

> On July 20, 2016, 6:29 p.m., Olivier Churlaud wrote: > > Mostly style correction. Then I think it will be fine. (I'll check again) Great. All requested changes done. Thanks - Fahad --- This is an automatically generated e-mail. To rep

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125397/#review97690 --- @Albert: If you could check. IMO, it can be shipped. - Olivi

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125397/#review97739 --- Ship it! Ship It! - Albert Astals Cid On July 21, 2016,

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

> On July 21, 2016, 11:03 p.m., Albert Astals Cid wrote: > > Ship It! Great. - Fahad --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125397/#review97739 -

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

> On July 22, 2016, 1:03 a.m., Albert Astals Cid wrote: > > Ship It! > > Fahad Al-Saidi wrote: > Great. Can you ship it Fahad? Or should I in your behalf? - Olivier --- This is an automatically generated e-mail. To reply, visit: ht

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

> On July 21, 2016, 11:03 p.m., Albert Astals Cid wrote: > > Ship It! > > Fahad Al-Saidi wrote: > Great. > > Olivier Churlaud wrote: > Can you ship it Fahad? Or should I in your behalf? I can if I know :-) I am new here so any informoation will be great. - Fahad ---

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

> On July 21, 2016, 11:03 p.m., Albert Astals Cid wrote: > > Ship It! > > Fahad Al-Saidi wrote: > Great. > > Olivier Churlaud wrote: > Can you ship it Fahad? Or should I in your behalf? > > Fahad Al-Saidi wrote: > I can if I know :-) I am new here so any informoation will be great.

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125397/ --- (Updated July 26, 2016, 1:39 a.m.) Status -- This change has been ma