Re: [Okular-devel] Review Request 126193: Port to new JSON plugin loading system

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126193/ --- (Updated Jan. 4, 2016, 3:08 p.m.) Status -- This change has been mar

Re: [Okular-devel] Review Request 126193: Port to new JSON plugin loading system

> On Dec. 15, 2015, 11:59 p.m., Albert Astals Cid wrote: > > The json translation stuff should be together with the rest of json > > translation stuff we have in l10n ideally. I have implmented translating the new fields: https://svn.reviewboard.kde.org/r/7153/ - Alex -

Re: [Okular-devel] Review Request 126193: Port to new JSON plugin loading system

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126193/#review89570 --- Ship it! The json translation stuff should be together with t

Re: [Okular-devel] Review Request 126193: Port to new JSON plugin loading system

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126193/ --- (Updated Dec. 14, 2015, 11:59 a.m.) Review request for Okular. Reposito

Re: [Okular-devel] Review Request 126193: Port to new JSON plugin loading system

> On Dec. 14, 2015, 11:56 a.m., Luigi Toscano wrote: > > Is the last patch against master, or does reviewboard just shows the diff > > against the wrong branch? Wrong branch, I'll try and resubmit - Alex --- This is an automatically ge

Re: [Okular-devel] Review Request 126193: Port to new JSON plugin loading system

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126193/#review89466 --- Is the last patch against master, or does reviewboard just sho

Re: [Okular-devel] Review Request 126193: Port to new JSON plugin loading system

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126193/ --- (Updated Dec. 14, 2015, 11:46 a.m.) Review request for Okular. Changes

Re: [Okular-devel] Review Request 126193: Port to new JSON plugin loading system

> On Nov. 30, 2015, 9:35 p.m., Albert Astals Cid wrote: > > generators/chm/generator_chm.cpp, line 32 > > > > > > Why have you decided to remove the createAboutData methods? We're > > losing functionality and it'

Re: [Okular-devel] Review Request 126193: Port to new JSON plugin loading system

> On nov. 30, 2015, 9:35 p.m., Albert Astals Cid wrote: > > generators/chm/generator_chm.cpp, line 32 > > > > > > Why have you decided to remove the createAboutData methods? We're > > losing functionality and it'

Re: [Okular-devel] Review Request 126193: Port to new JSON plugin loading system

> On Nov. 30, 2015, 9:35 p.m., Albert Astals Cid wrote: > > generators/chm/generator_chm.cpp, line 32 > > > > > > Why have you decided to remove the createAboutData methods? We're > > losing functionality and it'

Re: [Okular-devel] Review Request 126193: Port to new JSON plugin loading system

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126193/#review88977 --- generators/chm/generator_chm.cpp (line 32)

Re: [Okular-devel] Review Request 126193: Port to new JSON plugin loading system

> On Nov. 29, 2015, 5:49 p.m., Albert Astals Cid wrote: > > there's a few qdebugs in the code, please remove them I've removed them locally, any other issues? - Alex --- This is an automatically generated e-mail. To reply, visit: https:

Re: [Okular-devel] Review Request 126193: Port to new JSON plugin loading system

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126193/#review88927 --- there's a few qdebugs in the code, please remove them - Alber

[Okular-devel] Review Request 126193: Port to new JSON plugin loading system

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126193/ --- Review request for Okular. Repository: okular Description --- Two