D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla added a comment. Thank you so much. I'm checking it out. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10209 To: dileepsankhla, #okular, ngraham Cc: ngraham, #okular, michaelweghorn, aacid

D10209: Use correct arrow cursor for Annotations' close buttons

ngraham added a comment. Congratulations on your first patch! May it be the first of many more. If you're looking for inspiration, might I suggest checking out https://phabricator.kde.org/T6831? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10209 To: dileepsankhla

D10209: Use correct arrow cursor for Annotations' close buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R223:de56b9c9c165: Use correct arrow cursor for Annotations' close buttons (authored by dileepsankhla, committed by ngraham). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla added a comment. Sure :) REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D10209 To: dileepsankhla, #okular, ngraham Cc: ngraham, #okular, michaelweghorn, aacid

D10209: Use correct arrow cursor for Annotations' close buttons

ngraham added a comment. Thanks! One more thing. The commit message has the following for your name: Author: RobStat Date: Wed Jan 31 10:54:37 2018 -0700 Would you mind using "Dileep Sankhla" instead of RobStat? for future patches? I'll correct it for this one. REPOSITORY R22

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla added a comment. In https://phabricator.kde.org/D10209#198608, @ngraham wrote: > Lovely. Tested it out and it works as expected. Fix the BUG: string and I'll land this. Thank you so much. Fixed it. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https:/

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla edited the summary of this revision. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D10209 To: dileepsankhla, #okular, ngraham Cc: ngraham, #okular, michaelweghorn, aacid

D10209: Use correct arrow cursor for Annotations' close buttons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Lovely. Tested it out and it works as expected. Fix the BUG: string and I'll land this. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D10209 To

D10209: Use correct arrow cursor for Annotations' close buttons

ngraham added a comment. Actually, the BUG: line can't be a link, I'm afraid. It has to be just: "BUG: " See https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10209 To: dilee

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10209 To: dileepsankhla, #okular Cc: ngraham, #okular, michaelweghorn, aacid

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla added a comment. BUG: 384381 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10209 To: dileepsankhla, #okular Cc: ngraham, #okular, michaelweghorn, aacid

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla added a comment. In https://phabricator.kde.org/D10209#198568, @ngraham wrote: > Thanks for the patch! Can you indicate your testing, and perhaps provide a screenshot that shows this working? > > Also, the title of the revision is really better suited to being in the su

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla retitled this revision from "Added setCursor() call in the CloseButton constructor" to "Use correct arrow cursor for Annotations' close buttons". dileepsankhla edited the summary of this revision. dileepsankhla edited the test plan for this revision. REPOSITORY R223 Okular REVIS