D10864: Poppler: Add read only setter for form fields

2018-02-26 Thread Andre Heinecke
aheinecke added a task: T8097: Support for read only changes and checkbox values in scripts. REVISION DETAIL https://phabricator.kde.org/D10864 To: aheinecke, #okular Cc: michaelweghorn, ngraham, aacid

D10864: Poppler: Add read only setter for form fields

2018-02-26 Thread Andre Heinecke
aheinecke created this revision. aheinecke added a reviewer: Okular. aheinecke added a project: Okular. aheinecke requested review of this revision. REVISION SUMMARY Read only is modifiable from AcroForm scripts. As such we need to add setting it to the data model of Poppler. - I kno

D10864: Poppler: Add read only setter for form fields

2018-03-15 Thread Albert Astals Cid
aacid added a comment. There is a problem with this, in which when saving, this doesn't get saved, because FormField::setReadonly is not updating Ff properly, so if you click on of the checkboxes and then save the file and open it again it looks wrong. Do you think you can try fixing tha

D10864: Poppler: Add read only setter for form fields

2018-03-19 Thread Andre Heinecke
aheinecke added a comment. I've started to look at saving this on Friday. I'm a bit confused as the ReadOnly is a Field value and not a Widget Annotation value and the Adobe Spec says that it is ignored for Widget Annotations. Saving a document with Adobe after changing a ReadOnly field

D10864: Poppler: Add read only setter for form fields

2018-03-19 Thread Andre Heinecke
aheinecke updated this revision to Diff 29917. aheinecke added a comment. Added object dict / xref update so that the Read Only state is saved. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10864?vs=28112&id=29917 REVISION DETAIL https://phabricator.kde.org/D10864 AFFECTED FILES

D10864: Poppler: Add read only setter for form fields

2018-03-19 Thread Andre Heinecke
aheinecke added a comment. With this change saving / loading the read only state works. REVISION DETAIL https://phabricator.kde.org/D10864 To: aheinecke, #okular Cc: aacid, michaelweghorn, ngraham

D10864: Poppler: Add read only setter for form fields

2018-03-20 Thread Albert Astals Cid
aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. I've pushed this to poppler, please close. REVISION DETAIL https://phabricator.kde.org/D10864 To: aheinecke, #okular, aacid Cc: aacid, michaelweghorn, ngraham

D10864: Poppler: Add read only setter for form fields

2018-03-20 Thread Andre Heinecke
aheinecke closed this revision. aheinecke added a comment. Thanks! REVISION DETAIL https://phabricator.kde.org/D10864 To: aheinecke, #okular, aacid Cc: aacid, michaelweghorn, ngraham