D11250: Expose presentation via MPRIS to rich remote controllers

kossebau abandoned this revision. kossebau added a comment. Herald added a subscriber: okular-devel. No personal need anymore, and seemingly no-one else interested, thus discarding. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11250 To: kossebau, #okular Cc: okula

D11250: Expose presentation via MPRIS to rich remote controllers

kossebau updated this revision to Diff 29945. kossebau added a comment. extend MprisThumbnailStore to support updates of thumbnails REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11250?vs=29681&id=29945 BRANCH addmprisservice REVISION DETAIL https://ph

D11250: Expose presentation via MPRIS to rich remote controllers

kossebau added inline comments. INLINE COMMENTS > aacid wrote in dbusabstractadaptor.h:32 > This seems like random glue code, wouldn't this make more sense in Qt or in > KF5? Possibly. Similar code working around the missing Qt feature is found across code. Actually one would expect this indee

D11250: Expose presentation via MPRIS to rich remote controllers

aacid added inline comments. INLINE COMMENTS > dbusabstractadaptor.h:32 > + */ > +class DBusAbstractAdaptor : public QDBusAbstractAdaptor > +{ This seems like random glue code, wouldn't this make more sense in Qt or in KF5? > mprismediaplayer2player.cpp:50 > +if (flags & Pixmap) { > +

D11250: Expose presentation via MPRIS to rich remote controllers

kossebau added a comment. So far got a few comments about this being a nice idea in general, and one already about something in the code. So far all positive. Now, where are the negative ones, there must be some :) If not or even then, I hope for some good people for some further detailed

D11250: Expose presentation via MPRIS to rich remote controllers

kossebau updated this revision to Diff 29681. kossebau added a comment. - always create mpris service, not only with Q_OS_LINUX - minor code clean-ups REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11250?vs=29333&id=29681 BRANCH addmprisservice REVISIO

D11250: Expose presentation via MPRIS to rich remote controllers

kossebau added a comment. In D11250#227259 , @pino wrote: > Please do not restrict it to `Q_OS_LINUX`, as there is no Linux-only code (nor the feature is specific to Linux in any way). Good hint, possibly was misguided by the special case

D11250: Expose presentation via MPRIS to rich remote controllers

pino added a comment. Please do not restrict it to `Q_OS_LINUX`, as there is no Linux-only code (nor the feature is specific to Linux in any way). REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11250 To: kossebau, #okular Cc: pino, rkflx, #kde_connect, michaelweghor

D11250: Expose presentation via MPRIS to rich remote controllers

kossebau updated this revision to Diff 29333. kossebau added a comment. Register objects before registering the service name, this should help Plasma MPRIS controllers & others to use the service instantly when the name is registered REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE ht

D11250: Expose presentation via MPRIS to rich remote controllers

kossebau added a comment. Two issues yet, one in code and one possibly in Plasma: a) the same okular process can have multiple documents open and thus run multiple presentations at the same time. The current code will only expose the first presentation to mpris. No idea yet how to handle th

D11250: Expose presentation via MPRIS to rich remote controllers

kossebau updated this revision to Diff 29326. kossebau added a comment. - added thumbnail support - fixed unregistering from DBus when presentationwidget is only closed, not deleted REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11250?vs=29286&id=29326 B

D11250: Expose presentation via MPRIS to rich remote controllers

kossebau added a comment. Right now trying to also get preview of the current page implemented, by storing the PixmapRequest result in a temporary file and passing that in the metadata as mpris:artUrl. But not sure if I make it tonight, and already useful as is, so this upload for first ro

D11250: Expose presentation via MPRIS to rich remote controllers

kossebau created this revision. kossebau added a reviewer: Okular. Restricted Application added a project: Okular. kossebau requested review of this revision. REVISION SUMMARY When going into presentation mode, a D-Bus object is created that implements MPRIS spec and exposes control to the pre