chinmoyr retitled this revision from "[RFC] Add FormFieldSignature to Okular's
namespace" to "Add FormFieldSignature to Okular namespace".
chinmoyr edited reviewers, added: aacid; removed: Okular.
Restricted Application added a subscriber: okular-devel.
REPOSITORY
R223 Okular
REVISION DETAIL
chinmoyr updated this revision to Diff 34307.
chinmoyr added a comment.
Removed code unrelated to this revision.
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11723?vs=30645&id=34307
REVISION DETAIL
https://phabricator.kde.org/D11723
AFFECTED FILES
co
aacid added a comment.
I understand you're mimicing the poppler API at some points but that doesn't
always makes sense since poppler is a multi-purpose library and okular is a
document viewer.
INLINE COMMENTS
> form.cpp:284
> +
> +void setValue( const QString& v ) override
> +
chinmoyr updated this revision to Diff 34717.
chinmoyr marked 2 inline comments as done.
chinmoyr added a comment.
Updated API.
Removed cases with no use cases.
Removed redundant enums.
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11723?vs=34307&id=347
chinmoyr added inline comments.
INLINE COMMENTS
> aacid wrote in form.cpp:284
> What's this used for?
For other formfields it can be used to set their default states. But for
signature field I have no idea.
> aacid wrote in form.h:390
> What would be the usecase for this force?
I never though
aacid added inline comments.
INLINE COMMENTS
> signatureinfo.h:33
> + */
> +virtual int signatureStatus() const;
> +
int is bad, this, certificateStatus and hashAlgorithm need to be enums, what am
i supposed to do with this returning 3? What does 3 mean?
> signatureinfo.h:58
>
aacid added inline comments.
INLINE COMMENTS
> formfields.cpp:420
> +auto sigInfo = m_field->validate(
> Poppler::FormFieldSignature::ValidateVerifyCertificate );
> +return static_cast( new PopplerSignatureInfo(
> sigInfo ) );
> +}
Why a static_cast here?
> pdfsignatureinfo.cpp:43
> +
sander added inline comments.
INLINE COMMENTS
> aacid wrote in pdfsignatureinfo.cpp:43
> You need to delete d_ptr?
Or use a std::unique_ptr?
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D11723
To: chinmoyr, aacid
Cc: sander, ngraham, okular-devel, aacid
chinmoyr updated this revision to Diff 35510.
chinmoyr added a comment.
Removed the unnecessary static_cast
Used QScopedPointer for d_ptr
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11723?vs=35040&id=35510
BRANCH
master
REVISION DETAIL
https://pha
chinmoyr edited dependent revision(s), added 1: D12901: Add unit test for
SignatureFormField; removed 1: D11725: [RFC] Show signature status as a popup.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D11723
To: chinmoyr, aacid
Cc: sander, ngraham, okular-devel, aacid
chinmoyr updated this revision to Diff 35513.
chinmoyr added a comment.
Added validateSignatures() to validate signatures while loading a page.
Added to document info whether or not a pdf is digitally signed.
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D
chinmoyr added a dependent revision: D13366: Add SignatureEdit widget for
FormFieldSignature.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D11723
To: chinmoyr, aacid
Cc: sander, ngraham, okular-devel, aacid
chinmoyr updated this revision to Diff 35983.
chinmoyr added a comment.
Revert to previous version. Now signatures will not be validated upfront.
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11723?vs=35513&id=35983
BRANCH
master
REVISION DETAIL
https
chinmoyr added a dependent revision: D13483: Add SignatureSummaryDialog and
SignaturePropertiesDialog.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D11723
To: chinmoyr, aacid
Cc: sander, ngraham, okular-devel, aacid
chinmoyr removed a dependent revision: D13366: Add SignatureEdit widget for
FormFieldSignature.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D11723
To: chinmoyr, aacid
Cc: sander, ngraham, okular-devel, aacid
chinmoyr abandoned this revision.
chinmoyr added a comment.
Outdated revision
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D11723
To: chinmoyr, aacid
Cc: sander, ngraham, okular-devel, aacid
chinmoyr removed a dependent revision: D12901: Add unit test for
SignatureFormField.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D11723
To: chinmoyr, aacid
Cc: sander, ngraham, okular-devel, aacid
17 matches
Mail list logo
