D14310: Fixes url whitespaces in epub documents

This revision was automatically updated to reflect the committed changes. Closed by commit R223:fcf148b75b98: Fixes url whitespaces in epub documents (authored by gassaf). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14310?vs=39469&id=39800 REVISION DETAIL

D14310: Fixes url whitespaces in epub documents

ngraham added a comment. In D14310#307943 , @aacid wrote: > Yes he can. > > @ngraham when you want to check if someone has commit rights you can check https://websvn.kde.org/trunk/kde-common/accounts?view=markup Thanks Albert! And I s

D14310: Fixes url whitespaces in epub documents

aacid added a comment. Yes he can. @ngraham when you want to check if someone has commit rights you can check https://websvn.kde.org/trunk/kde-common/accounts?view=markup REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D14310 To: gassaf, #okular,

D14310: Fixes url whitespaces in epub documents

ngraham added a comment. Can you commit this yourself, @gassaf? REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D14310 To: gassaf, #okular, aacid Cc: ngraham, aacid, okular-devel

D14310: Fixes url whitespaces in epub documents

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D14310 To: gassaf, #okular, aacid Cc: aacid, okular-devel, ngraham

D14310: Fixes url whitespaces in epub documents

gassaf added a comment. Here you go. I created this epub document via a free software tool called sigil. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14310 To: gassaf, #okular Cc: aacid, okular-devel, ngraham

D14310: Fixes url whitespaces in epub documents

gassaf updated this revision to Diff 39469. gassaf added a comment. epub generator unit test added REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14310?vs=38278&id=39469 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14310 AFFECTED FILES

D14310: Fixes url whitespaces in epub documents

aacid added a comment. Are we sure this won't break something else? How hard would be to have an autotest (with files that are not copyrighted/tainted) ? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14310 To: gassaf, #okular Cc: aacid, okular-devel, ngraham

D14310: Fixes url whitespaces in epub documents

gassaf added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D14310 To: gassaf, #okular Cc: okular-devel, ngraham, aacid

D14310: Fixes url whitespaces in epub documents

gassaf created this revision. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. gassaf requested review of this revision. REVISION SUMMARY libepub can't handle whitespace url encodings. This is why epub documents containing whitespaces urls