D16345: Create new "Zoom to 100%" action

This revision was automatically updated to reflect the committed changes. Closed by commit R223:33ca396def24: Create new Zoom to 100% action (authored by ngraham). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16345?vs=44028=44309 REVISION DETAIL

D16345: Create new "Zoom to 100%" action

abetts accepted this revision. abetts added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R223 Okular BRANCH zoom-to-100 (branched from master) REVISION DETAIL https://phabricator.kde.org/D16345 To: ngraham, #okular, #vdg, abetts Cc: davidhurka, sander,

D16345: Create new "Zoom to 100%" action

ngraham added a comment. Okay, we now have two people personally confirming my assertion that users look in the menus to find functionality and learn keyboard shortcuts. I would like to land this feature for Okular 18.12.0 if there are no blocking objections. REPOSITORY R223 Okular

D16345: Create new "Zoom to 100%" action

davidhurka added a comment. I think, this action should be in the menu, under “Zoom in” and “Zoom out”. That’s the way I learn about available actions, when I customize my toolbars. I think, “Zoom in” and “Zoom out” are more related than “Zoom in” and “Reset zoom*, so I wouldn’t expect

D16345: Create new "Zoom to 100%" action

ngraham added subscribers: tobiasdeiminger, sander. ngraham added a comment. I maintain that it is useful to have items in the main menu so that users can always discover functionality irrespective of the toolbar state, and learn keyboard shortcuts without having to show a separate window.

D16345: Create new "Zoom to 100%" action

veqz added a comment. I'm in favour of adding this. I'm generally a fan of «completeness», and often like to know I have «reset» the zoom level. I'd think that as a standard, if the menu contains «Zoom In» and «Zoom Out» options, it really should include a «reset»/«Zoom to 100%» option as

D16345: Create new "Zoom to 100%" action

abetts added a comment. +1 I think there "could' be variations of this like Show original size Maybe? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16345 To: ngraham, #okular, #vdg Cc: abetts, aacid, okular-devel, ngraham

D16345: Create new "Zoom to 100%" action

ngraham added a reviewer: VDG. ngraham added a comment. One of the purposes of a menu bar is to teach users keyboard shortcuts. That's the reason why menu items have shortcuts listed next to them, and why tools with shortcuts have menu items. This isn't a philosophical position, it's a

D16345: Create new "Zoom to 100%" action

aacid added a comment. In D16345#346829 , @ngraham wrote: > In D16345#346828 , @aacid wrote: > > > In D16345#346803 , @ngraham wrote: > > > > > I would

D16345: Create new "Zoom to 100%" action

ngraham added a comment. In D16345#346828 , @aacid wrote: > In D16345#346803 , @ngraham wrote: > > > I would prefer to leave it in the main menu. The whole purpose of an app's main menu is to

D16345: Create new "Zoom to 100%" action

aacid added a comment. In D16345#346803 , @ngraham wrote: > I would prefer to leave it in the main menu. The whole purpose of an app's main menu is to expose all functionality in a visible manner--especially if that functionality has a keyboard

D16345: Create new "Zoom to 100%" action

ngraham added a comment. I would prefer to leave it in the main menu. The whole purpose of an app's main menu is to expose all functionality in a visible manner--especially if that functionality has a keyboard shortcut, since the menu becomes the only way for the user to see and learn the

D16345: Create new "Zoom to 100%" action

ngraham updated this revision to Diff 44028. ngraham marked an inline comment as done. ngraham added a comment. Use new slot syntax REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16345?vs=44003=44028 BRANCH zoom-to-100 (branched from master) REVISION

D16345: Create new "Zoom to 100%" action

aacid added a comment. I would argue we should leave this out of the menus, if people want to use the mouse to activate this they probably will just use the zoom combo in the toolbar. INLINE COMMENTS > pageview.cpp:488 > + > +d->aZoomActual = KStandardAction::actualSize( this, >

D16345: Create new "Zoom to 100%" action

ngraham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16345 To: ngraham, #okular Cc: okular-devel, ngraham, aacid