D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

ngraham added a comment. In D16519#447765 , @aacid wrote: > In D16519#447479 , @ngraham wrote: > > > Ok, well seeing as @kezik is continuing to submit patches (see D20437

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

aacid added a comment. In D16519#447479 , @ngraham wrote: > Ok, well seeing as @kezik is continuing to submit patches (see D20437 ), I guess your options are to: > > 1. re-open the discussion on a mailing

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

ngraham added a comment. Ok, well seeing as @kezik is continuing to submit patches (see D20437 ), I guess your options are to: 1. Try to convince him/her to provide a real name and re-open the discussion on a mailing list or phab task 2. Gracefully

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

aacid added a comment. That's your (plural) conclusion not mine, i disagree with that conclusion so i will voice my concern each time that happens. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16519 To: kezik, #okular, ngraham Cc: ngraham, sander, aacid,

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

ngraham added a comment. In D16519#15 , @aacid wrote: > Please never ever again land commits of anonymous people. If somewhen we want to relicense we're fucked. We've had this conversation before and I recall the conclusion being

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

kezik added a comment. Oh come on I release all my commits as CC0, do what you want, just fix it REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16519 To: kezik, #okular, ngraham Cc: ngraham, sander, aacid, okular-devel, #okular, joaonetto, tfella, darcyshen

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

aacid added a comment. Please never ever again land commits of anonymous people. If somewhen we want to relicense we're fucked. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16519 To: kezik, #okular, ngraham Cc: ngraham, sander, aacid, okular-devel, #okular,

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

kezik added a comment. In D16519#443979 , @ngraham wrote: > I had to do "Kezi Olio" to pass the commit filters which demand a two-part name, hope you don't mind. Perfect Thanks REPOSITORY R223 Okular REVISION DETAIL

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

ngraham added a comment. I had to do "Kezi Olio" to pass the commit filters which demand a two-part name, hope you don't mind. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16519 To: kezik, #okular, ngraham Cc: ngraham, sander, aacid, okular-devel, #okular,

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

This revision was automatically updated to reflect the committed changes. Closed by commit R223:5ef54e97ecd2: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with… (authored by Kezi Olio keziolio...@gmail.com, committed by ngraham). REPOSITORY R223 Okular CHANGES

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

kezik added a comment. In D16519#443932 , @ngraham wrote: > Works better for me too on my HP Spectre x360, and I couldn't find any regressions in behavior. > > @kezik can you provide your full name and email address so we can land this

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works better for me too on my HP Spectre x360, and I couldn't find any regressions in behavior. @kezik can you provide your full name and email address so we can land this patch

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

kezik added a comment. Ping REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16519 To: kezik, #okular Cc: sander, aacid, okular-devel, #okular, joaonetto, tfella, ngraham, darcyshen

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

sander added a comment. I do use my stylus for drawing on slides in presentation mode. I am not particularly happy with the quality of that, but compressing tablet events doesn't seem to make it worse. So no objections from my side. REPOSITORY R223 Okular REVISION DETAIL

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

kezik added a comment. Hi, thanks for the feedback. I think uncompressed tablet events are useful for example on krita, when you don't want to lose the "high frequency" content of the drawing on the screen, and latency is not a big issue. I don't see any downsides for okular, mouse

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

sander added a comment. I tried this on my ThinkPad Yoga 12, which comes with a stylus to write on the screen with. I confirm that this patch noticeably improves the scrolling behavior when using the stylus for scrolling. I am curious though: what are the downsides to enabling tablet

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

kezik updated this revision to Diff 54655. kezik retitled this revision from "Don't call scrollTo every time there's a mouseMoveEvent, use a timer instead" to "Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet". kezik edited the summary of this revision.