D18744: Select entire page on mouse double click event

shubham updated this revision to Diff 51610. shubham added a comment. Remove unneeded comment REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=51609&id=51610 BRANCH arcpatch-D18744 REVISION DETAIL https://phabricator.kde.org/D18744 AFFECTED FIL

D18744: Select entire page on mouse double click event

shubham updated this revision to Diff 51609. shubham edited the summary of this revision. shubham added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. Add action and shortcut to select the current page Remove triggering on mouseDoubleClick event

D18744: Select entire page on mouse double click event

shubham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, tfella, darcyshen, aacid

D18744: Select entire page on mouse double click event

shubham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, tfella, darcyshen, aacid

D18744: Select entire page on mouse double click event

loh.tar added a comment. Here a link how it is done in Kate/KTextEditor https://cgit.kde.org/ktexteditor.git/tree/src/view/kateviewinternal.cpp#n2710 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: davidhurka, abetts, loh.tar, alex

D18744: Select entire page on mouse double click event

shubham added a comment. I'm unsure how mouse click events of degree n can be handled. Maybe handle mouseDoubleClickEvent() nested inside another mouseDoubleClickEvent() ? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: davidhurka,

D18744: Select entire page on mouse double click event

shubham added a comment. In D18744#406150 , @aacidTriple-click is used for "select everything" in word processors, so perhaps we could take advantage of some familiarity there? > > AFAICS triple-click is usually "select line" not "select all pa

D18744: Select entire page on mouse double click event

ngraham added a comment. Yeah, that would be nice. Maybe select the entire page on quadruple-click? I agree that double-click is not ideal. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: davidhurka, abetts, loh.tar, alexde, ng

D18744: Select entire page on mouse double click event

aacid added a comment. In D18744#406128 , @davidhurka wrote: > In D18744#405851 , @ngraham wrote: > > > However I wonder if maybe triple-click might be better though? Triple-click is used for "sele

D18744: Select entire page on mouse double click event

davidhurka added a comment. In D18744#405851 , @ngraham wrote: > However I wonder if maybe triple-click might be better though? Triple-click is used for "select everything" in word processors, so perhaps we could take advantage of some familiari

D18744: Select entire page on mouse double click event

aacid added a comment. Honestly i think this is weird UI, no other single project out there does this (that i know) Personally I would prefer if we didn't do it either. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: abetts, lo

D18744: Select entire page on mouse double click event

shubham added a comment. Caution: I did not do my video editing magic : ) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: abetts, loh.tar, alexde, ngraham, okular-devel, tfella, darcyshen, aacid

D18744: Select entire page on mouse double click event

shubham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: abetts, loh.tar, alexde, ngraham, okular-devel, tfella, darcyshen, aacid

D18744: Select entire page on mouse double click event

shubham added a comment. @ngraham @loh.tar I don't think it is that big of a feature to be shown in the view menu. It is something which is natural, same as when you select a word(which also don't have any action defined). i'm okay anyways. REPOSITORY R223 Okular REVISION DETAIL https:/

D18744: Select entire page on mouse double click event

abetts added a comment. This idea is super interesting. Can you please make a gif or short video showing the new feature? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: abetts, loh.tar, alexde, ngraham, okular-devel, tfella, darcys

D18744: Select entire page on mouse double click event

ngraham added a comment. In D18744#405859 , @loh.tar wrote: > I suggest: > > - Add a new action "Select Page" similar to "Select All" > - Call first that new action/function, then the copy function, instead of coding explicit in mouse event

D18744: Select entire page on mouse double click event

loh.tar added a comment. I suggest: - Add a new action "Select Page" similar to "Select All" - Call first that new action/function, then the copy function, instead of coding explicit in mouse event - Shorten your comments, don't say what is obviously, explain things which may indisti

D18744: Select entire page on mouse double click event

alexde added subscribers: ngraham, alexde. alexde added a comment. In D18744#405851 , @ngraham wrote: > Seems sane enough to me. However I wonder if maybe triple-click might be better though? Triple-click is used for "select everything" in word p

D18744: Select entire page on mouse double click event

ngraham edited reviewers, added: VDG; removed: ngraham. ngraham added a comment. Interesting feature. Can confirm that it works for me; tested with a bunch of PDFs and ePubs with selectable text. No effect with documents that don't have selectable text. No crashes. Seems sane enough to m

D18744: Select entire page on mouse double click event

shubham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18744: Select entire page on mouse double click event

shubham retitled this revision from "[WIP]Select entire page on mouse double click event" to "Select entire page on mouse double click event". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen,