Re: Review Request 125847: Change pages in presentation mode by swiping on touch screen

2017-03-19 Thread Oliver Sander
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125847/ --- (Updated March 19, 2017, 11:35 p.m.) Status -- This change has been

Re: Review Request 125847: Change pages in presentation mode by swiping on touch screen

2017-03-14 Thread Oliver Sander
> On Feb. 17, 2017, 7:43 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > it looks good to me, but I don't have a touch screen to test on > > unfortunately > > Albert Astals Cid wrote: > I recently got a laptop with a touchscreen, it's not my main devel > machine but i'll try to find tim

Re: Review Request 125847: Change pages in presentation mode by swiping on touch screen

2017-03-07 Thread Oliver Sander
> On Feb. 17, 2017, 7:43 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > it looks good to me, but I don't have a touch screen to test on > > unfortunately > > Albert Astals Cid wrote: > I recently got a laptop with a touchscreen, it's not my main devel > machine but i'll try to find tim

Re: Review Request 125847: Change pages in presentation mode by swiping on touch screen

2017-03-06 Thread Albert Astals Cid
> On Feb. 17, 2017, 7:43 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > it looks good to me, but I don't have a touch screen to test on > > unfortunately > > Albert Astals Cid wrote: > I recently got a laptop with a touchscreen, it's not my main devel > machine but i'll try to find tim

Re: Review Request 125847: Change pages in presentation mode by swiping on touch screen

2017-02-27 Thread Oliver Sander
> On Feb. 17, 2017, 7:43 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > it looks good to me, but I don't have a touch screen to test on > > unfortunately > > Albert Astals Cid wrote: > I recently got a laptop with a touchscreen, it's not my main devel > machine but i'll try to find tim

Re: Review Request 125847: Change pages in presentation mode by swiping on touch screen

2017-02-19 Thread Albert Astals Cid
> On Feb. 17, 2017, 7:43 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > it looks good to me, but I don't have a touch screen to test on > > unfortunately > > Albert Astals Cid wrote: > I recently got a laptop with a touchscreen, it's not my main devel > machine but i'll try to find tim

Re: Review Request 125847: Change pages in presentation mode by swiping on touch screen

2017-02-19 Thread Albert Astals Cid
> On Feb. 17, 2017, 7:43 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > it looks good to me, but I don't have a touch screen to test on > > unfortunately I recently got a laptop with a touchscreen, it's not my main devel machine but i'll try to find time to setup stuff there and give it a

Re: Review Request 125847: Change pages in presentation mode by swiping on touch screen

2017-02-17 Thread Oliver Sander
> On Feb. 17, 2017, 7:43 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > ui/presentationwidget.cpp, line 538 > > > > > > always use {} Fixed in latest upload. - Oliver

Re: Review Request 125847: Change pages in presentation mode by swiping on touch screen

2017-02-17 Thread Oliver Sander
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125847/ --- (Updated Feb. 17, 2017, 8:06 p.m.) Review request for Okular. Changes -

Re: Review Request 125847: Change pages in presentation mode by swiping on touch screen

2017-02-17 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125847/#review102537 --- it looks good to me, but I don't have a touch screen to test

Re: Review Request 125847: Change pages in presentation mode by swiping on touch screen

2017-02-15 Thread Oliver Sander
> On Aug. 13, 2016, 9:07 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > okular is now free of kdelibs4support and known regressions, so I guess we > > might get this in soon. Friendly ping. Would it be possible to get this reviewed and merged? Thanks. - Oliver

Re: Review Request 125847: Change pages in presentation mode by swiping on touch screen

2016-08-13 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125847/#review98376 --- okular is now free of kdelibs4support and known regressions,

Re: Review Request 125847: Change pages in presentation mode by swiping on touch screen

2016-08-13 Thread Oliver Sander
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125847/ --- (Updated Aug. 13, 2016, 7:46 p.m.) Review request for Okular. Bugs: 354

Re: [Okular-devel] Review Request 125847: Change pages in presentation mode by swiping on touch screen

2016-07-20 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125847/#review97676 --- As the port of the framework is not over, it cannot get new f

[Okular-devel] Review Request 125847: Change pages in presentation mode by swiping on touch screen

2015-10-28 Thread Oliver Sander
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125847/ --- Review request for Okular. Bugs: 354012 http://bugs.kde.org/show_bug.