Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128821/ --- (Updated Oct. 15, 2016, 1:23 p.m.) Status -- This change has been

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

> On Oct. 2, 2016, 8:02 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > Ship It! > > Oliver Sander wrote: > My usual request: please ship it for me, I don't have commit rights. > > And thanks for your review! Friendly ping? - Oliver

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

> On Okt. 2, 2016, 8:02 nachm., Martin Tobias Holmedahl Sandsmark wrote: > > Ship It! My usual request: please ship it for me, I don't have commit rights. And thanks for your review! - Oliver --- This is an automatically generated

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

> On Okt. 2, 2016, 12:54 nachm., Martin Tobias Holmedahl Sandsmark wrote: > > I tried to test with pinching on my touchpad, but apparently Qt doesn't > > handle the gestures from libinput or something. > > Oliver Sander wrote: > Touchpad pinching does not work for me, either. Would you

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

> On Oct. 2, 2016, 12:54 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > I tried to test with pinching on my touchpad, but apparently Qt doesn't > > handle the gestures from libinput or something. > > Oliver Sander wrote: > Touchpad pinching does not work for me, either. Would you

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128821/#review99717 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128821/ --- (Updated Okt. 2, 2016, 6:42 nachm.) Review request for Okular. Changes

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

> On Okt. 2, 2016, 12:54 nachm., Martin Tobias Holmedahl Sandsmark wrote: > > I tried to test with pinching on my touchpad, but apparently Qt doesn't > > handle the gestures from libinput or something. Touchpad pinching does not work for me, either. Would you expect that to work with my

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128821/#review99710 --- I tried to test with pinching on my touchpad, but apparently

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

> On Sept. 4, 2016, 3:38 p.m., Anthony Fieroni wrote: > > ui/pageview.cpp, line 1504 > > > > > > Martin wants early return for code clarification > > if (!pinch) { > > return false; > > } I

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

> On Sept. 4, 2016, 3:35 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > ui/pageview.h, line 134 > > > > > > nitpick; inconsistent spacing Okay - Oliver

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

> On Sept. 4, 2016, 10:14 a.m., Martin Tobias Holmedahl Sandsmark wrote: > > ui/pageview.cpp, line 1500 > > > > > > Don't put assignments in the if condition. > > > > Also, prefer to do an early exit,

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128821/ --- (Updated Sept. 4, 2016, 7:48 p.m.) Review request for Okular. Changes

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

> On Sept. 4, 2016, 10:14 a.m., Martin Tobias Holmedahl Sandsmark wrote: > > ui/pageview.cpp, line 1505 > > > > > > potentially uninitialized, add some default value. > > Oliver Sander wrote: > Okay. > >

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

> On Септ. 4, 2016, 1:14 след обяд, Martin Tobias Holmedahl Sandsmark wrote: > > ui/pageview.cpp, line 1505 > > > > > > potentially uninitialized, add some default value. > > Oliver Sander wrote: > Okay.

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128821/#review98878 --- Early return to don't have semicolumn below.

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128821/#review98876 --- Ship it! just some nitpicks, but nothing I think should

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

> On Sept. 4, 2016, 10:14 a.m., Martin Tobias Holmedahl Sandsmark wrote: > > ui/pageview.cpp, line 1500 > > > > > > Don't put assignments in the if condition. > > > > Also, prefer to do an early exit,

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

> On Sept. 4, 2016, 10:14 a.m., Martin Tobias Holmedahl Sandsmark wrote: > > I don't have a touch screen to test with, unfortunately. To bad. :-) Thanks for the reviews. > On Sept. 4, 2016, 10:14 a.m., Martin Tobias Holmedahl Sandsmark wrote: > > ui/pageview.cpp, line 1490 > >

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128821/ --- (Updated Sept. 4, 2016, 3:16 p.m.) Review request for Okular. Changes

Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128821/#review98864 --- I don't have a touch screen to test with, unfortunately.

Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128821/ --- Review request for Okular. Bugs: 366781