Re: [Call-for-​​Review][Calc]Data validity works incorrectly with criteria "Allow text length" for numbers

2012-08-01 Thread Lei Wang
Herbert, thank you for applying the patch. I planed to do it. But after merging this patch and updating to latest trunk code, I can not build trunk successfully for several days. On Wed, Aug 1, 2012 at 9:53 PM, Herbert Duerr wrote: > On 25.07.2012 07:11, Zhang Lu wrote: > >> One fix for review.

Re: [Call-for-​​Review][Calc]Data validity works incorrectly with criteria "Allow text length" for numbers

2012-08-01 Thread Herbert Duerr
On 25.07.2012 07:11, Zhang Lu wrote: One fix for review. https://issues.apache.org/ooo/show_bug.cgi?id=93128 [...] Root cause: There is no flow to handle a real number when selecting string length operation Solution: if operation is string length type, to get the number's length, and consider i

Re: [Call-for-​​Review][Calc]Data validity works incorrectly with criteria "Allow text length" for numbers

2012-07-27 Thread Lei Wang
I am taking care of this On Wed, Jul 25, 2012 at 1:11 PM, Zhang Lu wrote: > Hi~ > > One fix for review. > > https://issues.apache.org/ooo/show_bug.cgi?id=93128 > > Step: > > 1 Select the cells for which you want to define a new validity rule > 2 Choose Data - Validity > 3 On the Criteria tab pag

[Call-for-​​Review][Calc]Data validity works incorrectly with criteria "Allow text length" for numbers

2012-07-24 Thread Zhang Lu
Hi~ One fix for review. https://issues.apache.org/ooo/show_bug.cgi?id=93128 Step: 1 Select the cells for which you want to define a new validity rule 2 Choose Data - Validity 3 On the Criteria tab page, enter the conditions for new values entered into cells 4 In the Allow field, select "Text le