[Call-for-​​Review]Bug 120271 - Stock chart using Date as Category has Incorrect min/max candlestick value

2012-07-12 Thread bo . tian
I had fix the bug 120271 https://issues.apache.org/ooo/show_bug.cgi?id=120271 Could anyone help me to review the fix ? And how was my last fix of bug 112701 ? https://issues.apache.org/ooo/show_bug.cgi?id=112701 bo.tian

Re: [Call-for-​​Review]Bug 120271 - Stock chart using Date as Category has Incorrect min/max candlestick value

2012-07-12 Thread Clarence GUO
Hi~ Tian Bo, Basically I can understand the root cause of this defect and your solution. But could you please have a explanation in this issue in order to let more people easily understand the problem? I think the root cause is when update the chart view, VSeriesPlotter::getMaximumYInRange will cal

Re: [Call-for-​​Review]Bug 120271 - Stock chart using Date as Category has Incorrect min/max candlestick value

2012-07-13 Thread Andre Fischer
On 13.07.2012 05:45, bo.tian wrote: I had fix the bug 120271 https://issues.apache.org/ooo/show_bug.cgi?id=120271 Could anyone help me to review the fix ? And how was my last fix of bug 112701 ? https://issues.apache.org/ooo/show_bug.cgi?id=112701 I took the liberty to set the flag for request