On Mon, Jun 9, 2014 at 1:45 PM, Rick McGuire wrote:
>
> On Mon, Jun 9, 2014 at 4:37 PM, Mark Miesfeld wrote:
>
>> On Mon, Jun 9, 2014 at 1:24 PM, Rick McGuire
>> wrote:
>>
>>> Spotted a couple of things about the how the NSIS script is currently
>>> set up:
>>>
>>> 1) We're setting the variabl
On Mon, Jun 9, 2014 at 4:37 PM, Mark Miesfeld wrote:
> On Mon, Jun 9, 2014 at 1:24 PM, Rick McGuire
> wrote:
>
>> Spotted a couple of things about the how the NSIS script is currently set
>> up:
>>
>> 1) We're setting the variable NODOTVER on the makensis command line, but
>> I don't see any re
On Mon, Jun 9, 2014 at 1:24 PM, Rick McGuire wrote:
> Spotted a couple of things about the how the NSIS script is currently set
> up:
>
> 1) We're setting the variable NODOTVER on the makensis command line, but
> I don't see any references to this in the script. Is this still needed?
>
It was
Well, it matters here, because we're passing in x64 or x32 and the code is
looking for x86_64. So either the command line is not passing the correct
value, or the code is testing for the wrong one.
Rick
On Mon, Jun 9, 2014 at 4:31 PM, Michael Lueck
wrote:
> Rick McGuire wrote:
> > "x64", but
Rick McGuire wrote:
> "x64", but the script code is testing for the value "x86_64". One of these
> probably has to change...which one?
I suppose x64 could mean any 64-bit chip, not specifically Intel comparable.
IA64 comes to mind. I would lean towards spelling out "x86_64".
I am thankful,
-
Not sure about #1 but for #2 I would always test for 64 bit, but that is
just my preference. I don't think it really matters a whole lot.
David Ashley
On Mon, 2014-06-09 at 16:24 -0400, Rick McGuire wrote:
> Spotted a couple of things about the how the NSIS script is currently
> set up:
>
>
> 1
Spotted a couple of things about the how the NSIS script is currently set
up:
1) We're setting the variable NODOTVER on the makensis command line, but I
don't see any references to this in the script. Is this still needed?
2) The makensis command line is setting the variable CPU to either "x32"