Re: [Oorexx-devel] A couple of questions about the NSIS script.

2014-06-09 Thread Mark Miesfeld
On Mon, Jun 9, 2014 at 1:45 PM, Rick McGuire wrote: > > On Mon, Jun 9, 2014 at 4:37 PM, Mark Miesfeld wrote: > >> On Mon, Jun 9, 2014 at 1:24 PM, Rick McGuire >> wrote: >> >>> Spotted a couple of things about the how the NSIS script is currently >>> set up: >>> >>> 1) We're setting the variabl

Re: [Oorexx-devel] A couple of questions about the NSIS script.

2014-06-09 Thread Rick McGuire
On Mon, Jun 9, 2014 at 4:37 PM, Mark Miesfeld wrote: > On Mon, Jun 9, 2014 at 1:24 PM, Rick McGuire > wrote: > >> Spotted a couple of things about the how the NSIS script is currently set >> up: >> >> 1) We're setting the variable NODOTVER on the makensis command line, but >> I don't see any re

Re: [Oorexx-devel] A couple of questions about the NSIS script.

2014-06-09 Thread Mark Miesfeld
On Mon, Jun 9, 2014 at 1:24 PM, Rick McGuire wrote: > Spotted a couple of things about the how the NSIS script is currently set > up: > > 1) We're setting the variable NODOTVER on the makensis command line, but > I don't see any references to this in the script. Is this still needed? > It was

Re: [Oorexx-devel] A couple of questions about the NSIS script.

2014-06-09 Thread Rick McGuire
Well, it matters here, because we're passing in x64 or x32 and the code is looking for x86_64. So either the command line is not passing the correct value, or the code is testing for the wrong one. Rick On Mon, Jun 9, 2014 at 4:31 PM, Michael Lueck wrote: > Rick McGuire wrote: > > "x64", but

Re: [Oorexx-devel] A couple of questions about the NSIS script.

2014-06-09 Thread Michael Lueck
Rick McGuire wrote: > "x64", but the script code is testing for the value "x86_64". One of these > probably has to change...which one? I suppose x64 could mean any 64-bit chip, not specifically Intel comparable. IA64 comes to mind. I would lean towards spelling out "x86_64". I am thankful, -

Re: [Oorexx-devel] A couple of questions about the NSIS script.

2014-06-09 Thread David Ashley
Not sure about #1 but for #2 I would always test for 64 bit, but that is just my preference. I don't think it really matters a whole lot. David Ashley On Mon, 2014-06-09 at 16:24 -0400, Rick McGuire wrote: > Spotted a couple of things about the how the NSIS script is currently > set up: > > > 1

[Oorexx-devel] A couple of questions about the NSIS script.

2014-06-09 Thread Rick McGuire
Spotted a couple of things about the how the NSIS script is currently set up: 1) We're setting the variable NODOTVER on the makensis command line, but I don't see any references to this in the script. Is this still needed? 2) The makensis command line is setting the variable CPU to either "x32"