Re: [Oorexx-devel] interpreter->AttachThread(&context) continued

2008-07-13 Thread Rick McGuire
Yeah, if feels at times a little like the Apollo moon landing...a lot of work went into that "one small step" :-) Rick On Sun, Jul 13, 2008 at 7:09 PM, Mark Miesfeld <[EMAIL PROTECTED]> wrote: > On Sun, Jul 13, 2008 at 2:46 PM, Rick McGuire <[EMAIL PROTECTED]> wrote: > >> I committed fixes for th

Re: [Oorexx-devel] interpreter->AttachThread(&context) continued

2008-07-13 Thread Mark Miesfeld
On Sun, Jul 13, 2008 at 2:46 PM, Rick McGuire <[EMAIL PROTECTED]> wrote: > I committed fixes for this problem This is looking *very* good in ooDialog. Couldn't resist using my test code, I need to take small steps at a time. Some output: DID attach thread. context=7F499954 in onHelp arg

Re: [Oorexx-devel] interpreter->AttachThread(&context) continued

2008-07-13 Thread Rick McGuire
Generally, yes an AttachThread() should always be matched with a DetachThread() call. The interpreter instance won't terminate as long as there are active threads, so it's somewhat important to do good housekeeping, particularly in scenarios such as the one you just used where you attach frequentl

Re: [Oorexx-devel] interpreter->AttachThread(&context) continued

2008-07-13 Thread Mark Miesfeld
On Sun, Jul 13, 2008 at 2:46 PM, Rick McGuire <[EMAIL PROTECTED]> wrote: > I committed fixes for this problembut unfortunately, I also > committed your changes to oodialog by mistake. I'll take care of > reverting those changes in a minute. I reverted them, so we are good to go. > I still

Re: [Oorexx-devel] interpreter->AttachThread(&context) continued

2008-07-13 Thread Rick McGuire
Mark, I committed fixes for this problembut unfortunately, I also committed your changes to oodialog by mistake. I'll take care of reverting those changes in a minute. I still recommend that your invoking code just do a single AttachThread() when the thread initializes rather than storing t

Re: [Oorexx-devel] interpreter->AttachThread(&context) continued

2008-07-13 Thread Mark Miesfeld
On Sun, Jul 13, 2008 at 1:34 PM, Rick McGuire <[EMAIL PROTECTED]> wrote: > > I don't have Word, so debugging this using oodialog looks like the > approach we need to use. I just sent you a patch file and the ooDialog program. I'll keep looking at the OleObject crash, see if I can narrow that done

Re: [Oorexx-devel] interpreter->AttachThread(&context) continued

2008-07-13 Thread Rick McGuire
Mark, Your change looks correct. Yes, at the time I designed that API, I was assuming that attach might fail, but ended up not really finding any failure scenarios that would be caught. I don't have Word, so debugging this using oodialog looks like the approach we need to use. Rick On Sun, Jul

[Oorexx-devel] interpreter->AttachThread(&context) continued

2008-07-13 Thread Mark Miesfeld
Thought I'd start a new thread on this. (I did see your post by the way Rick. Your last commit fixed the crash.) In IntepreterInstanceStubs.cpp, AttachThread returns a logical: logical_t RexxEntry AttachThread(RexxInstance *c, RexxThreadContext **tc) { InstanceApiContext context(c); ret