Re: [OPEN-ILS-DEV] Putting the community's QA money where our dev mouth is

2013-11-05 Thread Jason Etheridge
> Building a test that relies on Concerto also means that once you log > into the system and make any changes that affect the database, you can > no longer depend on the results of tests run against that database. > You need a full stop, database rebuild, start of the system to get a > valid set of

Re: [OPEN-ILS-DEV] Putting the community's QA money where our dev mouth is

2013-11-05 Thread Dan Scott
On Tue, Nov 5, 2013 at 2:38 PM, Mike Rylander wrote: > Dan, > > I understand the process of building mock environments, but thanks. You're welcome. I'm sure that many other people reading this thread, now and in the future, might not, so hopefully my response will be helpful to them in understand

Re: [OPEN-ILS-DEV] Putting the community's QA money where our dev mouth is

2013-11-05 Thread Mike Rylander
Dan, I understand the process of building mock environments, but thanks. It's my understanding that concerto is intended to be a valid test environment, so I decided to go with that. Is that not the case? As I mentioned in IRC, changing my most recent test to create a mock env would be fine, of

Re: [OPEN-ILS-DEV] Putting the community's QA money where our dev mouth is

2013-11-05 Thread Dan Scott
On Tue, Nov 5, 2013 at 1:41 PM, Mike Rylander wrote: > CORRECTION: the commit hash is > 3e7f6f1503938e3e5a1cfe3bd90eaa8f021a0d48 ... I failed to fetch before > attempting to pick. Sorry! Hey Mike: It looks like that test assumes that the concerto sample records have been loaded, which means we c

Re: [OPEN-ILS-DEV] Putting the community's QA money where our dev mouth is

2013-11-05 Thread Mike Rylander
CORRECTION: the commit hash is 3e7f6f1503938e3e5a1cfe3bd90eaa8f021a0d48 ... I failed to fetch before attempting to pick. Sorry! --miker On Tue, Nov 5, 2013 at 12:41 PM, Mike Rylander wrote: > Dan, > > You're right, and I was personally remiss in leaving out a pgTAP test > for my recent repairs t

Re: [OPEN-ILS-DEV] Putting the community's QA money where our dev mouth is

2013-11-05 Thread Kathy Lussier
Thank you Jason! Your explanations were very helpful. Kathy Kathy Lussier Project Coordinator Massachusetts Library Network Cooperative (508) 343-0128 kluss...@masslnc.org Twitter: http://www.twitter.com/kmlussier On 11/5/2013 12:59 PM, Jason Etheridge wrote: On Tue, Nov 5, 2013 at 11:53 AM, K

Re: [OPEN-ILS-DEV] Putting the community's QA money where our dev mouth is

2013-11-05 Thread Jason Etheridge
On Tue, Nov 5, 2013 at 11:53 AM, Kathy Lussier wrote: > I'm guessing this message was sent mostly to get developer feedback on > including unit tests. However, since there has been no developer feedback > and since this e-mail raised a lot of questions for me, I'll jump in with > those questions.

Re: [OPEN-ILS-DEV] Putting the community's QA money where our dev mouth is

2013-11-05 Thread Mike Rylander
Dan, You're right, and I was personally remiss in leaving out a pgTAP test for my recent repairs to authority overlay generation in an attempt to avoid delaying 2.5 even a little bit. I've pushed 120e24dd6d26f2460d209421bbbc9a1777f4fb52 in order to remedy that. (Of course, if I got anything wron

Re: [OPEN-ILS-DEV] Putting the community's QA money where our dev mouth is

2013-11-05 Thread Jason Etheridge
I'm with Dan, and my offer is still on table for hand-holding. We need to maintain momentum for this to be effective. Do we want to organize an online training session for how to write tests, perhaps immediately following the next dev meeting? Galen and I volunteer for teaching that. Galen in p

Re: [OPEN-ILS-DEV] Putting the community's QA money where our dev mouth is

2013-11-05 Thread Kathy Lussier
I'm guessing this message was sent mostly to get developer feedback on including unit tests. However, since there has been no developer feedback and since this e-mail raised a lot of questions for me, I'll jump in with those questions. Overall, I support better QA practices and have been follo

[OPEN-ILS-DEV] November developers meeting

2013-11-05 Thread Kathy Lussier
Hi all, It's time to schedule a November Evergreen developers meeting. Please fill out the poll at http://doodle.com/n9avnst6nvs2342g to let us know what your availability is for a meeting next week. Thanks! Kathy -- Kathy Lussier Project Coordinator Massachusetts Library Network Cooperative