Re: [PATCH] decrease sndtmo

Mike Christie wrote: > On 07/31/2009 04:03 AM, Hannes Reinecke wrote: >> Mike Christie wrote: >>> tcp_sendpages/tcp_sendmsg can wait sndtmo seconds >>> if a connection goes bad. This then delays session >>> recovery, because that code must wait for the xmit >>> thread to flush. OTOH, if we did not

Re: logout takes ~50 seconds while running heavy IO

Mike Christie wrote: > Mike Christie wrote: >> Mike Christie wrote: >>> Mike Christie wrote: On 07/31/2009 07:43 AM, Erez Zilber wrote: > I thought that this patch just reduces the timeout from 15 to 3. Does > it also fix the 3 sndtmo periods or is it another patch? What was the A

Re: logout takes ~50 seconds while running heavy IO

Mike Christie wrote: > Mike Christie wrote: >> Mike Christie wrote: >>> On 07/31/2009 07:43 AM, Erez Zilber wrote: I thought that this patch just reduces the timeout from 15 to 3. Does it also fix the 3 sndtmo periods or is it another patch? What was the >>> Another patch. You should have

Re: [PATCH 2/2] libiscsi: check for pending TMF during task xmit

Mike Christie wrote: > Just try the attached simple one to fix the scsi cmd pdu being sent > problem. It was just a bad state check. Here is a new version of the simple patch that works for bnx2i. I have done some tests on both patches. I have not been able to replicate the problem though. I th

Re: [PATCH 2/2] libiscsi: check for pending TMF during task xmit

Mike Christie wrote: > On 07/31/2009 09:53 AM, Hannes Reinecke wrote: >> Hmm. I must admit I'm slightly at a loss here. >> I do have this function: > > Did you try my second patch queue-some-io-during-tmfs2.patch > http://groups.google.com/group/open-iscsi/attach/82cbb543dd913960/queue-some-io-dur

Re: logout takes ~50 seconds while running heavy IO

Mike Christie wrote: > Mike Christie wrote: >> On 07/31/2009 07:43 AM, Erez Zilber wrote: >>> I thought that this patch just reduces the timeout from 15 to 3. Does >>> it also fix the 3 sndtmo periods or is it another patch? What was the >> Another patch. You should have it. >> >>> bug that caused

Re: logout takes ~50 seconds while running heavy IO

Mike Christie wrote: > On 07/31/2009 07:43 AM, Erez Zilber wrote: >> I thought that this patch just reduces the timeout from 15 to 3. Does >> it also fix the 3 sndtmo periods or is it another patch? What was the > > Another patch. You should have it. > >> bug that caused the 3 sndtmo periods wait

Re: [PATCH] iscsi_tcp: Evaluate socket state in data_ready()

Hannes Reinecke wrote: > > The network core will call the state_change() callback > prior to the data_ready() callback, which might cause > us to lose a connection state change. > So we have to evaluate the socket state at the end > of the data_ready() callback, too. > > Signed-off-by: Hannes Rei

Re: logout takes ~50 seconds while running heavy IO

On 07/31/2009 07:37 AM, Erez Zilber wrote: >> but what we really want is a way to just signal that thread to wake right >> away. >> > > Is there a way to do that (signal the thread )? > I thought you could. I have tried doing signal, and various kernel apis, but no luck yet. > > Can this expla

Re: [PATCH 2/2] libiscsi: check for pending TMF during task xmit

On 07/31/2009 01:38 AM, Ulrich Windl wrote: > On 30 Jul 2009 at 10:52, Mike Christie wrote: > >> Ulrich Windl wrote: >>> On 29 Jul 2009 at 13:51, Mike Christie wrote: >>> >>> [...] If you check the LUN while an abort is sent, then you would prevent all IO to the LUN from being execu

Re: [PATCH 2/2] libiscsi: check for pending TMF during task xmit

On 07/31/2009 11:30 AM, Mike Christie wrote: > On 07/31/2009 09:53 AM, Hannes Reinecke wrote: >> Hmm. I must admit I'm slightly at a loss here. >> I do have this function: > > Did you try my second patch queue-some-io-during-tmfs2.patch > http://groups.google.com/group/open-iscsi/attach/82cbb543dd

Re: [PATCH 2/2] libiscsi: check for pending TMF during task xmit

On 07/31/2009 09:53 AM, Hannes Reinecke wrote: > Hmm. I must admit I'm slightly at a loss here. > I do have this function: Did you try my second patch queue-some-io-during-tmfs2.patch http://groups.google.com/group/open-iscsi/attach/82cbb543dd913960/queue-some-io-during-tmfs2.patch?part=2 or read

Re: logout takes ~50 seconds while running heavy IO

On 07/31/2009 07:43 AM, Erez Zilber wrote: > I thought that this patch just reduces the timeout from 15 to 3. Does > it also fix the 3 sndtmo periods or is it another patch? What was the Another patch. You should have it. > bug that caused the 3 sndtmo periods waiting? > I think I meant two. I

Re: [PATCH] decrease sndtmo

On 07/31/2009 04:03 AM, Hannes Reinecke wrote: > Mike Christie wrote: >> tcp_sendpages/tcp_sendmsg can wait sndtmo seconds >> if a connection goes bad. This then delays session >> recovery, because that code must wait for the xmit >> thread to flush. OTOH, if we did not wait at all >> we are less

How many S/W iSCSI Initiators on same machine?

Dear all, we are running a SLES 10SP2 system with 6 physical Ethernet ports. For instance is it possible to have 6 iSCSI initiators onthis system when each IP of these six ports are belonging to 6 different (Sub) Lans? THX, Rainer --~--~-~--~~~---~--~~ You receiv

Re: [PATCH] iscsi: Use GFP_ATOMIC in iscsi_offload_mesg().

From: Mike Christie Date: Wed, 29 Jul 2009 20:40:50 -0500 > On 07/29/2009 01:49 PM, Michael Chan wrote: >> Changing to GFP_ATOMIC because the only caller in cnic/bnx2i may >> be calling this function while holding spin_lock. >> >> This problem was discovered by Mike Christie. >> >> Signed-off-by

Re: [PATCH 2/2] libiscsi: check for pending TMF during task xmit

Hannes Reinecke wrote: > Hannes Reinecke wrote: >> Mike Christie wrote: >>> Mike Christie wrote: Hannes Reinecke wrote: > Sigh. Why do you have to make is so complicated ... > My patch was easy and simple originally. And now this :-) > This gets really ugly if we do it in lib

Re: logout takes ~50 seconds while running heavy IO

On Fri, Jul 31, 2009 at 9:43 AM, Ulrich Windl wrote: > > On 30 Jul 2009 at 19:25, Erez Zilber wrote: > >> >> Mike, >> >> I'm seeing some strange behavior that I don't completely understand: >> during heavy IO, I disconnect the cable on the target machine and >> after a few seconds, I'm trying to l

Re: logout takes ~50 seconds while running heavy IO

On Thu, Jul 30, 2009 at 8:25 PM, Mike Christie wrote: > > Mike Christie wrote: >> Erez Zilber wrote: >>> Mike, >>> >>> I'm seeing some strange behavior that I don't completely understand: >>> during heavy IO, I disconnect the cable on the target machine and >>> after a few seconds, I'm trying to l

Re: logout takes ~50 seconds while running heavy IO

On Thu, Jul 30, 2009 at 8:20 PM, Mike Christie wrote: > > Erez Zilber wrote: >> Mike, >> >> I'm seeing some strange behavior that I don't completely understand: >> during heavy IO, I disconnect the cable on the target machine and >> after a few seconds, I'm trying to logout from that target on the

Re: [PATCH 2/2] libiscsi: check for pending TMF during task xmit

Hannes Reinecke wrote: > Mike Christie wrote: >> Mike Christie wrote: >>> Hannes Reinecke wrote: Sigh. Why do you have to make is so complicated ... My patch was easy and simple originally. And now this :-) >>> This gets really ugly if we do it in libiscsi_tcp. I moved the check to

Re: [PATCH 2/2] libiscsi: check for pending TMF during task xmit

Mike Christie wrote: > Mike Christie wrote: >> Hannes Reinecke wrote: >>> Sigh. Why do you have to make is so complicated ... >>> My patch was easy and simple originally. And now this :-) >>> >> This gets really ugly if we do it in libiscsi_tcp. I moved the check to >> libiscsi and I changed the

Re: [PATCH] decrease sndtmo

Mike Christie wrote: > tcp_sendpages/tcp_sendmsg can wait sndtmo seconds > if a connection goes bad. This then delays session > recovery, because that code must wait for the xmit > thread to flush. OTOH, if we did not wait at all > we are less efficient in the lock management > because we must rea