Re: [PATCH 04/16] BNX2I: Updated the handling of NETEVENTs to alleviate recovery

2010-11-17 Thread Mike Christie
On 11/10/2010 05:04 PM, Eddie Wai wrote: case NETDEV_GOING_DOWN: - set_bit(ADAPTER_STATE_GOING_DOWN,hba-adapter_state); - iscsi_host_for_each_session(hba-shost, - bnx2i_drop_session); + /* Suspend all

Re: [PATCH 06/16] BNX2I: Added code to handle the binding of an existing connection

2010-11-17 Thread Mike Christie
On 11/10/2010 05:04 PM, Eddie Wai wrote: This is the case when iscsid gets re-launched due to features like iSCSI boot which requires the daemon to re-launch due to pivot root. If the code detected the connection had an existing endpoint, the old endpoint must get cleaned up. Signed-off-by:

Re: [PATCH 08/16] BNX2I: Added mutex lock protection to conn_get_param

2010-11-17 Thread Mike Christie
On 11/10/2010 05:04 PM, Eddie Wai wrote: - return iscsi_conn_get_param(cls_conn, param, buf); + len = iscsi_conn_get_param(cls_conn, param, buf); + if (len == -ENOSYS) + len = 0; Why are you returning 0 here? -- You received this

Re: [PATCH 09/16] BNX2I: Removed the dynamic registration of CNIC

2010-11-17 Thread Mike Christie
On 11/10/2010 05:04 PM, Eddie Wai wrote: The code no longer needs to dynamically register and unregister the CNIC device. The CNIC device will be kept registered until module unload. trailing whitespace in the patch. -- You received this message because you are subscribed to the Google

Re: [PATCH 12/16] BNX2I: Added feature to silently drop NOPOUT request

2010-11-17 Thread Mike Christie
On 11/10/2010 05:04 PM, Eddie Wai wrote: In the case the chip is undergoing different invasive operation which requires a chip reset, all NOPOUT request during this period For these invasive operations that reset the chip, do we always end up having to relogin the connection/session or once