Antw: [PATCH] iscsi: Simplify serial number comparisons

2011-04-07 Thread Ulrich Windl
Hi! I just wonder how safe the code is: Doesn't the difference of two unsigned ints give an unsigned value? The assigning an unsigned int to a signed int will definitely reduce the range... I feel that s32 diff = (s32) n1 - (s32) n2; also doesn't make the problem go away, unless ypou promot

Antw: Re: Missing block device /dev/sdX on iSCSI Initiator

2011-04-07 Thread Ulrich Windl
>>> Mike Christie schrieb am 07.04.2011 um 20:10 in Nachricht <4d9dfe0a.8070...@cs.wisc.edu>: > On 04/06/2011 04:30 AM, Joern Koerner wrote: > > Am 05.04.2011 19:45, schrieb Mike Christie: > >> On 04/04/2011 04:09 AM, Joern Koerner wrote: > >>> I testes some different distributions and it works fi

Re: Missing block device /dev/sdX on iSCSI Initiator

2011-04-07 Thread Mike Christie
On 04/07/2011 01:40 PM, Joern Koerner wrote: Something in the kernel must have busted. Could you send me the kernel .config that is used, and I will try to replicate that kernel here? Sure. I've attached it. I tested the 2.6.37 kernel with that config and tgt and it worked fine for me. Co

[PATCH] iscsi: Simplify serial number comparisons

2011-04-07 Thread Mark Rustad
Unsigned serial number comparison is very simple if you simply put the difference into a signed integer of the same size and then compare that value with zero. All the complexity and confusion fall away. Signed-off-by: Mark Rustad --- include/scsi/iscsi_proto.h | 21 - 1 fi

Re: Missing block device /dev/sdX on iSCSI Initiator

2011-04-07 Thread Joern Koerner
Am 07.04.2011 20:59, schrieb Mike Christie: On 04/06/2011 04:30 AM, Joern Koerner wrote: A rescan of the host has no success. $echo "- - -" > /sys/class/scsi_host/host10/scan $echo "scsi add-single-device 10 0 0 1" >/proc/scsi/scsi Weird. I checked the code and bother interfaces call the

Re: Missing block device /dev/sdX on iSCSI Initiator

2011-04-07 Thread Mike Christie
On 04/06/2011 04:30 AM, Joern Koerner wrote: A rescan of the host has no success. $echo "- - -" > /sys/class/scsi_host/host10/scan $echo "scsi add-single-device 10 0 0 1" >/proc/scsi/scsi Weird. I checked the code and bother interfaces call the same function. If you do echo - - 1 > /sys/

Re: Missing block device /dev/sdX on iSCSI Initiator

2011-04-07 Thread Mike Christie
On 04/06/2011 04:30 AM, Joern Koerner wrote: Am 05.04.2011 19:45, schrieb Mike Christie: On 04/04/2011 04:09 AM, Joern Koerner wrote: I testes some different distributions and it works fine (including the creation of /dev/sdX) on CentOS/RedHat but for example Ubuntu and ArchLinux it won't work.

Re: [PATCH] Remove redundant initialization

2011-04-07 Thread Mike Christie
On 04/07/2011 11:35 AM, Mark Rustad wrote: The variable len in iscsi_io_tcp_poll is initialized in its declaration, but also initialized before use. Remove the initialization in the declaration. Signed-off-by: Mark Rustad Tested-by: Ross Brattain --- usr/io.c |2 +- 1 files changed, 1 ins

[PATCH] Remove redundant initialization

2011-04-07 Thread Mark Rustad
The variable len in iscsi_io_tcp_poll is initialized in its declaration, but also initialized before use. Remove the initialization in the declaration. Signed-off-by: Mark Rustad Tested-by: Ross Brattain --- usr/io.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/usr/