Antw: [PATCH 7/9] Fix strict-aliasing warning with struct mac_address

[...] > diff --git a/iscsiuio/src/uip/ipv6.h b/iscsiuio/src/uip/ipv6.h > index 231f454..9e218fc 100644 > --- a/iscsiuio/src/uip/ipv6.h > +++ b/iscsiuio/src/uip/ipv6.h > @@ -71,7 +71,13 @@ struct udp_hdr { > }; > > struct mac_address { > - u8_t addr[6]; > + union { > + u8_t a

Re: [PATCH 7/9] Fix strict-aliasing warning with struct mac_address

On 10/06/14 18:36, Andy Grover wrote: struct mac_address { - u8_t addr[6]; + union { + u8_t addr[6]; + struct { + u16_t first_2_bytes; + u32_t last_4_bytes; + }; + }; }; This patch change

Antw: [PATCH 6/9] Add -Wno-unused-but-set-variable to some iscsiuio CFLAGS

[...] > diff --git a/iscsiuio/src/uip/Makefile.am b/iscsiuio/src/uip/Makefile.am > index 16170d7..d728c8e 100644 > --- a/iscsiuio/src/uip/Makefile.am > +++ b/iscsiuio/src/uip/Makefile.am > @@ -2,7 +2,8 @@ AM_CFLAGS = -I${top_srcdir}/src/unix\ [...] > + -Wno-unused-but-

Antw: [PATCH 2/9] Fix warning about possibly-uninitialized variable

>>> Andy Grover schrieb am 06.10.2014 um 18:36 in Nachricht <1412613374-5752-3-git-send-email-agro...@redhat.com>: > Signed-off-by: Andy Grover > --- > usr/iscsiadm.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/usr/iscsiadm.c b/usr/iscsiadm.c > index f886d39..0

[PATCH 9/9] Fix strict aliasing issue with IPV6_IS_ADDR_UNSPECIFIED and remove unused

There already is a union to reference the memory as an array of uints, so just use it for IS_ADDR_UNSPECIFIED. All the others aren't used so we can remove them. Signed-off-by: Andy Grover --- iscsiuio/src/uip/ipv6.h | 31 +-- 1 file changed, 5 insertions(+), 26 deleti

[PATCH 3/9] Fix bad sizeof in memset

Signed-off-by: Andy Grover --- usr/md5.c | 2 +- utils/md5.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/usr/md5.c b/usr/md5.c index 4ef1cb7..ba6c86d 100644 --- a/usr/md5.c +++ b/usr/md5.c @@ -127,7 +127,7 @@ MD5Final(md5byte digest[16], struct MD5Context *ctx)

[PATCH 0/9] Warning cleanups

gcc 4.8.3 emits some warnings, which this patchset resolves. Regards -- Andy Andy Grover (9): Fix build warnings for unused variables Fix warning about possibly-uninitialized variable Fix bad sizeof in memset Fix missing header Fix warning about non-matching types Add -Wno-unused-but-

[PATCH 4/9] Fix missing header

Signed-off-by: Andy Grover --- usr/mgmt_ipc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/usr/mgmt_ipc.c b/usr/mgmt_ipc.c index ee037d9..c16bce9 100644 --- a/usr/mgmt_ipc.c +++ b/usr/mgmt_ipc.c @@ -36,6 +36,7 @@ #include "sysdeps.h" #include "iscsi_ipc.h" #include "iscsi_err.h" +#inclu

[PATCH 6/9] Add -Wno-unused-but-set-variable to some iscsiuio CFLAGS

There are a fair number of warnings generated by the unused-but-set warning in recent versions of GCC. These sometimes are there for completeness and are not harmful, so a better choice may be to just silence the warnings. Signed-off-by: Andy Grover --- iscsiuio/src/uip/Makefile.am | 3 ++-

[PATCH 2/9] Fix warning about possibly-uninitialized variable

Signed-off-by: Andy Grover --- usr/iscsiadm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/usr/iscsiadm.c b/usr/iscsiadm.c index f886d39..0cdc1bb 100644 --- a/usr/iscsiadm.c +++ b/usr/iscsiadm.c @@ -2211,7 +2211,7 @@ static void print_host_stats(struct iscsi_offload_h

[PATCH 8/9] Resolve strict aliasing issue in iscsiuio/src/unix/nic.c

Break up the expression and use a local variable. Signed-off-by: Andy Grover --- iscsiuio/src/unix/nic.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/iscsiuio/src/unix/nic.c b/iscsiuio/src/unix/nic.c index e00e8f2..d56a9da 100644 --- a/iscsiuio/src/unix/nic.c +++ b/i

[PATCH 1/9] Fix build warnings for unused variables

Signed-off-by: Andy Grover --- usr/be2iscsi.c | 1 - usr/login.c | 2 -- usr/netlink.c | 3 +-- utils/open-isns/bitvector.c | 15 ++- utils/open-isns/dd.c| 3 +-- 5 files changed, 8 insertions(+), 16 deletions(-) diff --git a/usr

[PATCH 5/9] Fix warning about non-matching types

Signed-off-by: Andy Grover --- iscsiuio/src/unix/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/iscsiuio/src/unix/main.c b/iscsiuio/src/unix/main.c index e33db04..a789de5 100644 --- a/iscsiuio/src/unix/main.c +++ b/iscsiuio/src/unix/main.c @@ -233,7 +233,7 @@ int main(