Antw: [PATCH 4/4] Spelling and escaping error fixes.

Hi! A comment on likes like this: > +\fBiscsiadm\fR \-m discoverydb [ \-hV ] [ \-d debug_level ] [ \-P printlevel > ] I think such lines should be restructured for redability and better diff-ing like this: .B iscsiadm .B \-m discoverydb .RB [ \-hV ] .RB [ \-d .IR debug_level ] .RB [ \-P .IR pr

Antw: [PATCH 2/4] buildsys: respect CFLAGS and LDFLAGS from the outside

Hi! Some remarks on the CFLAGS thing: In one of my projects I used this approach for messing with CFLAGS: -- CFLAGS=-pthread CWARNFLAGS=-Wall -Wextra -Wshadow COPTFLAGS=-pipe -O2 CDEBUGFLAGS=-g -fstack-protector-all CFLAGS+=$(CWARNFLAGS) CFLAGS+=$(COPTFLAGS) #CFLAGS+=$(CDEBUGFLAGS) LDFLAGS=-lpthre

Re: [RFC PATCH 0/4] Make iSCSI network namespace aware

On Thu, May 21, 2015 at 11:04:46AM +0200, Hannes Reinecke wrote: > On 05/20/2015 08:45 PM, Andy Grover wrote: > > On 05/13/2015 03:12 PM, Chris Leech wrote: > >> This is only about the structures and functionality involved in > >> maintaining the > >> iSCSI session, the SCSI host along with it's di

Re: Restarting iscsid, iscsi socket protocol stability

On 05/28/2015 02:55 PM, Christian Seiler wrote: > Trying again, since google groups thought my response was spam > (twice)... (Explicitly putting you on Cc so at least you get my message.) > > On 28.05.2015 20:56, Mike Christie wrote: >> On 05/26/2015 04:14 PM, Christian Seiler wrote: >>> Final qu

Re: Restarting iscsid, iscsi socket protocol stability

On 05/26/2015 04:14 PM, Christian Seiler wrote: > Thanks for your quick reply. > > On 05/26/2015 10:56 PM, Mike Christie wrote: >> On 5/26/15, 1:24 PM, Christian Seiler wrote: >>> 1. How stable is the socket protocol between iscsiadm and iscsid? Are >>> there any guarantuees there? Or could it hap

[PATCH 4/4] Spelling and escaping error fixes.

From: Ritesh Raj Sarraf --- doc/iscsiadm.8 | 14 +++--- usr/auth.c | 2 +- usr/initiator_common.c | 2 +- usr/netlink.c | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/doc/iscsiadm.8 b/doc/iscsiadm.8 index 05793b2..64ef2e0 100644 -

[PATCH 3/4] Remove outdated Debian packaging code.

There are now official Debian and Ubuntu packages for open-iscsi that were originally based on this code but have been updated with new versions. The current packaging code on the other hand here hasn't been updated in 10 years and is out of date (probably doesn't even build anymore). Remove it, t

[PATCH 2/4] buildsys: respect CFLAGS and LDFLAGS from the outside

Make the build systsem respect CFLAGS and LDFLAGS set from the outside. Previously, OPTFLAGS could be set to alter CFLAGS (which were overridden completely), but that is non-standard, so also check for user-set CFLAGS. This will make life easier when packaging this for distributions. If OPTFLAGS is

[PATCH 1/4] buildsys: make 'make clean' idempotent

Make sure 'make clean' will always succeed. Also make distclean in iscsiuio subdirectory. --- Makefile | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 79bad84..188e3bd 100644 --- a/Makefile +++ b/Makefile @@ -69,9 +69,10 @@ clean: $(MAKE

[PATCH 0/4] Assorted fixes

Hi, I've been going through Debian's packaging of open-iscsi and I've noticed that a couple of fixes that should go upstream (with some improvements I'll make to Debian's package this will bring the number of patches in Debian down to zero). I've polished them a bit and am forwarding them here. S