Re: [PATCH v4] iscsi: Perform connection failure entirely in kernel space

2020-01-03 Thread 'Khazhismel Kumykov' via open-iscsi
On Fri, Jan 3, 2020 at 2:26 PM Gabriel Krisman Bertazi wrote: > Please consider the v4 below with the lock added. > Reviewed-by: Khazhismel Kumykov -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop

[PATCH v4] iscsi: Perform connection failure entirely in kernel space

2020-01-03 Thread Gabriel Krisman Bertazi
Khazhismel Kumykov writes: >> >> + if (!list_empty(>conn_list_err)) >> > Does this check need to be under connlock? >> >> My understanding is that it is not necessary, since it is serialized >> against the conn removal itself, through the rx_mutex, it seemed safe to >> do the verification