Re: [PATCH 0/3] drivers base: transport component error propagation

2020-01-15 Thread Martin K. Petersen
Gabriel, > This small series improves error propagation on the transport > component to prevent an inconsistent state in the iscsi module. The > bug that motivated this patch results in a hanging iscsi connection > that cannot be used or removed by userspace, since the session is in > an

Re: [PATCH v4] iscsi: Perform connection failure entirely in kernel space

2020-01-15 Thread Martin K. Petersen
> Please consider the v4 below with the lock added. Lee: Please re-review this given the code change. > From: Bharath Ravi > > Connection failure processing depends on a daemon being present to (at > least) stop the connection and start recovery. This is a problem on a > multipath scenario,

Re: [PATCH RESEND] iscsi: Don't destroy session if there are outstanding connections

2020-01-15 Thread Martin K. Petersen
Gabriel, > A faulty userspace that calls destroy_session() before destroying the > connections can trigger the failure. This patch prevents the issue by > refusing to destroy the session if there are outstanding connections. Applied to 5.6/scsi-queue, thanks! -- Martin K. Petersen

iSCSI Multiqueue

2020-01-15 Thread Bobby
Hi all, I have a question regarding multi-queue in iSCSI. AFAIK, *scsi-mq* has been functional in kernel since kernel 3.17. Because earlier, the block layer was updated to multi-queue *blk-mq* from single-queue. So the current kernel has full-fledged *multi-queues*. The question is: How an