Re: [PATCH v2] scsi: libiscsi: move init ehwait to iscsi_session_setup()

2021-09-13 Thread Mike Christie
On 9/11/21 8:51 AM, Ding Hui wrote: > The commit ec29d0ac29be ("scsi: iscsi: Fix conn use after free during > resets") move member ehwait from conn to session, but left init ehwait > in iscsi_conn_setup(). > > Although a session can only have 1 conn currently, it is better to > do init ehwait in i

Re: [PATCH -next] scsi: iscsi: Adjuest iface sysfs attr detection

2021-09-13 Thread Martin K. Petersen
On Wed, 1 Sep 2021 16:53:36 +0800, Baokun Li wrote: > ISCSI_NET_PARAM_IFACE_ENABLE belongs to enum iscsi_net_param instead of > iscsi_iface_param,so move it to ISCSI_NET_PARAM. Otherwise, when we call > into the driver we might not match and return that we don't want attr > visible in sysfs. Found

Re: [PATCH v2] scsi: libiscsi: move init ehwait to iscsi_session_setup()

2021-09-13 Thread Martin K. Petersen
Ding, > The commit ec29d0ac29be ("scsi: iscsi: Fix conn use after free during > resets") move member ehwait from conn to session, but left init ehwait > in iscsi_conn_setup(). > > Although a session can only have 1 conn currently, it is better to do > init ehwait in iscsi_session_setup() to prev