Re: [PATCH v4] iscsi: Perform connection failure entirely in kernel space

2020-01-03 Thread 'Khazhismel Kumykov' via open-iscsi
On Fri, Jan 3, 2020 at 2:26 PM Gabriel Krisman Bertazi wrote: > Please consider the v4 below with the lock added. > Reviewed-by: Khazhismel Kumykov -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop

Re: [PATCH v3] iscsi: Perform connection failure entirely in kernel space

2020-01-02 Thread 'Khazhismel Kumykov' via open-iscsi
On Thu, Jan 2, 2020 at 1:13 PM Gabriel Krisman Bertazi wrote: > > Khazhismel Kumykov writes: > > > On Thu, Dec 26, 2019 at 3:48 PM Gabriel Krisman Bertazi > > wrote: > >> > >> From: Bharath Ravi > >> > >> Connection failure processing depends on a daemon being present to (at > >> least) stop

Re: [PATCH v3] iscsi: Perform connection failure entirely in kernel space

2020-01-02 Thread 'Khazhismel Kumykov' via open-iscsi
On Thu, Dec 26, 2019 at 3:48 PM Gabriel Krisman Bertazi wrote: > > From: Bharath Ravi > > Connection failure processing depends on a daemon being present to (at > least) stop the connection and start recovery. This is a problem on a > multipath scenario, where if the daemon failed for whatever

Re: [PATCH] iscsi: Perform connection failure entirely in kernel space

2019-12-16 Thread 'Khazhismel Kumykov' via open-iscsi
On Mon, Dec 9, 2019 at 10:21 AM Gabriel Krisman Bertazi wrote: > > From: Bharath Ravi > > Connection failure processing depends on a daemon being present to (at > least) stop the connection and start recovery. This is a problem on a > multipath scenario, where if the daemon failed for whatever

Re: [Patch v2 1/2] libiscsi: Fix use-after-free race during iscsi_session_teardown

2017-09-29 Thread 'Khazhismel Kumykov' via open-iscsi
Noticed these don't seem to be in 4.14/scsi-queue On Tue, Aug 29, 2017 at 6:45 PM, Martin K. Petersen wrote: > > Chris, > >> Looks good to me, fixes up the code given that the comment there about >> calling iscsi_remove_session wasn't being followed. > > Applied these

[PATCH] iscsi_if.h: use attribute instead of '__packed'

2017-09-01 Thread 'Khazhismel Kumykov' via open-iscsi
More consistent, doesn't rely on __packed being defined in userspace. Signed-off-by: Khazhismel Kumykov --- include/iscsi_if.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/iscsi_if.h b/include/iscsi_if.h index 9d15811..5be1981 100644 ---

Re: [Patch v2 1/2] libiscsi: Fix use-after-free race during iscsi_session_teardown

2017-08-24 Thread 'Khazhismel Kumykov' via open-iscsi
On Thu, Jul 13, 2017 at 9:11 AM, Khazhismel Kumykov wrote: Ping in case this was missed -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to

[Patch v2 2/2] libiscsi: Remove iscsi_destroy_session

2017-07-13 Thread 'Khazhismel Kumykov' via open-iscsi
iscsi_session_teardown was the only user of this function. Function currently is just short for iscsi_remove_session + iscsi_free_session. Signed-off-by: Khazhismel Kumykov --- drivers/scsi/scsi_transport_iscsi.c | 16 include/scsi/scsi_transport_iscsi.h | 1

[Patch v2 1/2] libiscsi: Fix use-after-free race during iscsi_session_teardown

2017-07-13 Thread 'Khazhismel Kumykov' via open-iscsi
Session attributes exposed through sysfs were freed before the device was destroyed, resulting in a potential use-after-free. Free these attributes after removing the device. Signed-off-by: Khazhismel Kumykov --- drivers/scsi/libiscsi.c | 8 1 file changed, 4

[PATCH] libiscsi: Remove iscsi_destroy_session

2017-07-12 Thread 'Khazhismel Kumykov' via open-iscsi
iscsi_session_teardown was the only user of this function. Function currently is just short for iscsi_remove_session + iscsi_free_session. Signed-off-by: Khazhismel Kumykov --- with "libiscsi: Fix use after free race during iscsi_session_teardown" removing the last user.

[PATCH] libiscsi: Fix use-after-free race during iscsi_session_teardown

2017-07-12 Thread 'Khazhismel Kumykov' via open-iscsi
Session attributes exposed through sysfs were freed before the device was destroyed, resulting in a potential use-after-free. Free these attributes after removing the device. Signed-off-by: Khazhismel Kumykov --- drivers/scsi/libiscsi.c | 8 1 file changed, 4