> +config CNIC
> +tristate "Broadcom CNIC support"
> +depends on BNX2
I suspect you'll need a "depends on INET" somewhere (probably here, but
maybe only for the iSCSI part).
- R.
--~--~-~--~~~---~--~~
You received this message because you are subscrib
Hi Michael, I was reading over the driver to try and figure out how you
handle allocating source ports for the offloaded TCP connections you
make so that they don't collide with the main network stack. It looks
like you have:
> +/**
> + * bnx2i_alloc_tcp_port - allocates a tcp port from the fr
> +/* Tell compiler that status_blk fields can change. */
> +barrier();
> +if (status_idx != sblk->status_idx) {
Is a compiler barrier sufficient here? It seems an out-of-order CPU
could still mess things up, so an rmb() or smp_rmb() would be required.
--~
