Re: [PATCH] Allow empty username for CHAP

2010-01-12 Thread Mike Christie
On 09/29/2009 08:46 AM, Hannes Reinecke wrote: Some iSCSI implementations (eg HP) is using an empty username for CHAP negotiations. So we should be allowing the same. Signed-off-by: Hannes Reineckeh...@suse.de I fixed up the discovery code and merged this in commit

Re: [PATCH] Allow empty username for CHAP

2009-10-12 Thread Ulrich Windl
On 30 Sep 2009 at 8:32, Hannes Reinecke wrote: Can you have a empty incoming username? If so I think we need to modify acl_chap_auth_request like how you did to acl_set_user_name. No, not what I've seen so far; but I haven't been exactly successful here. I'll dig further here. Maybe it's

Re: [PATCH] Allow empty username for CHAP

2009-10-12 Thread Ulrich Windl
Hi! Let me point out a related problem on SLES10 SP2: When iSCSI discovery fails, the iSCSI Script skips to log in to any targets. However if the targets were successfully discovered before, this makes no sense. (The reason why discovery might fail is exactly that of CHAP problems) Regards,

Re: [PATCH] Allow empty username for CHAP

2009-10-11 Thread Mike Christie
On 09/29/2009 08:46 AM, Hannes Reinecke wrote: Some iSCSI implementations (eg HP) is using an empty username for CHAP negotiations. So we should be allowing the same. I updated this patch so you can also support empty usernames for discovery. I do not have a target where I cannot add a empty

Re: [PATCH] Allow empty username for CHAP

2009-10-06 Thread Mike Christie
On 10/02/2009 02:33 AM, Hannes Reinecke wrote: I would go with this option for a start. We really should aim for making iscsiadm to be as flexible as possible, up to the point where iscsid.conf really just sets some sensible defaults; everything else should be tweaked via calls to iscsiadm.

Re: [PATCH] Allow empty username for CHAP

2009-09-30 Thread Hannes Reinecke
Mike Christie wrote: On 09/29/2009 08:46 AM, Hannes Reinecke wrote: Some iSCSI implementations (eg HP) is using an empty username for CHAP negotiations. So we should be allowing the same. Do we need this support for discovery? There is one other one auth setup function in

Re: [PATCH] Allow empty username for CHAP

2009-09-30 Thread Mike Christie
On 09/30/2009 01:32 AM, Hannes Reinecke wrote: Mike Christie wrote: On 09/29/2009 08:46 AM, Hannes Reinecke wrote: Some iSCSI implementations (eg HP) is using an empty username for CHAP negotiations. So we should be allowing the same. Do we need this support for discovery? There is one

Re: [PATCH] Allow empty username for CHAP

2009-09-29 Thread Mike Christie
On 09/29/2009 08:46 AM, Hannes Reinecke wrote: Some iSCSI implementations (eg HP) is using an empty username for CHAP negotiations. So we should be allowing the same. Do we need this support for discovery? There is one other one auth setup function in discovery.c:setup_authentication(). Not