Re: [PATCH] iscsi: Fix deadlock on recovery path during GFP_IO reclaim

2020-05-19 Thread Gabriel Krisman Bertazi
"Martin K. Petersen" writes: > Gabriel, > >> iscsi suffers from a deadlock in case a management command submitted >> via the netlink socket sleeps on an allocation while holding the >> rx_queue_mutex, > > This does not apply to 5.8/scsi-queue. Please resubmit. Hi Martin, Apparently it conflicte

Re: [PATCH] iscsi: Fix deadlock on recovery path during GFP_IO reclaim

2020-05-19 Thread Martin K. Petersen
Gabriel, > iscsi suffers from a deadlock in case a management command submitted > via the netlink socket sleeps on an allocation while holding the > rx_queue_mutex, This does not apply to 5.8/scsi-queue. Please resubmit. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- You re

Re: [PATCH] iscsi: Fix deadlock on recovery path during GFP_IO reclaim

2020-05-18 Thread Lee Duncan
On 5/18/20 11:53 AM, Gabriel Krisman Bertazi wrote: > Lee Duncan writes: > >> On 5/7/20 10:59 PM, Gabriel Krisman Bertazi wrote: >>> iscsi suffers from a deadlock in case a management command submitted via >>> the netlink socket sleeps on an allocation while holding the >>> rx_queue_mutex, if tha

Re: [PATCH] iscsi: Fix deadlock on recovery path during GFP_IO reclaim

2020-05-18 Thread Gabriel Krisman Bertazi
Lee Duncan writes: > On 5/7/20 10:59 PM, Gabriel Krisman Bertazi wrote: >> iscsi suffers from a deadlock in case a management command submitted via >> the netlink socket sleeps on an allocation while holding the >> rx_queue_mutex, if that allocation causes a memory reclaim that >> writebacks to a

Re: [PATCH] iscsi: Fix deadlock on recovery path during GFP_IO reclaim

2020-05-17 Thread Lee Duncan
On 5/7/20 10:59 PM, Gabriel Krisman Bertazi wrote: > iscsi suffers from a deadlock in case a management command submitted via > the netlink socket sleeps on an allocation while holding the > rx_queue_mutex, if that allocation causes a memory reclaim that > writebacks to a failed iscsi device. Then

Re: [PATCH] iscsi: Fix deadlock on recovery path during GFP_IO reclaim

2020-05-14 Thread Martin K. Petersen
Lee/Chris: Please review! > iscsi suffers from a deadlock in case a management command submitted via > the netlink socket sleeps on an allocation while holding the > rx_queue_mutex, if that allocation causes a memory reclaim that > writebacks to a failed iscsi device. Then, the recovery procedu

[PATCH] iscsi: Fix deadlock on recovery path during GFP_IO reclaim

2020-05-07 Thread Gabriel Krisman Bertazi
iscsi suffers from a deadlock in case a management command submitted via the netlink socket sleeps on an allocation while holding the rx_queue_mutex, if that allocation causes a memory reclaim that writebacks to a failed iscsi device. Then, the recovery procedure can never make progress to recover