Re: [PATCH] scsi:libiscsi: remove unnecessary memset in iscsi_conn_setup

2022-03-29 Thread Martin K. Petersen
Wenchao, > iscsi_cls_conn is alloced by kzalloc(), the whole iscsi_cls_conn is > zero filled already including the dd_data. So it is unnecessary to > call memset again. Applied to 5.18/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering -- You received this message bec

Re: [PATCH] scsi:libiscsi: remove unnecessary memset in iscsi_conn_setup

2022-03-17 Thread 'Lee Duncan' via open-iscsi
On 3/17/22 08:01, Wenchao Hao wrote: iscsi_cls_conn is alloced by kzalloc(), the whole iscsi_cls_conn is zero filled already including the dd_data. So it is unnecessary to call memset again. Signed-off-by: Wenchao Hao Reviewed-by: Wu Bo Reviewed-by: Lee Duncan --- drivers/scsi/libiscsi.c |

Re: [PATCH] scsi:libiscsi: remove unnecessary memset in iscsi_conn_setup

2022-03-17 Thread Mike Christie
On 3/17/22 10:01 AM, Wenchao Hao wrote: > iscsi_cls_conn is alloced by kzalloc(), the whole iscsi_cls_conn is > zero filled already including the dd_data. So it is unnecessary to > call memset again. > > Signed-off-by: Wenchao Hao > Reviewed-by: Wu Bo > Reviewed-by: Lee Duncan > --- > drivers/

[PATCH] scsi:libiscsi: remove unnecessary memset in iscsi_conn_setup

2022-03-16 Thread 'Wenchao Hao' via open-iscsi
iscsi_cls_conn is alloced by kzalloc(), the whole iscsi_cls_conn is zero filled already including the dd_data. So it is unnecessary to call memset again. Signed-off-by: Wenchao Hao Reviewed-by: Wu Bo Reviewed-by: Lee Duncan --- drivers/scsi/libiscsi.c | 1 - 1 file changed, 1 deletion(-) diff

Re: [PATCH] scsi:libiscsi: remove unnecessary memset in iscsi_conn_setup

2022-03-16 Thread Mike Christie
On 3/16/22 4:02 AM, Wenchao Hao wrote: > cc open-iscsi@googlegroups.com linux-s...@vger.kernel.org > > On 2022/3/17 6:09, Wenchao Hao wrote: >> iscsi_cls_conn is alloced by kzalloc(), the whole iscsi_cls_conn is >> zero filled already including the dd_data. So it is unnecessary to >> call memset a

Re: [PATCH] scsi:libiscsi: remove unnecessary memset in iscsi_conn_setup

2022-03-16 Thread 'Wenchao Hao' via open-iscsi
cc open-iscsi@googlegroups.com linux-s...@vger.kernel.org On 2022/3/17 6:09, Wenchao Hao wrote: iscsi_cls_conn is alloced by kzalloc(), the whole iscsi_cls_conn is zero filled already including the dd_data. So it is unnecessary to call memset again. Signed-off-by: Wenchao Hao Reviewed-by: Wu B