[PATCH 1/4 2.6.28] cxgb3 - manage a private ip address for iSCSI

2008-08-27 Thread Karen Xie
[PATCH 1/4 2.6.28] cxgb3 - manage a private ip address for iSCSI From: Karen Xie <[EMAIL PROTECTED]> Create a per port sysfs entry to pass an IP address to the NIC driver, and a control call for the iSCSI driver to grab it. The IP address is required in both drivers to manage ARP reques

Re: [PATCH 1/4 2.6.28] cxgb3 - manage a private ip address for iSCSI

2008-08-23 Thread Herbert Xu
On Fri, Aug 22, 2008 at 07:08:51PM +, Andrew Morton wrote: > >> +static ssize_t iscsi_ipaddr_attr_store(struct device *d, >> +const char *buf, size_t len) >> +{ >> + struct port_info *pi = netdev_priv(to_net_dev(d)); >> + __be32 a = 0; > > There's n

Re: [PATCH 1/4 2.6.28] cxgb3 - manage a private ip address for iSCSI

2008-08-23 Thread Steve Wise
Andrew Morton wrote: > On Fri, 22 Aug 2008 14:17:18 -0500 > Steve Wise <[EMAIL PROTECTED]> wrote: > > >> Andrew Morton wrote: >> + unsigned long octet; + const char *parse = buf; + char *endp; + int i; + + for (i = 1; i <= 4; i++) { + octet

Re: [PATCH 1/4 2.6.28] cxgb3 - manage a private ip address for iSCSI

2008-08-23 Thread Steve Wise
Andrew Morton wrote: >> +unsigned long octet; >> +const char *parse = buf; >> +char *endp; >> +int i; >> + >> +for (i = 1; i <= 4; i++) { >> +octet = simple_strtoul(parse, &endp, 10); >> +if (endp == buf || octet > 255 || >> +(i < 4 && *e

Re: [PATCH 1/4 2.6.28] cxgb3 - manage a private ip address for iSCSI

2008-08-23 Thread Andrew Morton
On Fri, 22 Aug 2008 14:17:18 -0500 Steve Wise <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > >> + unsigned long octet; > >> + const char *parse = buf; > >> + char *endp; > >> + int i; > >> + > >> + for (i = 1; i <= 4; i++) { > >> + octet = simple_strtoul(parse, &endp, 10); > >>

Re: [PATCH 1/4 2.6.28] cxgb3 - manage a private ip address for iSCSI

2008-08-23 Thread Andrew Morton
On Fri, 22 Aug 2008 11:38:32 -0700 Karen Xie <[EMAIL PROTECTED]> wrote: > [PATCH 1/4 2.6.28] cxgb3 - manage a private ip address for iSCSI > > From: Karen Xie <[EMAIL PROTECTED]> > > Create a per port sysfs entry to pass an IP address to the NIC driver, and a &

[PATCH 1/4 2.6.28] cxgb3 - manage a private ip address for iSCSI

2008-08-22 Thread Karen Xie
[PATCH 1/4 2.6.28] cxgb3 - manage a private ip address for iSCSI From: Karen Xie <[EMAIL PROTECTED]> Create a per port sysfs entry to pass an IP address to the NIC driver, and a control call for the iSCSI driver to grab it. The IP address is required in both drivers to manage ARP reques