Re: [PATCH 12/16] BNX2I: Added feature to silently drop NOPOUT request

2010-11-19 Thread Mike Christie
On 11/18/2010 03:59 PM, Eddie Wai wrote: As for the NOPOUT requests, since the NOPOUT send request failed, the last_ping jiffies count would not get updated. Then the iscsi_check_transport_timeouts callback will just keeps getting called and stalling the system. Perhaps a better way to do this

Re: [PATCH 12/16] BNX2I: Added feature to silently drop NOPOUT request

2010-11-18 Thread Eddie Wai
On Thu, 2010-11-18 at 12:04 -0800, Mike Christie wrote: > On 11/18/2010 01:55 PM, Mike Christie wrote: > > On 11/18/2010 01:25 PM, Eddie Wai wrote: > >> > >> On Wed, 2010-11-17 at 19:40 -0800, Mike Christie wrote: > >>> On 11/10/2010 05:04 PM, Eddie Wai wrote: > In the case the chip is underg

Re: [PATCH 12/16] BNX2I: Added feature to silently drop NOPOUT request

2010-11-18 Thread Mike Christie
On 11/18/2010 01:55 PM, Mike Christie wrote: On 11/18/2010 01:25 PM, Eddie Wai wrote: On Wed, 2010-11-17 at 19:40 -0800, Mike Christie wrote: On 11/10/2010 05:04 PM, Eddie Wai wrote: In the case the chip is undergoing different invasive operation which requires a chip reset, all NOPOUT reques

Re: [PATCH 12/16] BNX2I: Added feature to silently drop NOPOUT request

2010-11-18 Thread Mike Christie
On 11/18/2010 01:25 PM, Eddie Wai wrote: On Wed, 2010-11-17 at 19:40 -0800, Mike Christie wrote: On 11/10/2010 05:04 PM, Eddie Wai wrote: In the case the chip is undergoing different invasive operation which requires a chip reset, all NOPOUT request during this period For these invasive oper

Re: [PATCH 12/16] BNX2I: Added feature to silently drop NOPOUT request

2010-11-18 Thread Eddie Wai
On Wed, 2010-11-17 at 19:40 -0800, Mike Christie wrote: > On 11/10/2010 05:04 PM, Eddie Wai wrote: > > In the case the chip is undergoing different invasive operation > > which requires a chip reset, all NOPOUT request during this period > > For these invasive operations that reset the chip, do w

Re: [PATCH 12/16] BNX2I: Added feature to silently drop NOPOUT request

2010-11-17 Thread Mike Christie
On 11/10/2010 05:04 PM, Eddie Wai wrote: In the case the chip is undergoing different invasive operation which requires a chip reset, all NOPOUT request during this period For these invasive operations that reset the chip, do we always end up having to relogin the connection/session or once th

[PATCH 12/16] BNX2I: Added feature to silently drop NOPOUT request

2010-11-10 Thread Eddie Wai
In the case the chip is undergoing different invasive operation which requires a chip reset, all NOPOUT request during this period must be silently dropped from queuing to the hardware. This patch will respond to libiscsi immediately with sent success. Since the request was not actually sent, the