Re: [PATCH 4/4] bnx2i: Add bnx2i iSCSI driver.

2009-05-06 Thread Mike Christie
> + > +/** > + * bnx2i_nl_mesg_recv - > + * @buf: pointer to buffer containing vendor specific message > + * @buf: buffer length > + * > + */ > +static int bnx2i_nl_mesg_recv(struct Scsi_Host *shost, uint16_t priv_op, > + int status, char *buf, int buflen) > +{ >

RE: [PATCH 4/4] bnx2i: Add bnx2i iSCSI driver.

2009-05-06 Thread Karen Xie
...@vger.kernel.org; Karen Xie; Jayamohan Kalickal Subject: Re: [PATCH 4/4] bnx2i: Add bnx2i iSCSI driver. > + > +/** > + * bnx2i_nl_mesg_recv - > + * @buf: pointer to buffer containing vendor specific message > + * @buf: buffer length > + * > + */ > +static int b

Re: [PATCH 4/4] bnx2i: Add bnx2i iSCSI driver.

2009-05-07 Thread Michael Chan
On Wed, 2009-05-06 at 09:48 -0700, Mike Christie wrote: > > + > > +/** > > + * bnx2i_nl_mesg_recv - > > + * @buf: pointer to buffer containing vendor specific message > > + * @buf: buffer length > > + * > > + */ > > +static int bnx2i_nl_mesg_recv(struct Scsi_Host *shost, uint16_t priv_op, > >

Re: [PATCH 4/4] bnx2i: Add bnx2i iSCSI driver.

2009-05-07 Thread Mike Christie
Michael Chan wrote: > On Wed, 2009-05-06 at 09:48 -0700, Mike Christie wrote: >>> + >>> +/** >>> + * bnx2i_nl_mesg_recv - >>> + * @buf: pointer to buffer containing vendor specific message >>> + * @buf: buffer length >>> + * >>> + */ >>> +static int bnx2i_nl_mesg_recv(struct Scsi_Host *shost,

Re: [PATCH 4/4] bnx2i: Add bnx2i iSCSI driver.

2009-05-18 Thread Michael Chan
On Thu, 2009-05-07 at 14:01 -0700, Mike Christie wrote: > Michael Chan wrote: > > On Wed, 2009-05-06 at 09:48 -0700, Mike Christie wrote: > >> I think cxgb3i is one day going to want to support the same features > >> bnx2i does. If that is right, then should we just make the NX2_UIO > >> events

Re: [PATCH 4/4] bnx2i: Add bnx2i iSCSI driver.

2009-05-19 Thread Mike Christie
Michael Chan wrote: > On Thu, 2009-05-07 at 14:01 -0700, Mike Christie wrote: >> Michael Chan wrote: >>> On Wed, 2009-05-06 at 09:48 -0700, Mike Christie wrote: I think cxgb3i is one day going to want to support the same features bnx2i does. If that is right, then should we just make th

Re: [PATCH 4/4] bnx2i: Add bnx2i iSCSI driver.

2009-05-19 Thread Michael Chan
On Tue, 2009-05-19 at 07:22 -0700, Mike Christie wrote: > Michael Chan wrote: > > > > Here are the more generic NETLINK_ISCSI messages and the iscsi transport > > code to support them, please review. > > > > diff --git a/drivers/scsi/scsi_transport_iscsi.c > > b/drivers/scsi/scsi_transport_isc

Re: [PATCH 4/4] bnx2i: Add bnx2i iSCSI driver.

2009-05-19 Thread Mike Christie
Michael Chan wrote: > > On Tue, 2009-05-19 at 07:22 -0700, Mike Christie wrote: >> Michael Chan wrote: >>> Here are the more generic NETLINK_ISCSI messages and the iscsi transport >>> code to support them, please review. >>> >>> diff --git a/drivers/scsi/scsi_transport_iscsi.c >>> b/drivers/scsi

Re: [PATCH 4/4] bnx2i: Add bnx2i iSCSI driver.

2009-05-20 Thread Michael Chan
On Tue, 2009-05-19 at 14:58 -0700, Mike Christie wrote: > If you have process context just use GFP_NOIO. We can change it later > when/if a driver needs it. I think we like to avoid GFP_ATOMIC if we > can. Or just add a gfp_t argument to the function so the caller can > do > what is right for

Re: [PATCH 4/4] bnx2i: Add bnx2i iSCSI driver.

2009-05-20 Thread Mike Christie
Michael Chan wrote: > diff --git a/include/scsi/iscsi_if.h b/include/scsi/iscsi_if.h > index 2c1a4af..0990dbb 100644 > --- a/include/scsi/iscsi_if.h > +++ b/include/scsi/iscsi_if.h > @@ -23,6 +23,9 @@ > > + */ > +struct iscsi_path { > + uint64_thandle; > + uint8_t mac_ad

Re: [PATCH 4/4] bnx2i: Add bnx2i iSCSI driver.

2009-05-20 Thread Michael Chan
On Wed, 2009-05-20 at 12:57 -0700, Mike Christie wrote: > Michael Chan wrote: > > diff --git a/include/scsi/iscsi_if.h b/include/scsi/iscsi_if.h > > index 2c1a4af..0990dbb 100644 > > --- a/include/scsi/iscsi_if.h > > +++ b/include/scsi/iscsi_if.h > > @@ -23,6 +23,9 @@ > > > > > + */ > > +struc

Re: [PATCH 4/4] bnx2i: Add bnx2i iSCSI driver.

2009-05-20 Thread Mike Christie
Michael Chan wrote: > > On Wed, 2009-05-20 at 12:57 -0700, Mike Christie wrote: >> Michael Chan wrote: >>> diff --git a/include/scsi/iscsi_if.h b/include/scsi/iscsi_if.h >>> index 2c1a4af..0990dbb 100644 >>> --- a/include/scsi/iscsi_if.h >>> +++ b/include/scsi/iscsi_if.h >>> @@ -23,6 +23,9 @@ >>>

Re: [PATCH 4/4] bnx2i: Add bnx2i iSCSI driver.

2009-05-26 Thread Michael Chan
On Tue, 2009-05-26 at 09:37 -0700, Grant Grundler wrote: > On Sat, May 23, 2009 at 2:11 PM, Michael Chan wrote: > > New iSCSI driver for Broadcom BNX2 devices. > ... > > +/* > > + * iSCSI Async CQE > > + */ > > +struct bnx2i_async_msg { > ... > > +#if defined(__BIG_ENDIAN) > > + u8 async_e