[BUG]: Null pointer exception from parallel calls to iscsi_stop_conn

2024-07-16 Thread ajhu...@gmail.com
Hi. I reviewed a kdump generated by a NULL pointer exception during termination of an iSCSI session. In this instance, the termination of the session was due to a 'Target-Not-Found' error from target during login. The system is running SLES15 SP4 ( v5.14.21 ) crash> bt PID: 61755 TASK:

[PATCH] driver core: have match() callback in struct bus_type take a const *

2024-07-01 Thread Greg Kroah-Hartman
In the match() callback, the struct device_driver * should not be changed, so change the function callback to be a const *. This is one step of many towards making the driver core safe to have struct device_driver in read-only memory. Because the match() callback is in all busses, all busses are

[bug report] [SCSI] iscsi_transport: Add support to display CHAP list and delete CHAP entry

2024-06-18 Thread Dan Carpenter
Hi SCSI and netlink developers, Commit 6260a5d22122 ("[SCSI] iscsi_transport: Add support to display CHAP list and delete CHAP entry") from Feb 27, 2012 (linux-next), leads to the following Smatch static checker warning: drivers/scsi/scsi_transport_iscsi.c:3340 iscsi_get_chap()

Re: [PATCH v2 2/2] libiscsi: disallow binding an already-bound connection

2024-05-24 Thread 'Mike Christie' via open-iscsi
On 5/23/24 5:21 PM, Khazhismel Kumykov wrote: > This fixes issue where misbehaving userspace initiator could bind the > same connection multiple times, which would leak the old connection > socket without cleaning it up. > > For iscsi_tcp, it calls iscsi_suspend_tx directly in stop_conn. Update >

Re: [PATCH] scsi:iscsi: Remove unused list 'connlist_err'

2024-05-06 Thread 'Martin K. Petersen' via open-iscsi
> I think the last use of this list was removed by > commit 23d6fefbb3f6 ("scsi: iscsi: Fix in-kernel conn failure > handling"). > > Build tested only. Applied to 6.10/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering -- You received this message because you are

Re: [PATCH] scsi:iscsi: Remove unused list 'connlist_err'

2024-05-06 Thread 'Mike Christie' via open-iscsi
On 5/3/24 6:23 PM, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > I think the last use of this list was removed by > commit 23d6fefbb3f6 ("scsi: iscsi: Fix in-kernel conn failure > handling"). > > Build tested only. > > Signed-off-by: Dr. David Alan Gilbert > --- >

Re: [PATCH 13/23] sbp2: switch to using ->device_configure

2024-03-26 Thread Christoph Hellwig
On Tue, Mar 26, 2024 at 06:30:45PM +0900, Takashi Sakamoto wrote: > > drivers/firewire/sbp2.c | 7 --- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > I'm not good at any kind of storage protocol, thus execute me not to > review it. My concern is which subsystem provides the change

Re: [PATCH 10/23] scsi: add a device_configure method to the host template

2024-03-26 Thread Christoph Hellwig
On Mon, Mar 25, 2024 at 04:38:43PM +0900, Damien Le Moal wrote: > > + if (hostt->device_configure) > > + ret = hostt->device_configure(sdev, ); > > + else if (hostt->slave_configure) > > + ret = hostt->slave_configure(sdev); > > + > > + ret2 =

Re: [PATCH 10/23] scsi: add a device_configure method to the host template

2024-03-26 Thread Christoph Hellwig
On Mon, Mar 25, 2024 at 01:35:08PM -0700, Bart Van Assche wrote: > There are two methods with names that are politically charged: > slave_configure() and slave_alloc(). Shouldn't both be renamed? Probably. This series howerver doesn't actually renames anything, it just adds a new method that

Re: [PATCH 06/23] scsi: add a no_highmem flag to struct Scsi_Host

2024-03-26 Thread Christoph Hellwig
On Mon, Mar 25, 2024 at 04:26:55PM +0900, Damien Le Moal wrote: > On 3/25/24 08:54, Christoph Hellwig wrote: > > While we really should be killing the block layer bounce buffering ASAP, > > I even more urgently need to stop the drivers to fiddle with the limits > > from ->slave_configure. Add a

Re: [PATCH 08/23] ufs-exynos: move setting the the dma alignment to the init method

2024-03-25 Thread Bart Van Assche
On 3/24/24 16:54, Christoph Hellwig wrote: Use the SCSI host's dma_alignment field and set it in ->init and remove the now unused config_scsi_dev method. Reviewed-by: Bart Van Assche -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To

Re: [PATCH 07/23] scsi: add a dma_alignment field to the host and host template

2024-03-25 Thread Bart Van Assche
On 3/24/24 16:54, Christoph Hellwig wrote: Get drivers out of the business of having to call the block layer dma alignment limits helpers themselves. Reviewed-by: Bart Van Assche -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe

Re: [PATCH 09/23] scsi: use the atomic queue limits API in scsi_add_lun

2024-03-25 Thread Bart Van Assche
On 3/24/24 16:54, Christoph Hellwig wrote: Switch scsi_add_lun to use the atomic queue limits API to update the max_hw_sectors for devices with quirks. Reviewed-by: Bart Van Assche -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To

Re: [PATCH 23/23] block: remove now unused queue limits helpers

2024-03-25 Thread Bart Van Assche
On 3/24/24 16:54, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig Reviewed-by: Bart Van Assche -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: [PATCH 10/23] scsi: add a device_configure method to the host template

2024-03-25 Thread Bart Van Assche
On 3/24/24 16:54, Christoph Hellwig wrote: This is a version of ->slave_configure that also takes a queue_limits structure that the caller applies, and thus allows drivers to reconfigure the queue using the atomic queue limits API. In the long run it should also replace ->slave_configure

Re: [PATCH 02/23] bsg: pass queue_limits to bsg_setup_queue

2024-03-25 Thread Bart Van Assche
On 3/24/24 16:54, Christoph Hellwig wrote: This allows bsg_setup_queue to pass them to blk_mq_alloc_queue and thus set up the limits at queue allocation time. Reviewed-by: Bart Van Assche -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To

Re: [PATCH 04/23] scsi: initialize scsi midlayer limits before allocating the queue

2024-03-25 Thread Bart Van Assche
On 3/24/24 16:54, Christoph Hellwig wrote: Turn __scsi_init_queue into scsi_init_limits which initializes queue_limits structure that can be passed to blk_mq_alloc_queue. Reviewed-by: Bart Van Assche -- You received this message because you are subscribed to the Google Groups "open-iscsi"

Re: [PATCH 23/23] block: remove now unused queue limits helpers

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig Looks OK to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this

Re: [PATCH 22/23] uas: switch to using ->device_configure to configure queue limits

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > Switch to the ->device_configure method instead of ->slave_alloc > and update the block limits on the passed in queue_limits instead > of using the per-limit accessors. > > Note that uas was the only driver setting these size limits from >

Re: [PATCH 21/23] mpi3mr: switch to using ->device_configure

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > Switch to the ->device_configure method instead of ->slave_configure > and update the block limits on the passed in queue_limits instead > of using the per-limit accessors. > > Note that mpi3mr also updates the limits from an event handler that >

Re: [PATCH 20/23] libata: switch to using ->device_configure

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > Switch to the ->device_configure method instead of ->slave_configure > and update the block limits on the passed in queue_limits instead > of using the per-limit accessors. > > Signed-off-by: Christoph Hellwig Looks OK to me. For the ata bits:

Re: [PATCH 19/23] pata_macio: switch to using ->device_configure

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > Switch to the ->device_configure method instead of ->slave_configure > and update the block limits on the passed in queue_limits instead > of using the per-limit accessors. > > Signed-off-by: Christoph Hellwig Looks OK to me. Acked-by: Damien Le

Re: [PATCH 18/23] sata_nv: switch to using ->device_configure

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > Switch to the ->device_configure method instead of ->slave_configure > and update the block limits on the passed in queue_limits instead > of using the per-limit accessors. > > Signed-off-by: Christoph Hellwig Looks OK to me. Acked-by: Damien Le

Re: [PATCH 17/23] usb-storage: switch to using ->device_configure

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > Switch to the ->device_configure method instead of ->slave_configure > and update the block limits on the passed in queue_limits instead > of using the per-limit accessors. > > Also use the proper atomic queue limit update helpers and freeze the >

Re: [PATCH 16/23] pmcraid: switch to using ->device_configure

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > Switch to the ->device_configure method instead of ->slave_configure > and update the block limits on the passed in queue_limits instead > of using the per-limit accessors. > > Signed-off-by: Christoph Hellwig Looks OK to me. Reviewed-by: Damien Le

Re: [PATCH 15/23] ipr: switch to using ->device_configure

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > Switch to the ->device_configure method instead of ->slave_configure > and update the block limits on the passed in queue_limits instead > of using the per-limit accessors. > > Signed-off-by: Christoph Hellwig Looks OK to me. Reviewed-by: Damien Le

Re: [PATCH 14/23] hptiop: switch to using ->device_configure

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > Switch to the ->device_configure method instead of ->slave_configure > and update the block limits on the passed in queue_limits instead > of using the per-limit accessors. > > Signed-off-by: Christoph Hellwig Looks OK to me. Reviewed-by: Damien Le

Re: [PATCH 13/23] sbp2: switch to using ->device_configure

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > Switch to the ->device_configure method instead of ->slave_configure > and update the block limits on the passed in queue_limits instead > of using the per-limit accessors. > > Signed-off-by: Christoph Hellwig Looks OK to me. Reviewed-by: Damien Le

Re: [PATCH 12/23] mpt3sas: switch to using ->device_configure

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > Switch to the ->device_configure method instead of ->slave_configure > and update the block limits on the passed in queue_limits instead > of using the per-limit accessors. > > Signed-off-by: Christoph Hellwig Looks OK to me. Reviewed-by: Damien Le

Re: [PATCH 11/23] megaraid_sas: switch to using ->device_configure

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > Switch to the ->device_configure method instead of ->slave_configure > and update the block limits on the passed in queue_limits instead > of using the per-limit accessors. > > Signed-off-by: Christoph Hellwig Looks OK to me. Reviewed-by: Damien Le

Re: [PATCH 10/23] scsi: add a device_configure method to the host template

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > This is a version of ->slave_configure that also takes a queue_limits > structure that the caller applies, and thus allows drivers to reconfigure > the queue using the atomic queue limits API. > > In the long run it should also replace

Re: [PATCH 09/23] scsi: use the atomic queue limits API in scsi_add_lun

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > Switch scsi_add_lun to use the atomic queue limits API to update the > max_hw_sectors for devices with quirks. > > Signed-off-by: Christoph Hellwig Looks OK to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research -- You

Re: [PATCH 08/23] ufs-exynos: move setting the the dma alignment to the init method

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > Use the SCSI host's dma_alignment field and set it in ->init and remove > the now unused config_scsi_dev method. > > Signed-off-by: Christoph Hellwig Looks OK to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research -- You

Re: [PATCH 07/23] scsi: add a dma_alignment field to the host and host template

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > Get drivers out of the business of having to call the block layer > dma alignment limits helpers themselves. > > Signed-off-by: Christoph Hellwig Looks OK to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research -- You

Re: [PATCH 06/23] scsi: add a no_highmem flag to struct Scsi_Host

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > While we really should be killing the block layer bounce buffering ASAP, > I even more urgently need to stop the drivers to fiddle with the limits > from ->slave_configure. Add a no_highmem flag to the Scsi_Host to > centralize this setting and switch

Re: [PATCH 05/23] scsi_transport_fc: add a max_bsg_segments field to struct fc_function_template

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > ibmvfc only supports a single segment for BSG FC passthrough. Instead of > having it set a queue limits after creating the BSD queues, add a field so > that the FC transport can set it before allocating the queue. > > Signed-off-by: Christoph Hellwig

Re: [PATCH 04/23] scsi: initialize scsi midlayer limits before allocating the queue

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > Turn __scsi_init_queue into scsi_init_limits which initializes > queue_limits structure that can be passed to blk_mq_alloc_queue. > > Signed-off-by: Christoph Hellwig Looks OK to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital

Re: [PATCH 03/23] mpi3mr: pass queue_limits to bsg_setup_queue

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > Pass the limits to bsg_setup_queue instead of setting them up on the live > queue. > > Signed-off-by: Christoph Hellwig Looks OK to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research -- You received this message because

Re: [PATCH 02/23] bsg: pass queue_limits to bsg_setup_queue

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > This allows bsg_setup_queue to pass them to blk_mq_alloc_queue and thus > set up the limits at queue allocation time. > > Signed-off-by: Christoph Hellwig Looks OK to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research --

Re: [PATCH 01/23] block: don't reject too large max_user_setors in blk_validate_limits

2024-03-25 Thread Damien Le Moal
On 3/25/24 08:54, Christoph Hellwig wrote: > We already cap down the actual max_sectors to the max of the hardware > and user limit, so don't reject the configuration. > > Signed-off-by: Christoph Hellwig Looks OK to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research

[PATCH 23/23] block: remove now unused queue limits helpers

2024-03-24 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- block/blk-settings.c | 245 - drivers/s390/block/dasd_eckd.c | 6 +- include/linux/blkdev.h | 13 -- include/linux/mmc/host.h | 4 +- 4 files changed, 5 insertions(+), 263 deletions(-) diff --git

[PATCH 22/23] uas: switch to using ->device_configure to configure queue limits

2024-03-24 Thread Christoph Hellwig
Switch to the ->device_configure method instead of ->slave_alloc and update the block limits on the passed in queue_limits instead of using the per-limit accessors. Note that uas was the only driver setting these size limits from ->slave_alloc and not ->slave_configure and this makes it match

[PATCH 21/23] mpi3mr: switch to using ->device_configure

2024-03-24 Thread Christoph Hellwig
Switch to the ->device_configure method instead of ->slave_configure and update the block limits on the passed in queue_limits instead of using the per-limit accessors. Note that mpi3mr also updates the limits from an event handler that iterates all SCSI devices. This is also updated to use the

[PATCH 20/23] libata: switch to using ->device_configure

2024-03-24 Thread Christoph Hellwig
Switch to the ->device_configure method instead of ->slave_configure and update the block limits on the passed in queue_limits instead of using the per-limit accessors. Signed-off-by: Christoph Hellwig --- drivers/ata/ahci.h | 2 +- drivers/ata/libata-sata.c |

[PATCH 19/23] pata_macio: switch to using ->device_configure

2024-03-24 Thread Christoph Hellwig
Switch to the ->device_configure method instead of ->slave_configure and update the block limits on the passed in queue_limits instead of using the per-limit accessors. Signed-off-by: Christoph Hellwig --- drivers/ata/pata_macio.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-)

[PATCH 18/23] sata_nv: switch to using ->device_configure

2024-03-24 Thread Christoph Hellwig
Switch to the ->device_configure method instead of ->slave_configure and update the block limits on the passed in queue_limits instead of using the per-limit accessors. Signed-off-by: Christoph Hellwig --- drivers/ata/sata_nv.c | 20 1 file changed, 12 insertions(+), 8

[PATCH 17/23] usb-storage: switch to using ->device_configure

2024-03-24 Thread Christoph Hellwig
Switch to the ->device_configure method instead of ->slave_configure and update the block limits on the passed in queue_limits instead of using the per-limit accessors. Also use the proper atomic queue limit update helpers and freeze the queue when updating max_hw_sectors from sysfs.

[PATCH 16/23] pmcraid: switch to using ->device_configure

2024-03-24 Thread Christoph Hellwig
Switch to the ->device_configure method instead of ->slave_configure and update the block limits on the passed in queue_limits instead of using the per-limit accessors. Signed-off-by: Christoph Hellwig --- drivers/scsi/pmcraid.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-)

[PATCH 15/23] ipr: switch to using ->device_configure

2024-03-24 Thread Christoph Hellwig
Switch to the ->device_configure method instead of ->slave_configure and update the block limits on the passed in queue_limits instead of using the per-limit accessors. Signed-off-by: Christoph Hellwig --- drivers/scsi/ipr.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff

[PATCH 14/23] hptiop: switch to using ->device_configure

2024-03-24 Thread Christoph Hellwig
Switch to the ->device_configure method instead of ->slave_configure and update the block limits on the passed in queue_limits instead of using the per-limit accessors. Signed-off-by: Christoph Hellwig --- drivers/scsi/hptiop.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH 13/23] sbp2: switch to using ->device_configure

2024-03-24 Thread Christoph Hellwig
Switch to the ->device_configure method instead of ->slave_configure and update the block limits on the passed in queue_limits instead of using the per-limit accessors. Signed-off-by: Christoph Hellwig --- drivers/firewire/sbp2.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

[PATCH 12/23] mpt3sas: switch to using ->device_configure

2024-03-24 Thread Christoph Hellwig
Switch to the ->device_configure method instead of ->slave_configure and update the block limits on the passed in queue_limits instead of using the per-limit accessors. Signed-off-by: Christoph Hellwig --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 18 -- 1 file changed, 8

[PATCH 11/23] megaraid_sas: switch to using ->device_configure

2024-03-24 Thread Christoph Hellwig
Switch to the ->device_configure method instead of ->slave_configure and update the block limits on the passed in queue_limits instead of using the per-limit accessors. Signed-off-by: Christoph Hellwig --- drivers/scsi/megaraid/megaraid_sas.h| 2 +-

[PATCH 10/23] scsi: add a device_configure method to the host template

2024-03-24 Thread Christoph Hellwig
This is a version of ->slave_configure that also takes a queue_limits structure that the caller applies, and thus allows drivers to reconfigure the queue using the atomic queue limits API. In the long run it should also replace ->slave_configure entirely as there is no need to have two different

[PATCH 09/23] scsi: use the atomic queue limits API in scsi_add_lun

2024-03-24 Thread Christoph Hellwig
Switch scsi_add_lun to use the atomic queue limits API to update the max_hw_sectors for devices with quirks. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_scan.c | 49 1 file changed, 24 insertions(+), 25 deletions(-) diff --git

[PATCH 08/23] ufs-exynos: move setting the the dma alignment to the init method

2024-03-24 Thread Christoph Hellwig
Use the SCSI host's dma_alignment field and set it in ->init and remove the now unused config_scsi_dev method. Signed-off-by: Christoph Hellwig --- drivers/ufs/core/ufshcd.c | 3 --- drivers/ufs/host/ufs-exynos.c | 8 ++-- include/ufs/ufshcd.h | 1 - 3 files changed, 2

[PATCH 07/23] scsi: add a dma_alignment field to the host and host template

2024-03-24 Thread Christoph Hellwig
Get drivers out of the business of having to call the block layer dma alignment limits helpers themselves. Signed-off-by: Christoph Hellwig --- drivers/firewire/sbp2.c | 6 -- drivers/message/fusion/mptfc.c| 1 + drivers/message/fusion/mptsas.c | 1 +

[PATCH 06/23] scsi: add a no_highmem flag to struct Scsi_Host

2024-03-24 Thread Christoph Hellwig
While we really should be killing the block layer bounce buffering ASAP, I even more urgently need to stop the drivers to fiddle with the limits from ->slave_configure. Add a no_highmem flag to the Scsi_Host to centralize this setting and switch the remaining four drivers that use block layer

[PATCH 05/23] scsi_transport_fc: add a max_bsg_segments field to struct fc_function_template

2024-03-24 Thread Christoph Hellwig
ibmvfc only supports a single segment for BSG FC passthrough. Instead of having it set a queue limits after creating the BSD queues, add a field so that the FC transport can set it before allocating the queue. Signed-off-by: Christoph Hellwig --- drivers/scsi/ibmvscsi/ibmvfc.c | 5 +

[PATCH 04/23] scsi: initialize scsi midlayer limits before allocating the queue

2024-03-24 Thread Christoph Hellwig
Turn __scsi_init_queue into scsi_init_limits which initializes queue_limits structure that can be passed to blk_mq_alloc_queue. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_lib.c | 32 ++--- drivers/scsi/scsi_scan.c| 5 +++--

[PATCH 02/23] bsg: pass queue_limits to bsg_setup_queue

2024-03-24 Thread Christoph Hellwig
This allows bsg_setup_queue to pass them to blk_mq_alloc_queue and thus set up the limits at queue allocation time. Signed-off-by: Christoph Hellwig --- block/bsg-lib.c | 6 -- drivers/scsi/mpi3mr/mpi3mr_app.c| 2 +- drivers/scsi/scsi_transport_fc.c| 6 +++---

convert SCSI to atomic queue limits, part 1

2024-03-24 Thread Christoph Hellwig
Hi all, this series converts the SCSI midlayer and LLDDs to use atomic queue limits API. It is pretty straight forward, except for the mpt3mr driver which does really weird and probably already broken things by setting limits from unlocked device iteration callsbacks. The first patch is

[PATCH 03/23] mpi3mr: pass queue_limits to bsg_setup_queue

2024-03-24 Thread Christoph Hellwig
Pass the limits to bsg_setup_queue instead of setting them up on the live queue. Signed-off-by: Christoph Hellwig --- drivers/scsi/mpi3mr/mpi3mr_app.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/mpi3mr/mpi3mr_app.c

[PATCH 01/23] block: don't reject too large max_user_setors in blk_validate_limits

2024-03-24 Thread Christoph Hellwig
We already cap down the actual max_sectors to the max of the hardware and user limit, so don't reject the configuration. Signed-off-by: Christoph Hellwig --- block/blk-settings.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/blk-settings.c b/block/blk-settings.c

Re: [PATCH 2/2] iscsi_tcp: disallow binding the same connection twice

2024-03-19 Thread Mike Christie
On 3/18/24 2:49 PM, Khazhismel Kumykov wrote: > iscsi_sw_tcp_conn_bind does not check or cleanup previously bound > sockets, nor should we allow binding the same connection twice. > This looks like a problem for all the iscsi drivers. I think you could: 1. Add a check for ISCSI_CONN_FLAG_BOUND

Re: [PATCH 1/2] iscsi_tcp: do not bind sockets that already have extra callbacks

2024-03-19 Thread Mike Christie
On 3/18/24 2:49 PM, Khazhismel Kumykov wrote: > This attempts to avoid a situation where a misbehaving iscsi daemon > passes a socket for a different iSCSI connection to BIND_CONN - which > would result in infinite recursion and stack overflow. This will > also prevent passing *other* sockets

Re: [PATCH 0/3] drivers: scsi: struct bus_type cleanup

2024-02-12 Thread Martin K. Petersen
On Sat, 03 Feb 2024 15:38:59 -0300, Ricardo B. Marliere wrote: > This series is part of an effort to cleanup the users of the driver > core, as can be seen in many recent patches authored by Greg across the > tree (e.g. [1]). Specifically, this series is part of the task of > splitting one of his

Re: [PATCH 0/3] drivers: scsi: struct bus_type cleanup

2024-02-05 Thread Martin K. Petersen
Ricardo, > This series is part of an effort to cleanup the users of the driver > core, as can be seen in many recent patches authored by Greg across > the tree (e.g. [1]). Specifically, this series is part of the task of > splitting one of his TODOs [2]. Applied to 6.9/scsi-staging, thanks!

Re: [PATCH 0/3] drivers: scsi: struct bus_type cleanup

2024-02-03 Thread Greg Kroah-Hartman
On Sat, Feb 03, 2024 at 03:38:59PM -0300, Ricardo B. Marliere wrote: > This series is part of an effort to cleanup the users of the driver > core, as can be seen in many recent patches authored by Greg across the > tree (e.g. [1]). Specifically, this series is part of the task of > splitting one

Re: [PATCH 2/3] scsi: iscsi: make iscsi_flashnode_bus const

2024-02-03 Thread 'Lee Duncan' via open-iscsi
On Sat, Feb 3, 2024 at 10:38 AM Ricardo B. Marliere wrote: > > Now that the driver core can properly handle constant struct bus_type, > move the iscsi_flashnode_bus variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. > > Cc: Greg

Re: [PATCH] scsi: iscsi: fix iscsi ida memory leak

2024-01-29 Thread Mike Christie
On 1/29/24 3:04 AM, Guixin Liu wrote: > The iscsi_sess_ida should be destroy when the iscsi module exit. > > Signed-off-by: Guixin Liu > --- > drivers/scsi/scsi_transport_iscsi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/scsi_transport_iscsi.c >

Re: Performance drop due to alloc_workqueue() misuse and recent change

2023-12-19 Thread Tejun Heo
Hello, again. On Mon, Dec 04, 2023 at 04:03:47PM +, Naohiro Aota wrote: ... > In summary, we misuse max_active, considering it is a global limit. And, > the recent commit introduced a huge performance drop in some cases. We > need to review alloc_workqueue() usage to check if its max_active

Advanced Desktop Locker Pro 8.0.0 FINAL Serial Serial Key Keygen

2023-12-09 Thread Joane Lazenson
Advanced Desktop Locker Pro 8.0.0 FINAL Serial Serial Key Keygen: How to Download and Install If you want to lock your PC and protect your privacy with a powerful and easy-to-use software, you might be interested in *Advanced Desktop Locker Pro 8.0.0 FINAL Serial Serial Key Keygen*. This is a

Aion Multi Tools 3.9 Byl

2023-12-09 Thread Joane Lazenson
Aion Multi Tools 3.9 Byl: A Useful Software for Aion Players If you are a fan of Aion, a massively multiplayer online role-playing game (MMORPG) released by NCSOFT, you might want to check out Aion Multi Tools 3.9 Byl, a software that can help you create and edit Aion files with various

How To Crack Password For Zip Folder

2023-12-07 Thread Joane Lazenson
ZIP is an archive file format that supports lossless data compression. By lossless compression, we mean that the compression algorithm allows the original data to be perfectly reconstructed from the compressed data. So, a ZIP file is a single file containing one or more compressed files,

Easy Cut Studio Keygen Crackk

2023-12-07 Thread Joane Lazenson
The complete solution for designing, printing, cutting and print + cut is provided by the easy cut pro keygen. You can use your vinyl cutter or cutting plotter to cut any TrueType font, OpenType font, image, SVG, PDF file, as well as your own unique creations. A built-in shape library

The Wagon Is Back: The Volvo V90 Cross Country Drives Itself Through The Desert

2023-12-07 Thread Joane Lazenson
Besides the raised ground clearance, the S60 Cross Country distinguishes itself from standard S60 sedans thanks to the unique cross country honeycomb grille, glossy black green house and mirror caps, as well as the Cross Country emblem embossed in the rear skid plate. The wagon is back: The

SPAM control measure stepped up

2023-12-07 Thread The Lee-Man
Hi All: Most have probably noticed quite a bit of SPAM recently. This was because anyone could join this group, and then post. I have changed the group settings so that joining must be approved. And I have kicked out the latest SPAMer, and will continue to do so. Sadly, google groups makes it

Ina Garten Chicken Cordon Bleu Recipel

2023-12-07 Thread Vickie Rud
We didn't have our wedding at the Irish pub because, well, it was shut down temporarily because of health code violations. This wedding chicken cordon bleu was the guests' favorite, and it l our favorite too. Ina Garten Chicken Cordon Bleu Recipel *DOWNLOAD*

American Daylight Movie Telugu Free Download

2023-12-06 Thread Vickie Rud
In the spring of 2015,* sixteen (16) QR code trail markers* were installed at significant locations along the walk that provide information on the gilded age mansions as well as geographic and geological features. The signs are intended to provide interpretive information on the walk while

Ya Lo Hiciste Sin Amar Dvdrip Audio Latino

2023-12-06 Thread Vickie Rud
Que me cuide de otra que se parezca a ti\nNo quiero caer como hice por ti\nOjalá te enamore', te hagan lo mismo que me hiciste a mí\nTú me enseñaste a no amar a cualquiera\nY también como no quiero que me quieran\n\nya lo hiciste sin amar dvdrip audio latino\nDownload

Re: Performance drop due to alloc_workqueue() misuse and recent change

2023-12-04 Thread Tejun Heo
Hello, On Mon, Dec 04, 2023 at 04:03:47PM +, Naohiro Aota wrote: > Recently, commit 636b927eba5b ("workqueue: Make unbound workqueues to use > per-cpu pool_workqueues") changed WQ_UNBOUND workqueue's behavior. It > changed the meaning of alloc_workqueue()'s max_active from an upper limit >

Performance drop due to alloc_workqueue() misuse and recent change

2023-12-04 Thread Naohiro Aota
Recently, commit 636b927eba5b ("workqueue: Make unbound workqueues to use per-cpu pool_workqueues") changed WQ_UNBOUND workqueue's behavior. It changed the meaning of alloc_workqueue()'s max_active from an upper limit imposed per NUMA node to a limit per CPU. As a result, massive number of workers

Sinhala Wal Katha 2014 Pdf 26l

2023-12-02 Thread Vickie Rud
Sinhala Wal Katha 2014 Pdf 26l *Download Zip* https://t.co/XPDfmtGPrs eebf2c3492 -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Fusion 360 Pro Crack Serial Key Download For Mac Win

2023-12-02 Thread Vickie Rud
Fusion 360 Pro Crack Serial Key Download For Mac Win *Download File* https://t.co/T5pK7tc3bk eebf2c3492 -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Cbr 929 Rr Fireblade Ficha Tecnica

2023-12-02 Thread Vickie Rud
Cbr 929 Rr Fireblade Ficha Tecnica *DOWNLOAD* https://t.co/KafRdLy9x3 eebf2c3492 -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Brutal Doom V16 Download

2023-12-01 Thread Vickie Rud
However, thankfully enough you (we) have been given some brand-new weapons (hand grenades, for example) and fatality (execution) moves, all of which will come in handy against the hordes of hell, Sergeant Mark IV has also added tons of new features and improvements to BD v20 (such as better

Flame 2005 Scaricare Keygen 32 Bits IT

2023-11-29 Thread osman altın
Flame 2005 scaricare keygen 32 bits IT Download Zip https://t.co/RizrSD33WE eebf2c3492 -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Dragon Ball Z BluRay 1080p DHD

2023-11-21 Thread Tavon Biggerstaff
Dragon Ball Z BluRay 1080p DHD: The Ultimate Collection for FansDragon Ball Z is one of the most popular and influential anime series of all time. It follows the adventures of Goku and his friends as they fight against various enemies who threaten the peace of the universe. The series is known

Updatges to iscsiuio

2023-10-17 Thread The Lee-Man
Hi All: A co-worker and I have recently pushed some updates to iscsiuio to make it more reliable. The first wave has been merged, and I have just submitted a pull request on github for the 2nd (and last) group of changes. If you care to review them, please check out github pull request 428

Re: [PATCH v5 10/10] scsi: scsi_debug: Add param to control sdev's allow_restart

2023-10-09 Thread 'Wenchao Hao' via open-iscsi
On 2023/10/9 7:17, Douglas Gilbert wrote: On 2023-09-22 05:29, Wenchao Hao wrote: Add new module param "allow_restart" to control if setup scsi_device's allow_restart flag. This is used to test scsi command finished with sense_key 0x6, asc 0x4 and ascq 0x2 Signed-off-by: Wenchao Hao Hi,

Re: [PATCH v5 10/10] scsi: scsi_debug: Add param to control sdev's allow_restart

2023-10-08 Thread Douglas Gilbert
On 2023-09-22 05:29, Wenchao Hao wrote: Add new module param "allow_restart" to control if setup scsi_device's allow_restart flag. This is used to test scsi command finished with sense_key 0x6, asc 0x4 and ascq 0x2 Signed-off-by: Wenchao Hao Hi, Looked at this and verified that the

Re: [PATCH v5 09/10] scsi: scsi_debug: Add debugfs interface to fail target reset

2023-10-08 Thread Douglas Gilbert
On 2023-09-22 05:29, Wenchao Hao wrote: The interface is found at /sys/kernel/debug/scsi_debug/target/fail_reset where identifies the target to inject errors on. It's a simple bool type interface which would make this target's reset fail if set to 'Y'. Signed-off-by: Wenchao Hao Reported-by:

Re: [PATCH v5 08/10] scsi: scsi_debug: Add new error injection reset lun failed

2023-10-07 Thread 'Wenchao Hao' via open-iscsi
On 2023/10/7 5:04, Douglas Gilbert wrote: On 2023-09-22 05:29, Wenchao Hao wrote: Add error injection type 3 to make scsi_debug_device_reset() return FAILED. Fail abort command foramt: s/foramt/format/ Examples: error=/sys/kernel/debug/scsi_debug/0:0:0:1/error echo "0 -10 0x12" >

Re: [PATCH v5 08/10] scsi: scsi_debug: Add new error injection reset lun failed

2023-10-06 Thread Douglas Gilbert
On 2023-09-22 05:29, Wenchao Hao wrote: Add error injection type 3 to make scsi_debug_device_reset() return FAILED. Fail abort command foramt: s/foramt/format/ ++--+---+ | Column | Type | Description

Re: [PATCH v5 07/10] scsi: scsi_debug: Add new error injection abort failed

2023-10-06 Thread Douglas Gilbert
On 2023-09-22 05:29, Wenchao Hao wrote: Add error injection type 3 to make scsi_debug_abort() return FAILED. Fail abort command foramt: s/foramt/format/ ++--+---+ | Column | Type | Description

Re: [PATCH v5 06/10] scsi: scsi_debug: set command's result and sense data if the error is injected

2023-10-05 Thread Dan Carpenter
Hi Wenchao, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Wenchao-Hao/scsi-scsi_debug-create-scsi_debug-directory-in-the-debugfs-filesystem/20230922-173226 base:

[PATCH 6.5 067/321] scsi: iscsi_tcp: restrict to TCP sockets

2023-10-04 Thread Greg Kroah-Hartman
6.5-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit f4f82c52a0ead5ab363d207d06f81b967d09ffb8 ] Nothing prevents iscsi_sw_tcp_conn_bind() to receive file descriptor pointing to non TCP socket (af_unix for example).

[PATCH 6.1 058/259] scsi: iscsi_tcp: restrict to TCP sockets

2023-10-04 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit f4f82c52a0ead5ab363d207d06f81b967d09ffb8 ] Nothing prevents iscsi_sw_tcp_conn_bind() to receive file descriptor pointing to non TCP socket (af_unix for example).

Re: [PATCH v5 01/10] scsi: scsi_debug: create scsi_debug directory in the debugfs filesystem

2023-09-27 Thread 'Wenchao Hao' via open-iscsi
On 2023/9/28 9:13, Douglas Gilbert wrote: On 2023-09-22 05:28, Wenchao Hao wrote: Create directory scsi_debug in the root of the debugfs filesystem. Prepare to add interface for manage error injection. Acked-by: Douglas Gilbert Signed-off-by: Wenchao Hao ---   drivers/scsi/scsi_debug.c | 6

  1   2   3   4   5   6   7   8   9   10   >