Sparqz wrote:
>
>
> On Feb 28, 8:46 pm, Mike Christie <[EMAIL PROTECTED]> wrote:
>> Sparqz wrote:
>>> Hi,
>>> There appears to be a bug in test/regression.sh
>>> It only applies when using the "-f" option:
>>>> test x$1 = x && fatal "target name parameter error"
>>>> test x$2 = x && fatal "ipnumber parameter error"
>>>> test x$3 = x && fatal "SCSI device parameter error"
>>>> if test x$1 = "x-f" -o x$1 = "x--format"; then
>>>> mkfs_run
>>>> exit
>>>> fi
>>>> target="$1"
>>>> ipnr="$2"
>>>> device=$3
>>>> device_dir="$(dirname ${device})"
>>>> device_partition=''
>>>> case "${device_dir}" in
>>> when you specify "-f" as an option it gets picked up by the 4th test
>>> above, and calls mkfs_run, but mkfs_run needs device_partition to be
>>> defined before it will work correctly, otherwise you get a nasty
>>> uninformative:
>>> web1:/iscsi/drivers/open/open-iscsi-2.0-865.15/test # ./regression.sh -
>>> f 192.168.50.5 /dev/sdb
>>> mkfs.ext3 : FAILED
>>> Or at least that's the way I see it!
>> Thanks for the bug report. I think you are right, but my scripting sucks
>> so who knows :) I am not sure why we would pass in the ip address for
>> that testing command. How is your scripting? Can you send a patch that
>> does what you want, and I can dig into the rest of it.
>
> Hi Mike,
>
> Patch uploaded. Enjoy!
Thanks.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~----------~----~----~----~------~----~------~--~---
