[Open64-devel] Fwd: code review for fix of bug 633

2010-09-10 Thread Yiran Wang
-- Forwarded message -- From: Yiran Wang Date: Fri, Sep 10, 2010 at 4:25 PM Subject: Re: [Open64-devel] code review for fix of bug 633 To: Sun Chan This chunk is where the variable ret_mtype is first defined. It looks like if the result is needed, it is set in someway, else it i

Re: [Open64-devel] code review for fix of bug 633

2010-09-10 Thread Sun Chan
Could you show larger portion of the code around it. The variable is ret_mtype, so may be it is only for return type. For a single statement, the result type usually follows that of the use. Sun On Sat, Sep 11, 2010 at 6:18 AM, Yiran Wang wrote: > The simple reason may be F8 is the largest type f

[Open64-devel] code review for fix of bug 643

2010-09-10 Thread Yiran Wang
Hi All, Could some gatekeeper please review this change? The issue is as following: For a goto to outer block, the cleanup of local objects are needed. While, for call of destructor for each of them, the call is nested in a eh-region, as the destructor itself may throw exceptions. As we can see,

Re: [Open64-devel] code review for fix of bug 633

2010-09-10 Thread Yiran Wang
The simple reason may be F8 is the largest type for sqrt. Another solution may be to set the type to the operand. But I simply want to make it consistent to other intrinsics with similar issue (they solve it in this way). Best Regards, yiran On Fri, Sep 10, 2010 at 3:14 PM, Sun Chan wrote: > w

Re: [Open64-devel] code review for fix of bug 633

2010-09-10 Thread Sun Chan
why is F8 the default, but not others? Sun On Sat, Sep 11, 2010 at 6:08 AM, Yiran Wang wrote: > Hi Sun, > Sure. > The situation is as following. > There is implementation of the intrinsic "sqrt", for a number of types, such > as F4, F8, and so on. While, the compiler want to determine the exact t

Re: [Open64-devel] code review for fix of bug 633

2010-09-10 Thread Yiran Wang
Hi Sun, Sure. The situation is as following. There is implementation of the intrinsic "sqrt", for a number of types, such as F4, F8, and so on. While, the compiler want to determine the exact type of the sqrt by context. For example, double a, b; a = sqrt(b); Then the type is F8. Usually it w

Re: [Open64-devel] code review for fix of bug 633

2010-09-10 Thread Sun Chan
please give a brief description of the bug. Or a simple test case. The portion of code change is not enough for me to tell why F8 is the right type, but not, say, F4, or V8 Sun On Sat, Sep 11, 2010 at 2:58 AM, Yiran Wang wrote: > Hi All, > Could a gatekeeper please review it? > Simply, the re

[Open64-devel] code review for fix of bug 633

2010-09-10 Thread Yiran Wang
Hi All, Could a gatekeeper please review it? Simply, the ret_mtype should be reset automatically, if it is void. This is already done for a number of other intrinsics. The bug is triggered when the combination of > and ?: operator is used, as the result type is not set by parent of the intrinsic