Re: [Open64-devel] review request for fix to bug 686 -- Problem using OMP THREADPRIVATE in FORTRAN module with openf90

2010-11-19 Thread Sun Chan
Thx! Gatekeepers are supposed to ask for origin of code from now on. Sun On Sat, Nov 20, 2010 at 8:40 AM, Gilmore, Doug wrote: > I developed the change. > > I'll say in the bug report comment associated with the attachment for the > patch if it came elsewhere, and updates to the copyright notice

Re: [Open64-devel] review request for fix to bug 686 -- Problem using OMP THREADPRIVATE in FORTRAN module with openf90

2010-11-19 Thread Gilmore, Doug
I developed the change. I'll say in the bug report comment associated with the attachment for the patch if it came elsewhere, and updates to the copyright notices will indicate the source. Also when a patch comes from elsewhere, my commit log message will identify the source. Doug > -O

Re: [Open64-devel] review request for fix to bug 686 -- Problem using OMP THREADPRIVATE in FORTRAN module with openf90

2010-11-19 Thread Sun Chan
is this code from somewhere else? Sun On Sat, Nov 20, 2010 at 3:01 AM, Jian-Xin Lai wrote: > I read the patch and it looks fine to me. > > 2010/11/18 Gilmore, Doug >> >> The bug fix is attached to the bug: >> >> https://bugs.open64.net/show_bug.cgi?id=686 >> >> Could someone review this patch wh

Re: [Open64-devel] review request for fix to bug 686 -- Problem using OMP THREADPRIVATE in FORTRAN module with openf90

2010-11-19 Thread Jian-Xin Lai
I read the patch and it looks fine to me. 2010/11/18 Gilmore, Doug > The bug fix is attached to the bug: > > https://bugs.open64.net/show_bug.cgi?id=686 > > Could someone review this patch when they have the chance? > > Thanks, > > Doug > > > > > -

Re: [Open64-devel] review request for missing .setion .bss in cgemit

2010-11-19 Thread Chandrasekhar Murthy
Is the struct size 0 for the SL case too. Murthy -Original Message- From: Sun Chan [mailto:sun.c...@gmail.com] Sent: Thursday, November 18, 2010 7:28 PM To: 朱庆; Gang Yu Cc: open64-devel@lists.sourceforge.net Subject: Re: [Open64-devel] review request for missing .setion .bss in cgemit G

Re: [Open64-devel] review request for missing .setion .bss in cgemit

2010-11-19 Thread Sun Chan
ok. So this is something introduced no in the original code. Pls check in. However, your print string does not need an extra '\n' in front and should not. Sun On Thu, Nov 18, 2010 at 5:41 PM, 朱庆 wrote: > Hi, All > > Can gatekeeper help review this fix? > > Case a.c: > struct line { char a[0];};