[Open64-devel] code review request for bug 516

2011-02-27 Thread Wu Yongchong
Hi, can a gatekeeper help review this patch? I have make a patch for bug 516,  https://bugs.open64.net/show_bug.cgi?id=516 $ cat test.c typedef float __v2f __attribute__ ((__vector_size__ (8))); __v2f foo3 (__v2f a0,__v2f a1,__v2f a2,__v2f a3) { return a0; } $ opencc -O0 -m32 -mmmx -c test.c

[Open64-devel] Code review for bug Id 732

2011-02-27 Thread Agarwal, Ajit
Hello All: Gatekeeper could you please review the fix for bug Id 732. The changes are made in wgen_expr.cxx And wn_lower.cxx. In wgen_expr.cxx the copy the -1 preg to a temp area is not done when for GS_CALL_EXPR and the Passed is GS_ADDR_EXPR with operand as GS_VAR_DECL. The MTYPE_M is not

[Open64-devel] review request for bug609

2011-02-27 Thread 朱庆
Hi all, Can gatekeeper help review this fix? https://bugs.open64.net/show_bug.cgi?id=609 The patch include implement multiply for type V8I1,M8I1,V16I1 Thanks zhuqing bug609.patch Description: Binary data -- Free Softwa

Re: [Open64-devel] Code Review Request (bug #721)

2011-02-27 Thread Sun Chan
I don't understand why this bug seemed so mysterious to fix. The problem is that the relocation and symbol attribute does not match. Instead of looking at where CG generated code for the use of the string, you keep looking at IPA to be the culprit. CG is generating the wrong relocation that says it

Re: [Open64-devel] Code Review Request (bug #721)

2011-02-27 Thread Sun Chan
for question #1, yes #2, as long as the symbol attribute and relocation is set correctly, why should that be a problem? That IPA causes multiple .o to be used is immaterial, the underlying situation is the same as if the same .o is being used, isn't it. For your previous mail, I thought I explained

Re: [Open64-devel] Code Review Request (bug #721)

2011-02-27 Thread Yiran Wang
Hi Sun, I have sent out the message too quick. There are actually two issues. 1. The printf is called without going through PLT. It should be definitely wrong. 2. The reference to const string does not go through GOT. a. It should be OK without IPA, as the .rodata and .text section is in a

Re: [Open64-devel] Code Review Request (bug #721)

2011-02-27 Thread Yiran Wang
Hi Sun, I investigate the bug a little bit, and the findings are: 0. Usually, -pic and -pie is linker option, while -fpic and -fpie is option for BE (for opencc). And -pie and -pic have the same effect, and -fpie and -fpic have the same effect, for open64 (or it would check if an executable is be

[Open64-devel] r3495 - trunk/osprey/be/com

2011-02-27 Thread svn
Author: laijx Date: 2011-02-27 08:18:36 -0500 (Sun, 27 Feb 2011) New Revision: 3495 Modified: trunk/osprey/be/com/wn_cfg_template.h Log: Fix two bugs in WHIRL CFG: 1. Fix the assertion about the ALTENTRY. The BB contains ALTENTRY should have one predecessor, the dummy entry. 2. Fix the segmenta

Re: [Open64-devel] Code review for WHIRL CFG bug fix

2011-02-27 Thread Sun Chan
pls go ahead Sun On Sun, Feb 27, 2011 at 6:31 PM, Jian-Xin Lai wrote: > Hi, > > Could a gate keeper review the patch to fix the bugs in WHIRL CFG? Thank you > very much. > Index: ../com/wn_cfg_template.h > === > --- ../com/wn_cfg_tem

[Open64-devel] Code review for WHIRL CFG bug fix

2011-02-27 Thread Jian-Xin Lai
Hi, Could a gate keeper review the patch to fix the bugs in WHIRL CFG? Thank you very much. Index: ../com/wn_cfg_template.h === --- ../com/wn_cfg_template.h(revision 1327) +++ ../com/wn_cfg_template.h(working copy) @@ -748,7 +