Re: [Open64-devel] Please help review a build broken fix for non-x86 targets [CG][LNO]

2011-07-10 Thread Sun Chan
Have you (with your suggested fix?) Sun On Mon, Jul 11, 2011 at 10:32 AM, Gang Yu wrote: > The unrelated-stuff make the compiler build broken. So, we have to fix it. > > Thanks > Gang > > > On Mon, Jul 11, 2011 at 10:31 AM, Sun Chan wrote: >> >> does this implementation make sense for you folks?

Re: [Open64-devel] Please help review a build broken fix for non-x86 targets [CG][LNO]

2011-07-10 Thread Gang Yu
Yes, although I do not check-in. With this patch, our daily regression is now OK. Gang On Mon, Jul 11, 2011 at 10:34 AM, Sun Chan wrote: > Have you (with your suggested fix?) > Sun > > On Mon, Jul 11, 2011 at 10:32 AM, Gang Yu wrote: > > The unrelated-stuff make the compiler build broken. So,

Re: [Open64-devel] Please help review a build broken fix for non-x86 targets [CG][LNO]

2011-07-10 Thread Gang Yu
The unrelated-stuff make the compiler build broken. So, we have to fix it. Thanks Gang On Mon, Jul 11, 2011 at 10:31 AM, Sun Chan wrote: > does this implementation make sense for you folks? > Sun > > On Mon, Jul 11, 2011 at 10:28 AM, Gang Yu wrote: > > Sun: > > > >We have a check on this

Re: [Open64-devel] Please help review a build broken fix for non-x86 targets [CG][LNO]

2011-07-10 Thread Sun Chan
does this implementation make sense for you folks? Sun On Mon, Jul 11, 2011 at 10:28 AM, Gang Yu wrote: > Sun: > >    We have a check on this (Is_Target_SSE41()), it is defined in > osprey/common/com/X8664/config_targ.h: > > 182#define Is_Target_SSE41()   (Target_SSE41 == TRUE) > > We believe

Re: [Open64-devel] Please help review a build broken fix for non-x86 targets [CG][LNO]

2011-07-10 Thread Gang Yu
Sun: We have a check on this (Is_Target_SSE41()), it is defined in osprey/common/com/X8664/config_targ.h: 182#define Is_Target_SSE41() (Target_SSE41 == TRUE) We believe it is unrelated to other targets, so still should we define this Is_Target_SSE41() for other targets? Thanks Gang

Re: [Open64-devel] Gatekeeper code review request for AMD 4.2.5.1 merge

2011-07-10 Thread Sun Chan
1.p has no assertion. Can you add? E.g. I would assert num_bbs no less than 1. The func LOOP_Block_Merge is not targ_x86, is it? As long as the call to it is TARG_X8664, it should be fine. 2.p, you are using bool, please use BOOL like that of 1.p if the segment: bool uses_destructive_d