Re: [Open64-devel] Review request: fixing issues when building the compiler as 64-bit binaries

2012-08-02 Thread Sun Chan
I see. So this is similar to what Srf was doing, except she is dealing with file, line etc Sun On Fri, Aug 3, 2012 at 1:47 PM, Jian-Xin Lai wrote: > The new ID is used for debug purpose in IPA phase. It tries to assign > each WN in different PU an unique ID. So that it's possible to track > the W

[Open64-devel] r4001 - trunk/osprey/be/cg

2012-08-02 Thread svn
Author: zhuqing Date: 2012-08-03 01:50:27 -0400 (Fri, 03 Aug 2012) New Revision: 4001 Modified: trunk/osprey/be/cg/whirl2ops.cxx Log: Fix bug1000, OP_NEED_PAIR should be decided by WN_rtype, not ST_mtype. Author of this patch: Xiao-jing zhang Code Review: Jian-xin Modified: trunk/osprey/be/c

Re: [Open64-devel] Review request: fixing issues when building the compiler as 64-bit binaries

2012-08-02 Thread Jian-Xin Lai
The new ID is used for debug purpose in IPA phase. It tries to assign each WN in different PU an unique ID. So that it's possible to track the WN with the given ID across PUs. 2012/8/2 Sun Chan : > There is WHIRL version for incompatible WHIRL matching and > identification. What is this new ID is

Re: [Open64-devel] Review request: fixing issues when building the compiler as 64-bit binaries

2012-08-02 Thread Sun Chan
Folks, Can we NOT argue in the abstract? Can someone put out some code and be specific, relevant to open64 code? Thx! Sun On Fri, Aug 3, 2012 at 11:04 AM, "C. Bergström" wrote: > On 08/ 3/12 06:19 AM, Gilmore, Doug wrote: >>> -Original Message- >>> From: "C. Bergström" [mailto:cbergst...@

Re: [Open64-devel] Review request: fixing issues when building the compiler as 64-bit binaries

2012-08-02 Thread C. Bergström
On 08/ 3/12 06:19 AM, Gilmore, Doug wrote: >> -Original Message- >> From: "C. Bergström" [mailto:cbergst...@pathscale.com] >> Sent: Saturday, July 28, 2012 11:09 PM >> To: Gilmore, Doug >> Cc: open64-devel >> Subject: Re: [Open64-devel] Review request: fixing issues when building >> the com

Re: [Open64-devel] Review request: fixing issues when building the compiler as 64-bit binaries

2012-08-02 Thread Gilmore, Doug
Note that the code was added a while back, (it is conditionally compiled off by default). I just did some cleanup so that one didn't have to patch the source to enable it. I find it useful to enable it from time to time, especially when tracking down the source of differences in generated WHIRL w

Re: [Open64-devel] Review request: fixing issues when building the compiler as 64-bit binaries

2012-08-02 Thread Sun Chan
for the float/double issue, can you include a code snippet that will affect by this change (you have mentioned probability, for example) Thx! Sun On Fri, Aug 3, 2012 at 7:19 AM, Gilmore, Doug wrote: > Sorry for the delay in my reply. >> -Original Message- >> From: "C. Bergström" [mailto:c

Re: [Open64-devel] Review request: fixing issues when building the compiler as 64-bit binaries

2012-08-02 Thread Gilmore, Doug
> -Original Message- > From: David Coakley [mailto:dcoak...@gmail.com] > Sent: Thursday, August 02, 2012 2:02 AM > To: Gilmore, Doug > Cc: open64-devel > Subject: Re: [Open64-devel] Review request: fixing issues when building > the compiler as 64-bit binaries > > Hi Doug, > > Nice job col

Re: [Open64-devel] Review request: fixing issues when building the compiler as 64-bit binaries

2012-08-02 Thread Gilmore, Doug
Sorry for the delay in my reply. > -Original Message- > From: "C. Bergström" [mailto:cbergst...@pathscale.com] > Sent: Saturday, July 28, 2012 11:09 PM > To: Gilmore, Doug > Cc: open64-devel > Subject: Re: [Open64-devel] Review request: fixing issues when building > the compiler as 64-bit b

Re: [Open64-devel] Review request: fixing issues when building the compiler as 64-bit binaries

2012-08-02 Thread C. Bergström
On 08/ 2/12 04:02 PM, David Coakley wrote: > Hi Doug, > > Nice job collecting all these changes. Building the compiler in > 64-bit mode is the way forward. > > I took a look at the build changes and didn't see any problems. All my other comments aside - You're totally fine with Double being promo

Re: [Open64-devel] Review request: fixing issues when building the compiler as 64-bit binaries

2012-08-02 Thread Sun Chan
There is WHIRL version for incompatible WHIRL matching and identification. What is this new ID is about? Sun On Thu, Aug 2, 2012 at 5:05 PM, Jian-Xin Lai wrote: > For the WHIRL ID for debug purpose, I think it's not very useful and > we can fully remove it. Otherwise the IR file generated by debu

[Open64-devel] Open64-devel] [IPA] code review for undefined symbol error caused by rev 3993

2012-08-02 Thread Xiaojing Zhang
Hi, This is a regression caused by rev 3993. Could a gatekeeper review this patch? Thank you very much. For a small case below, it will got link failure: > cat 1.c extern void foo(int a); int main() { foo(5); } >cat 2.c void foo(int a) { printf("a = %d\n", a); } >opencc -ipa

Re: [Open64-devel] Review request: fixing issues when building the compiler as 64-bit binaries

2012-08-02 Thread Jian-Xin Lai
For the WHIRL ID for debug purpose, I think it's not very useful and we can fully remove it. Otherwise the IR file generated by debug compiler and opt compiler isn't compatible. 2012/7/29 Gilmore, Doug : > I have put together a patch set that fixes various issues when > building X86 targeting comp

Re: [Open64-devel] Review request: fixing issues when building the compiler as 64-bit binaries

2012-08-02 Thread David Coakley
Hi Doug, Nice job collecting all these changes. Building the compiler in 64-bit mode is the way forward. I took a look at the build changes and didn't see any problems. A few suggestions: In patch 3, is there a Linux distro that defaults to GNU Gold that prompted this change? That would be a