Re: [Open64-devel] Review request on fix for bug838 [inline]

2011-10-28 Thread Gang Yu
Thanks! Suneel I consider it changes the O0 inline behavior for the backend components to keep up with gnu. I am not sure whether other platforms are interested in such change, just like in the ZDL patch, I introduce __attribute__((weak)) was not welcome, so I add a macro. If it is reasonable for

Re: [Open64-devel] Review request on fix for bug838 [inline]

2011-10-28 Thread Suneel Jain
Can this change be made unconditionally instead of putting it under "GNU_COMPATIBLE" ? Why is this change not reasonable for all contexts ? Adding this macro definition and use just seems added complexity. - Suneel On Thu, Oct 27, 2011 at 7:58 PM, Gang Yu wrote: > The patch is now ready, review

Re: [Open64-devel] Review request on fix for bug838 [inline]

2011-10-27 Thread Gang Yu
The patch is now ready, reviewed by Fred Chow and discussed with pathscale guys. Thanks besides fixing bug838, the patch also enhances the gnu compatibility: (1). enables -O0 -inline now (2). does not delete non-callable static functions under O0 (3). bug838-1 to bug838-6 at the open64.net regress

Re: [Open64-devel] Review request on fix for bug838 [inline]

2011-10-11 Thread Gang Yu
Sorry for the duplication effort on this bug, before my patch, yongchong had also submitted a patch to the list. I personally think my patch will be better, since patch from build system does not solve the compability problem with gnu and -inline will do really inline which is not a desired behavi

[Open64-devel] Review request on fix for bug838 [inline]

2011-10-07 Thread Gang Yu
Hi, Could a gatekeeper please help review the fix for bug838? http://bugs.open64.net/show_bug.cgi?id=838 symptom: opencc could not compile gcc for debug build(O0), a cutted down case as below: int i; static __inline__ void should_not_exist (void) { i=1; } yug@jupiter:~/work/bugs/b