Re: [OpenAFS] Re: Large files with 1.6.0pre2

2011-03-06 Thread Simon Wilkinson
On 6 Mar 2011, at 03:40, Russ Allbery wrote: > > I'm not sure what we were doing before. The positional I/O code only landed with 335ccb, which is on master and 1.6, but not on 1.4, which is why we haven't seen this problem before. I suspect that the correct solution is both to take Ryan's pa

Re: [OpenAFS] Re: Large files with 1.6.0pre2

2011-03-06 Thread Simon Wilkinson
On 6 Mar 2011, at 03:23, Ryan C. Underwood wrote: > > Yes, this was exactly it. Attached patch fixes the issue. Thanks. Pushed to gerrit as http://gerrit.openafs.org/4152 S. ___ OpenAFS-info mailing list OpenAFS-info@openafs.org https://lists.opena

Re: [OpenAFS] Re: Large files with 1.6.0pre2

2011-03-06 Thread Simon Wilkinson
On 6 Mar 2011, at 10:46, Simon Wilkinson wrote: > > On 6 Mar 2011, at 03:23, Ryan C. Underwood wrote: >> >> Yes, this was exactly it. Attached patch fixes the issue. > > Thanks. Pushed to gerrit as http://gerrit.openafs.org/4152 This fails on both Irix and AIX, as they don't have preadv64 a

Re: [OpenAFS] Re: Large files with 1.6.0pre2

2011-03-06 Thread Derrick Brashear
On Sun, Mar 6, 2011 at 7:32 AM, Simon Wilkinson wrote: > > On 6 Mar 2011, at 10:46, Simon Wilkinson wrote: > >> >> On 6 Mar 2011, at 03:23, Ryan C. Underwood wrote: >>> >>> Yes, this was exactly it.  Attached patch fixes the issue. >> >> Thanks. Pushed to gerrit as http://gerrit.openafs.org/4152 >

Re: [OpenAFS] Re: Large files with 1.6.0pre2

2011-03-06 Thread Chaz Chandler
This fails on both Irix and AIX, as they don't have preadv64 and pwritev64. I don't have either of those platforms in front of me, so it's not clear whether the correct thing to do is to just disable positional I/O if preadv64 and pwritev64 aren't found, or if the Irix& AIX variants support 6

Re: [OpenAFS] Re: Large files with 1.6.0pre2

2011-03-06 Thread Simon Wilkinson
On 6 Mar 2011, at 13:46, Chaz Chandler wrote: >> >> This fails on both Irix and AIX, as they don't have preadv64 and pwritev64. >> I don't have either of those platforms in front of me, so it's not clear >> whether the correct thing to do is to just disable positional I/O if >> preadv64 and p

Re: [OpenAFS] Re: Large files with 1.6.0pre2

2011-03-06 Thread Ryan C. Underwood
On Sat, Mar 05, 2011 at 11:55:45PM -0600, Andrew Deason wrote: > > When did Linux gain this? It's pretty easy to see now how I wasn't > hitting this on my Lenny box. About 2008 it looks like. http://lwn.net/Articles/311092/ -- Ryan C. Underwood, ___

Re: [OpenAFS] Re: Large files with 1.6.0pre2

2011-03-06 Thread Russ Allbery
Simon Wilkinson writes: > The positional I/O code only landed with 335ccb, which is on master and > 1.6, but not on 1.4, which is why we haven't seen this problem before. I > suspect that the correct solution is both to take Ryan's patch and to > investigate using AC_SYS_LARGEFILE. You do not wa

Re: [OpenAFS] Re: Large files with 1.6.0pre2

2011-03-06 Thread Simon Wilkinson
On 6 Mar 2011, at 20:45, Russ Allbery wrote: > Ryan's patch is basically a partial reimplementation of > _FILE_OFFSET_BITS=64 only for that one function. Actually, we're already carrying this logic to provide 64bit variants of all of the other file manipulation functions we use. It's just that

[OpenAFS] Re: Large files with 1.6.0pre2

2011-03-06 Thread Andrew Deason
On Sun, 6 Mar 2011 08:38:53 -0500 Derrick Brashear wrote: > safest thing to do is disable positional i/o if the p*v64 variants are > not found, and we can investigate further in the future (post 1.6.0) Disable _vectored_ positional i/o. If pio is otherwise fine, we should leave it alone. And I'