Re: [Openais] SAM - integration with quorum

2010-05-13 Thread Jan Friesse
Committed revision 2822. > Great work on the patch - good for merge > > Planning to do the watchdog portion (ie confdb) as separate patch? > For sure. > Regards > -steve > > On Fri, 2010-04-30 at 11:47 +0200, Jan Friesse wrote: >> Integration of SAM and quorum >> >> Regards, >>Honza >> ___

[Openais] corosync trunk - set uninitialized variable

2010-05-13 Thread Steven Dake
Although this is probably harmless, can't hurt to initialize this variable. Regards -steve ___ Openais mailing list Openais@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/openais

[Openais] Resource fails over OK, but other co-located services don't migrate with it?

2010-05-13 Thread Brodie, Kent
Greetings! I'm hoping someone can enlighten me as to what conceptual thing I'm doing wrong? I have four services, defined as a colocated group. Under normal circumstances, things seem to work fine-- when I put a node in standby, everything moves over as it should , and so on. (By the way,

Re: [Openais] [Corosync] Using TCP as a transport?

2010-05-13 Thread Alan Jones
Hi Steve, I'd like to work on the configuration option from this thread. Please comment on my proposed corosync.conf excerpt: interface { ringnumber: 0 udpucast: yes peeraddr: 192.168.9.1 peeraddr: 192.168.9.2

Re: [Openais] corosync trunk - set uninitialized variable

2010-05-13 Thread Angus Salkeld
On Thu, May 13, 2010 at 12:54:05PM -0700, Steven Dake wrote: > Although this is probably harmless, can't hurt to initialize this > variable. your patch is empty. -A > > Regards > -steve > ___ > Openais mailing list > Openais@lists.linux-foundation.o

[Openais] [PATCH 1/7] cov 10379 &10380: check result of open before calling ftruncate.

2010-05-13 Thread Angus Salkeld
Signed-off-by: Angus Salkeld --- exec/coroipcs.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/exec/coroipcs.c b/exec/coroipcs.c index 9394f21..9d81b7e 100644 --- a/exec/coroipcs.c +++ b/exec/coroipcs.c @@ -263,8 +263,9 @@ memory_map ( unlink (path);

[Openais] [PATCH 2/7] cov 10381: check result of open()

2010-05-13 Thread Angus Salkeld
Signed-off-by: Angus Salkeld --- exec/crypto.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/exec/crypto.c b/exec/crypto.c index 0ae415e..f85f4b9 100644 --- a/exec/crypto.c +++ b/exec/crypto.c @@ -1258,9 +1258,10 @@ static unsigned long rng_nix(unsigned char *buf,

[Openais] [PATCH 3/7] cov 10382: imporove error handling around open()

2010-05-13 Thread Angus Salkeld
Signed-off-by: Angus Salkeld --- exec/totemsrp.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/exec/totemsrp.c b/exec/totemsrp.c index c8d165e..3d8bd05 100644 --- a/exec/totemsrp.c +++ b/exec/totemsrp.c @@ -3063,6 +3063,7 @@ static void memb_ring_id_creat

[Openais] [PATCH 4/7] cov 10383: impove the error handling after socket()

2010-05-13 Thread Angus Salkeld
Signed-off-by: Angus Salkeld --- lcr/uis.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/lcr/uis.c b/lcr/uis.c index 004c464..93745a5 100755 --- a/lcr/uis.c +++ b/lcr/uis.c @@ -77,7 +77,9 @@ static void uis_lcr_bind (int *server_fd) */ fd = socket (P

[Openais] [PATCH 6/7] cov 10385: assigning signed int to unsigned variable

2010-05-13 Thread Angus Salkeld
Signed-off-by: Angus Salkeld --- tools/corosync-fplay.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/corosync-fplay.c b/tools/corosync-fplay.c index 8b681ee..f6f3bae 100644 --- a/tools/corosync-fplay.c +++ b/tools/corosync-fplay.c @@ -458,7 +458,7 @@ printf ("\n

[Openais] [PATCH 7/7] cov 10378: fix syntax error.

2010-05-13 Thread Angus Salkeld
Signed-off-by: Angus Salkeld --- exec/coroipcs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/exec/coroipcs.c b/exec/coroipcs.c index 9d81b7e..a2bc867 100644 --- a/exec/coroipcs.c +++ b/exec/coroipcs.c @@ -1000,7 +1000,7 @@ static void _corosync_ipc_init(void)

[Openais] [PATCH 5/7] cov 10384: better error handling from accept()

2010-05-13 Thread Angus Salkeld
Signed-off-by: Angus Salkeld --- lcr/uis.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/lcr/uis.c b/lcr/uis.c index 93745a5..a124134 100755 --- a/lcr/uis.c +++ b/lcr/uis.c @@ -174,12 +174,14 @@ static void *lcr_uis_server (void *data) ufd

Re: [Openais] [PATCH 1/7] cov 10379 &10380: check result of open before calling ftruncate.

2010-05-13 Thread Steven Dake
good for merge regards -steve On Fri, 2010-05-14 at 09:49 +1000, Angus Salkeld wrote: > Signed-off-by: Angus Salkeld > --- > exec/coroipcs.c | 10 ++ > 1 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/exec/coroipcs.c b/exec/coroipcs.c > index 9394f21..9d81b7e 100644

Re: [Openais] [PATCH 2/7] cov 10381: check result of open()

2010-05-13 Thread Steven Dake
good for merge On Fri, 2010-05-14 at 09:49 +1000, Angus Salkeld wrote: > Signed-off-by: Angus Salkeld > --- > exec/crypto.c |7 --- > 1 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/exec/crypto.c b/exec/crypto.c > index 0ae415e..f85f4b9 100644 > --- a/exec/crypto.c > +

Re: [Openais] [PATCH 3/7] cov 10382: imporove error handling around open()

2010-05-13 Thread Steven Dake
good for merge On Fri, 2010-05-14 at 09:49 +1000, Angus Salkeld wrote: > Signed-off-by: Angus Salkeld > --- > exec/totemsrp.c | 16 > 1 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/exec/totemsrp.c b/exec/totemsrp.c > index c8d165e..3d8bd05 100644 > --- a/ex

Re: [Openais] [PATCH 4/7] cov 10383: impove the error handling after socket()

2010-05-13 Thread Steven Dake
good for merge On Fri, 2010-05-14 at 09:49 +1000, Angus Salkeld wrote: > Signed-off-by: Angus Salkeld > --- > lcr/uis.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/lcr/uis.c b/lcr/uis.c > index 004c464..93745a5 100755 > --- a/lcr/uis.c > +++ b/lcr/uis.c > @@

Re: [Openais] [PATCH 5/7] cov 10384: better error handling from accept()

2010-05-13 Thread Steven Dake
good for merge On Fri, 2010-05-14 at 09:49 +1000, Angus Salkeld wrote: > Signed-off-by: Angus Salkeld > --- > lcr/uis.c |8 +--- > 1 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/lcr/uis.c b/lcr/uis.c > index 93745a5..a124134 100755 > --- a/lcr/uis.c > +++ b/lcr/uis.c

Re: [Openais] [PATCH 7/7] cov 10378: fix syntax error.

2010-05-13 Thread Steven Dake
good for merge On Fri, 2010-05-14 at 09:49 +1000, Angus Salkeld wrote: > Signed-off-by: Angus Salkeld > --- > exec/coroipcs.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/exec/coroipcs.c b/exec/coroipcs.c > index 9d81b7e..a2bc867 100644 > --- a/exec/coroipcs.c

Re: [Openais] [Corosync] Using TCP as a transport?

2010-05-13 Thread Steven Dake
ya looks good On Thu, 2010-05-13 at 16:15 -0700, Alan Jones wrote: > Hi Steve, > I'd like to work on the configuration option from this thread. > Please comment on my proposed corosync.conf excerpt: > > interface { > ringnumber: 0 > udpucast: yes >

Re: [Openais] [PATCH 6/7] cov 10385: assigning signed int to unsigned variable

2010-05-13 Thread Steven Dake
good for merge On Fri, 2010-05-14 at 09:49 +1000, Angus Salkeld wrote: > Signed-off-by: Angus Salkeld > --- > tools/corosync-fplay.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tools/corosync-fplay.c b/tools/corosync-fplay.c > index 8b681ee..f6f3bae 100644 > -

Re: [Openais] Resource fails over OK, but other co-located services don't migrate with it?

2010-05-13 Thread Vadym Chepkov
On May 13, 2010, at 4:40 PM, Brodie, Kent wrote: > Greetings! I’m hoping someone can enlighten me as to what conceptual thing > I’m doing wrong? > > I have four services, defined as a colocated group. Under normal > circumstances, things seem to work fine-- when I put a node in standby,