Re: [Openais] [PATCH] Allow nss building conditionally with rpmbuild operation

On Fri, Sep 02, 2011 at 09:56:14AM -0700, Steven Dake wrote: > Signed-off-by: Steven Dake ACK > --- > corosync.spec.in |8 > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/corosync.spec.in b/corosync.spec.in > index 74ab851..5c651aa 100644 > --- a/corosync.spec.

Re: [Openais] Corosync 2.0 Feature Request: Replace objdb/confdb with something easier to use

On Thu, Aug 25, 2011 at 05:16:20AM +0200, Fabio M. Di Nitto wrote: > On 08/25/2011 04:56 AM, Angus Salkeld wrote: > > > Possible Solutions > > == > > > > 1] API > > We really just want to get/set values do we really need a tree? > > as

Re: [Openais] Corosync 2.0 Feature Request: Replace objdb/confdb with something easier to use

On Thu, Aug 25, 2011 at 12:56:00PM +1000, Angus Salkeld wrote: > On Mon, Aug 08, 2011 at 09:41:10AM +0200, Jan Friesse wrote: > > Current objdb/confdb is really hard to use, because of all iterationing, > > ... It would be nice to replace it by hash table and thus for simple get

Re: [Openais] Corosync 2.0 Feature Request: Replace objdb/confdb with something easier to use

On Mon, Aug 08, 2011 at 09:41:10AM +0200, Jan Friesse wrote: > Current objdb/confdb is really hard to use, because of all iterationing, > ... It would be nice to replace it by hash table and thus for simple get > item or set item, no iteration is needed. But iteration functionality > should stil

Re: [Openais] [PATCH] Get rid of hdb usage in totempg.h interface

On Tue, Aug 23, 2011 at 02:13:07PM -0700, Steven Dake wrote: > hdb has some expense and is not necessary in the totempg.so runtime. This > patch removes the dependence on hdb and instead uses a direct pointer. ACK > > Signed-off-by: Steven Dake > --- > exec/main.c |2

Re: [Openais] [PATCH] Remove hdb.h header includes from unnecessary files

On Tue, Aug 23, 2011 at 01:03:48PM -0700, Steven Dake wrote: > The files in this patch do not use the hdb.h header. ACK > > Signed-off-by: Steven Dake > --- > exec/totemrrp.c |1 - > exec/totemsrp.c |1 - > exec/totemudp.c |1 - > exec/totemudp.h |1 - > exec/totemudpu.c |

Re: [Openais] [PATCH] Use qb_hdb instead of mutex based hdb code

On Mon, Aug 22, 2011 at 08:08:09PM -0700, Steven Dake wrote: > Rid ourselves of the mutex usage still in the code base ACK -Angus > > Signed-off-by: Steven Dake > --- > include/corosync/hdb.h | 307 > +++- > lcr/Makefile.am|3 +- > 2 f

Re: [Openais] [PATCH] Add totempg_threaded_mode_enable() api

On Mon, Aug 22, 2011 at 03:30:49PM -0700, Steven Dake wrote: > This API allows totem to operate as a multithreaded library. Performance is > better without threads but some library users may only have multithreaded > systems. In the corosync case where we have removed threads, this reduces > cpu

Re: [Openais] [PATCH] Move cs_queue.h from include directory to exec directory

On Mon, Aug 22, 2011 at 12:53:41PM -0700, Steven Dake wrote: > This file is only used by totemsrp.c. Move out of general include > directory. ACK -A > > Signed-off-by: Steven Dake > --- > exec/Makefile.am|2 +- > exec/cs_queue.h | 229 > +

Re: [Openais] [PATCH] use va version of external log function

On Mon, Aug 22, 2011 at 12:47:05PM -0700, Steven Dake wrote: > This removes a sprintf operation in the totem and ipc logging operations > ACK, will now need the latest libqb (else you can put a configure check for that function). -A > Signed-off-by: Steven Dake > --- > exec/main.c | 13 +++-

Re: [Openais] [PATCH] Display ring-ID consistently in debug

On Wed, Aug 17, 2011 at 12:44:36PM +1200, Tim Beale wrote: > Ring ID was being displayed both as hex and decimal in places. Update so > it's displayed consistently (I chose hex) to make debugging easier. Thanks, applied (with some line number changes). -Angus > --- > > exec/totemsrp.c |4 +

Re: [Openais] CPG client can lockup if the local node is in the downlist

On Wed, Aug 17, 2011 at 01:19:53PM +1200, Tim Beale wrote: > Hi, > > I'm resending this patch in a separate thread because I think this part of the > cluster formation problems I'm seeing has been overlooked. The patch attached > is one way of addressing the problem, but I'm open to alternatives.

Re: [Openais] [PATCH] Add code comment mapping message handler defines

On Wed, Aug 17, 2011 at 12:47:49PM +1200, Tim Beale wrote: > As a corosync-newbie it can be hard to bridge the gap between where a > particular message is sent and where the receive handler processes it, > and vice versa. > --- Thanks Tim, Applied. -Angus > > exec/totemsrp.c | 16 ++-

Re: [Openais] [PATCH 4/4] Remove -lcoroipcc from tools/Makefile.am notifyd

On Tue, Aug 09, 2011 at 02:55:06PM -0700, Steven Dake wrote: > Signed-off-by: Steven Dake Reviewed-by: Angus Salkeld > --- > tools/Makefile.am |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tools/Makefile.am b/tools/Makefile.am > index f8

Re: [Openais] [PATCH 3/4] properly define rec_token_cq_send_event_fn

On Tue, Aug 09, 2011 at 02:55:05PM -0700, Steven Dake wrote: > Signed-off-by: Steven Dake Reviewed-by: Angus Salkeld > --- > exec/totemiba.c |5 - > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/exec/totemiba.c b/exec/totemiba.c > index 00

Re: [Openais] [PATCH 2/4] Define totemiba_log_printf properly

On Tue, Aug 09, 2011 at 02:55:04PM -0700, Steven Dake wrote: > Signed-off-by: Steven Dake Reviewed-by: Angus Salkeld > --- > exec/totemiba.c |8 +--- > 1 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/exec/totemiba.c b/exec/totemiba.c > index a1

Re: [Openais] [PATCH 1/4] Fix problem in totemiba where incorrect define is used (and also not defined)

On Tue, Aug 09, 2011 at 02:55:03PM -0700, Steven Dake wrote: > Signed-off-by: Steven Dake Reviewed-by: Angus Salkeld > --- > exec/totemiba.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/exec/totemiba.c b/exec/totemiba.c > index 2d

Re: [Openais] [PATCH] Allow compile master on RHEL 6

On Tue, Aug 09, 2011 at 09:23:50AM +0200, Jan Friesse wrote: > corosync_timer_handle_t is know conditionally defined to prevent double > definition causing compile fault on RHEL 6 systems. Reviewed-by: Angus Salkeld > > Signed-off-by: Jan Friesse > ---

Re: [Openais] Corosync 2.0 Feature Request: merge libqb patch series

On Mon, Aug 08, 2011 at 12:00:47PM +1000, Angus Salkeld wrote: > Hi > > All the topic-libqb patches are Ack'ed. > > Now they need merging into master. > > All good to go? Steve ACK'ed on IRC... All pushed to master. -Angu

Re: [Openais] what's the usage/function of /etc/corosync/uidgid.d and service.d

On Tue, Aug 02, 2011 at 03:36:39PM +0800, Yingliang Yang wrote: > Hi, > In the directory /etc/corosync, there are 2 sub-directory called 'uidgid.d' > and 'service.d', I'd like to know their usage and functions, would anyone > please help to answer that? thank you very much! It is so other applica

[Openais] [PATCH] Add systemd unit files for corosync and corosync-notifyd

Signed-off-by: Angus Salkeld --- configure.ac |8 corosync.spec.in | 12 init/.gitignore |2 ++ init/Makefile.am | 15 +++ init/corosync-notifyd.service.in | 11 +++ init

[Openais] Corosync 2.0 Feature Request: merge libqb patch series

Hi All the topic-libqb patches are Ack'ed. Now they need merging into master. All good to go? Regards Angus Salkeld ___ Openais mailing list Openais@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/openais

[Openais] [PATCH] Make realtime scheduling optional not the default.

Signed-off-by: Angus Salkeld --- configure.ac |6 ++ exec/main.c| 21 +++-- man/corosync.8 |7 +-- 3 files changed, 26 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index 35e3cfb..e00edeb 100644 --- a/configure.ac +++ b

[Openais] [PATCH 3/6] Fix some compiler warnings

Signed-off-by: Angus Salkeld --- configure.ac |4 +- exec/crypto.c |2 - exec/main.c |3 -- exec/objdb.c | 76 lib/confdb.c |3 ++ services/confdb.c |7 +++- services/cpg.c|2 - 7 files

[Openais] [PATCH 4/6] libqb: Add libqb dependency in the rpm & pc file

Signed-off-by: Angus Salkeld --- corosync.spec.in |2 +- pkgconfig/corosync.pc.in |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/corosync.spec.in b/corosync.spec.in index 58c4b0d..d50b72c 100644 --- a/corosync.spec.in +++ b/corosync.spec.in @@ -36,7 +36,7

[Openais] merge topic-libqb into master

d/corosync/commits/master I have rebased the topic-libqb branch ontop of master to make for a cleaner history. Note: libqb is only in Fedora 15 onwards (that I am aware of) but will still need to find it's way into other distros. Regards Angus Salkeld

[Openais] [PATCH 2/6] Use PATH_MAX for file path size

Signed-off-by: Angus Salkeld --- lib/cpg.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/cpg.c b/lib/cpg.c index caf3efe..71704c0 100644 --- a/lib/cpg.c +++ b/lib/cpg.c @@ -777,7 +777,7 @@ cs_error_t cpg_zcb_alloc ( void **buffer) { void *buf

[Openais] [PATCH 1/6] Remove scheduling

Signed-off-by: Angus Salkeld --- exec/main.c | 55 +-- 1 files changed, 1 insertions(+), 54 deletions(-) diff --git a/exec/main.c b/exec/main.c index b03d33e..006f846 100644 --- a/exec/main.c +++ b/exec/main.c @@ -144,8 +144,6

[Openais] [PATCH 6/6] Update TODOs

Signed-off-by: Angus Salkeld --- TODO | 73 + 1 files changed, 19 insertions(+), 54 deletions(-) diff --git a/TODO b/TODO index 9a2db8f..fa30e36 100644 --- a/TODO +++ b/TODO @@ -3,69 +3,34 @@ The Corosync Cluster Engine Topic

Re: [Openais] [PATCH] Fix usage of strerror_r()/perror()

GSYS_ENCODE_RECID(), ENTER(), LEAVE(), etc) while only some are in > lower case (log_printf(), log_rec()). Well I suppose that's OK then - good work. Reviewed-by: Angus Salkeld > > > On 27.06.2011 13:17, Angus Salkeld wrote: > >Cool, much better. Any reason for the capit

Re: [Openais] [PATCH] Fix usage of strerror_r()/perror()

Cool, much better. Any reason for the capitals? Not a big deal but the other log macros are lower case... -Angus On Mon, Jun 27, 2011 at 11:42:02AM +0200, Jerome Flesch wrote: > Signed-off-by: Jerome Flesch > --- > exec/coroipcs.c | 23 +++-- > exec/coroparse.c

Re: [Openais] [PATCH] Fix usage of strerror_r on GNU systems

On Mon, Jun 27, 2011 at 03:34:56PM +1000, Angus Salkeld wrote: > Wouldn't it be cleaner if we put this macro in logsys.h: > > #define log_perror(err_num, level, format, args...) do { \ > ... > #endif > > Then use it like a normal log function: > log_perror(errno, L

Re: [Openais] [PATCH] Fix usage of strerror_r on GNU systems

Wouldn't it be cleaner if we put this macro in logsys.h: #define log_perror(err_num, level, format, args...) do { \ ... #endif Then use it like a normal log function: log_perror(errno, LOG_ERR, "bad stuff"); It then logs: ERR bad stuff : -Angus On Fri, Jun 24, 2011 at 03:17:50PM +0200, Jerome

Re: [Openais] [PATCH 1/3] confdb: Properly check result of object_find_create

object_find_next. > Reviewed-by: Angus Salkeld > Signed-off-by: Jan Friesse > --- > services/confdb.c | 29 + > 1 files changed, 21 insertions(+), 8 deletions(-) > > diff --git a/services/confdb.c b/services/confdb.c > index b57a041.

Re: [Openais] [PATCH 2/3] coroipcc: check recvmsg result in socket_recv

all systems. Yes, I don't why left Linux out. Reviewed-by: Angus Salkeld > > Signed-off-by: Jan Friesse > --- > lib/coroipcc.c |6 ++ > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/lib/coroipcc.c b/lib/coroipcc.c > index b017155..d1f8

Re: [Openais] [Pacemaker] Linux HA on debian sparc

f the > first? > > Well there are 3 calls to mmap() 1) one to allocate 2 * what you need (in pages) 2) maps the first half of the mem to a real file 3) maps the second half of the mem to the same file The point is when you write to an address over the end of the first half of memory it

Re: [Openais] [Pacemaker] Linux HA on debian sparc

On Tue, May 31, 2011 at 06:25:56PM -0300, william felipe_welter wrote: > Thanks Steven, > > Now im try to run on the MCP: > - Uninstall the pacemaker 1.0 > - Compile and install 1.1 > > But now i have problems to initialize the pacemakerd: Could not initialize > Cluster Configuration Database API

Re: [Openais] [PATCH] Add coverity target to corosync makefile.am

On Thu, May 19, 2011 at 07:54:20PM -0700, Steven Dake wrote: > Allow a make coverity target for those developers with coverity tools > available to them. Gasp, no configure check for coverity? -Angus > > Signed-off-by: Steven Dake > --- > Makefile.am |5 + > 1 files changed, 5 inserti

Re: [Openais] [PATCH 1/2] Store cpg process information in objdb

Hi Just one comments inline. -Angus On Wed, May 11, 2011 at 05:35:44PM +0200, Jan Friesse wrote: > Information about processes using cpg are now stored in objdb. > Each process info is object stored in cpg object, with nodeid, > pid and group name keys. > --- > services/cpg.c | 124 >

[Openais] [PATCH 03/10] CTS: add -l to keygen (normal keygen struggles to run on VMs)

Signed-off-by: Angus Salkeld --- cts/corotests.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cts/corotests.py b/cts/corotests.py index d15bf2d..ede2a5d 100644 --- a/cts/corotests.py +++ b/cts/corotests.py @@ -57,7 +57,7 @@ class CoroTest(CTSTest): # setup

[Openais] [PATCH 06/10] CTS: bump up log messages of failed RPC

Signed-off-by: Angus Salkeld --- cts/corosync.py | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/cts/corosync.py b/cts/corosync.py index 70dff3c..0fce75e 100644 --- a/cts/corosync.py +++ b/cts/corosync.py @@ -425,8 +425,10 @@ class TestAgent(object

[Openais] [PATCH 10/10] cpg: fix sync master selection when one node paused.

lection: 1) largest (previous #nodes - #nodes know to have left) 2) (then as a tie-breaker) node with smallest nodeid Signed-off-by: Angus Salkeld --- services/cpg.c | 23 ++- 1 files changed, 18 insertions(+), 5 deletions(-) diff --git a/services/cpg.c b/services/cpg.c ind

[Openais] [PATCH 07/10] CTS: fix syntax error in log message

Signed-off-by: Angus Salkeld --- cts/corotests.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cts/corotests.py b/cts/corotests.py index ede2a5d..8175042 100644 --- a/cts/corotests.py +++ b/cts/corotests.py @@ -907,7 +907,7 @@ class VoteQuorumGoDown(VoteQuorumBase

[Openais] [PATCH 09/10] CTS: fix some tests that didn't handle been called more than one

Signed-off-by: Angus Salkeld --- cts/corosync.py |2 +- cts/corotests.py | 13 +++-- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/cts/corosync.py b/cts/corosync.py index bcaa796..cded96b 100644 --- a/cts/corosync.py +++ b/cts/corosync.py @@ -438,7 +438,7

[Openais] [PATCH 04/10] autobuild: improve messages

Signed-off-by: Angus Salkeld --- autobuild.sh | 37 +++-- 1 files changed, 19 insertions(+), 18 deletions(-) diff --git a/autobuild.sh b/autobuild.sh index 17e1a37..01ecf9c 100755 --- a/autobuild.sh +++ b/autobuild.sh @@ -1,6 +1,6 @@ #!/bin/sh # -# This

[Openais] [PATCH 02/10] CTS: send with correct number of iovecs

Else payload won't be sent Signed-off-by: Angus Salkeld --- cts/agents/cpg_test_agent.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cts/agents/cpg_test_agent.c b/cts/agents/cpg_test_agent.c index e668737..86191cb 100644 --- a/cts/agents/cpg_test_agent.c +++

[Openais] [PATCH 08/10] CTS: sort the configuration - prevent duplicates in the config file

Signed-off-by: Angus Salkeld --- cts/corosync.py |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/cts/corosync.py b/cts/corosync.py index 0fce75e..bcaa796 100644 --- a/cts/corosync.py +++ b/cts/corosync.py @@ -180,7 +180,8 @@ class corosync_flatiron(ClusterManager

[Openais] [PATCH 01/10] CTS: timer should not be on the stack

Signed-off-by: Angus Salkeld --- cts/agents/cpg_test_agent.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cts/agents/cpg_test_agent.c b/cts/agents/cpg_test_agent.c index a0af9c1..e668737 100644 --- a/cts/agents/cpg_test_agent.c +++ b/cts/agents/cpg_test_agent.c

[Openais] [PATCH 05/10] CTS: don't force all-once (breaks random tests)

Signed-off-by: Angus Salkeld --- cts/corolab.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cts/corolab.py b/cts/corolab.py index 340c751..3541f47 100755 --- a/cts/corolab.py +++ b/cts/corolab.py @@ -133,7 +133,7 @@ class CoroLabEnvironment(CtsLab): self

Re: [Openais] [PATCH] totemsrp: Enhance mcast failure detection

Looks good. Reviewed-by: Angus Salkeld On Wed, May 04, 2011 at 05:27:11PM +0200, Jan Friesse wrote: > memb_state_gather_enter increase stats.continuous_gather only if > previous state was gather also. This should happen only if multicast is > not working properly (local firewall in m

Re: [Openais] [PATCH 2/2] Align ipc on 8 byte boundaries

Reviewed-by: Angus Salkeld On Mon, Jan 03, 2011 at 04:40:55PM -0700, Steven Dake wrote: > Align all ipc messages on 8 byte boundaries. This alignment will remove bus > errors on systems that can't access non-byte aligned data and should improve > performance. > > Signed

Re: [Openais] [PATCH 1/2] Fix problem where unaligned totemip address access would result in bus error on non-unaligned-safe architectures.

Missed this: Reviewed-by: Angus Salkeld On Mon, Jan 03, 2011 at 04:40:54PM -0700, Steven Dake wrote: > Signed-off-by: Steven Dake > --- > exec/totemip.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/exec/totemip.c b/exec/totemip.c > i

[Openais] [PATCH] IPC: place calls to stats functions outside of mutexes

This is to prevent nasty deadlocks between IPC and objdb. Signed-off-by: Angus Salkeld --- exec/coroipcs.c | 55 --- 1 files changed, 36 insertions(+), 19 deletions(-) diff --git a/exec/coroipcs.c b/exec/coroipcs.c index dbafb18..452bbf6

[Openais] [openais-whitetank PATCH 1/2] IPC: handle maximum use of file descriptors gracefully.

If we get EMFILE from accept() then withdraw the published server listening socket. Then when a connection closes see if we need to re-publish the server sockect. Signed-off-by: Angus Salkeld --- exec/ipc.c | 161 +-- 1 files changed, 101

[Openais] [openais-whitetank PATCH 2/2] IPC: if shmget() or semget() return ENOSPC then exit the while loop.

I noticed this while testing the high FD usage patch. It can get stuck in the while loop. Signed-off-by: Angus Salkeld --- lib/util.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/lib/util.c b/lib/util.c index f285eb5..76b3891 100644 --- a/lib/util.c +++ b/lib

Re: [Openais] [PATCH 1/1] whitetank: Return error if there is no space for semaphore

On Thu, Mar 17, 2011 at 05:56:46PM +0100, Jan Friesse wrote: > open_ais_service_connect creates SYS V semaphores and shms. > If system limit for semaphores/shms is exceeded code looped > in endless cycle. > Reviewed-by: Angus Salkeld > Now ENOSPC is correctly handled and SA_AIS_

[Openais] [PATCH] Fix shutdown when a confdb client is still connected

_stop() before the object gets destroyed. Signed-off-by: Angus Salkeld --- exec/coroipcs.c |2 +- services/confdb.c |3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/exec/coroipcs.c b/exec/coroipcs.c index 29655ba..dbafb18 100644 --- a/exec/coroipcs.c +++ b

[Openais] [PATCH] STATS: add the service name to the connection name.

dbus/snmp events what is going on. Signed-off-by: Angus Salkeld --- exec/coroipcs.c | 26 +++--- exec/util.c | 47 +++ exec/util.h |6 ++ 3 files changed, 72 insertions(+), 7 deletions(-) diff --git a/exec

[Openais] [PATCH 2/3] NOTIFYD: prevent duplicate quorate events.

Signed-off-by: Angus Salkeld --- tools/corosync-notifyd.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/tools/corosync-notifyd.c b/tools/corosync-notifyd.c index 4a58189..7f231fa 100644 --- a/tools/corosync-notifyd.c +++ b/tools/corosync-notifyd.c @@ -70,6 +70,8

[Openais] [PATCH 1/3] NOTIFYD: fix retrieving the application's parent name.

Signed-off-by: Angus Salkeld --- tools/corosync-notifyd.c | 14 +++--- 1 files changed, 3 insertions(+), 11 deletions(-) diff --git a/tools/corosync-notifyd.c b/tools/corosync-notifyd.c index 7af573c..4a58189 100644 --- a/tools/corosync-notifyd.c +++ b/tools/corosync-notifyd.c

[Openais] [PATCH 3/3] STATS: add the service name to the connection name.

dbus/snmp events what is going on. Signed-off-by: Angus Salkeld --- exec/coroipcs.c | 106 +++ 1 files changed, 99 insertions(+), 7 deletions(-) diff --git a/exec/coroipcs.c b/exec/coroipcs.c index b64c5a9..bfb638b 100644 --- a/exec

[Openais] [PATCH] confdb: send notifications from the main thread not IPC thread

atch we call the real ipc_dispatch_send(). Signed-off-by: Angus Salkeld --- services/confdb.c | 89 ++--- 1 files changed, 84 insertions(+), 5 deletions(-) diff --git a/services/confdb.c b/services/confdb.c index 56e3ae1..3187718 100644 --- a/se

Re: [Openais] coroipcc_dispatch_get return values

On Mon, Mar 21, 2011 at 06:46:03PM +0530, Ramesh Random wrote: > Hi, >i am using coroipcc_dispatch_get() to read the asynchronous buffer > response. i am not able to differentiate between return values for it > CS_ERR_TRY_AGAIN and CS_OK. i tried to look into source code of > coroipcc_dispa

[Openais] [PATCH] notifyd: dispatch only one message at a time.

This is avoid getting stuck in the dispatch processing messages when the user is trying to shutdown the service. Signed-off-by: Angus Salkeld --- tools/corosync-notifyd.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/corosync-notifyd.c b/tools/corosync

Re: [Openais] [PATCH 1/3] Fix the ttl defaults and range

On Tue, Mar 15, 2011 at 08:30:10AM +0100, Fabio M. Di Nitto wrote: > Patch 1 and 2 ACK. I´ll leave 3 to Steven, but it looks good. > applied + pushed. -Angus > Fabio > ___ Openais mailing list Openais@lists.linux-foundation.org https://lists.linux-fo

Re: [Openais] [PATCH 3/3] Fix some "set but not used" warnings [-Wunused-but-set-variable]

On Mon, Mar 14, 2011 at 08:57:06PM -0500, Russell Bryant wrote: > On Mon, Mar 14, 2011 at 6:44 PM, Angus Salkeld wrote: > > -       res = totempg_groups_mcast_joined (sync_group_handle, > > +       (void)totempg_groups_mcast_joined (sync_group_handle, > >                &

Re: [Openais] [PATCH] Add Doxyfile to .gitignore

g, ya I forgot that bit. Applied. -Angus On Sat, Mar 12, 2011 at 06:37:53AM -0600, Russell Bryant wrote: > Signed-off-by: Russell Bryant > --- > .gitignore |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/.gitignore b/.gitignore > index 30b45a1..7d84436 100644

[Openais] [PATCH 3/3] Fix some "set but not used" warnings [-Wunused-but-set-variable]

Signed-off-by: Angus Salkeld --- exec/logsys.c |5 + exec/main.c|3 --- exec/syncv2.c |9 +++-- exec/totemconfig.c |2 +- exec/totempg.c |3 +-- exec/totemsrp.c| 15 --- exec/totemudp.c|6

[Openais] [PATCH 2/3] Remove the ttl option from udpu and rely on the kernel ttl setting.

Signed-off-by: Angus Salkeld --- exec/totemconfig.c |5 + exec/totemudpu.c| 21 - man/corosync.conf.5 |1 + 3 files changed, 6 insertions(+), 21 deletions(-) diff --git a/exec/totemconfig.c b/exec/totemconfig.c index 7039ba0..0b9732b 100644 --- a/exec

[Openais] [PATCH 1/3] Fix the ttl defaults and range

1) both IPv4 and IPv6 mcast should default to ttl=1 2) the range should be 0..255 0 is valid meaning localhost only (cluster of one) Signed-off-by: Angus Salkeld --- exec/totemconfig.c | 10 +++--- man/corosync.conf.5 |2 +- 2 files changed, 4 insertions(+), 8 deletions(-) diff

Re: [Openais] [PATCH] Convert existing documentation to doxygen format.

aving to add new content. > Reviewed-by: Angus Salkeld Nice work, applied. > Signed-off-by: Russell Bryant > --- > exec/main.h | 10 ++- > exec/mainconfig.h|4 +- > exec/service.h | 13 ++- > exec/tlist.h

Re: [Openais] [PATCH] Convert existing documentation to doxygen format.

On Tue, Mar 08, 2011 at 05:00:34PM -0600, Russell Bryant wrote: > On Tue, Mar 8, 2011 at 2:06 PM, Steven Dake wrote: > > A "developer internals guidebook" would be immensely helpful - as long > > as it can be segregated from the external consumable APIs in the > > documentation. > > > > I believe

Re: [Openais] [PATCH] Convert existing documentation to doxygen format.

Hi Russell Some gneral comments: 1) I don't think you need all those "\brief" keywords. I think they look quite ugly in the code. Below works fine for me and is cleaner. /** * this is always a brief * * leave a line and this is the vebose description. */ 2) I think there little point publis

Re: [Openais] [PATCH] Fix abort when token is lost in RECOVERY state

t;. exec/totemsrp.c:int old_ring_state_saved; exec/totemsrp.c:instance->old_ring_state_saved = 1; exec/totemsrp.c:instance->old_ring_state_saved = 0; Reviewed-by: Angus Salkeld > Signed-off-by: Steven Dake > --- > exec/totemsrp.c | 59 +

Re: [Openais] [PATCH] snmp: Allow buildling of corosync on already existing older install of corosync

g before the proper > LDADD flags. The result is an inability to compile on an already existing > installation. > > Signed-off-by: Steven Dake Oops, sorry - my fault. Reviewed-by: Angus Salkeld > --- > tools/Makefile.am |4 ++-- > 1 files changed, 2 insertions(+),

Re: [Openais] [PATCH] Don't assert when ring id file is less then 8 bytes

, Corosync will create fresh ring id file data when the > incorrect number of bytes are read from the ring id. > > Amend to use sizeof the strerror string length and PATH_MAX for the path > length. > > Signed-off-by: Steven Dake Reviewed-by: Angus Salkeld I hope the change f

Re: [Openais] [PATCH] Add -l option to corosync-keygen.

On Sun, Feb 20, 2011 at 07:48:59PM -0600, Russell Bryant wrote: > Add -l option to corosync-keygen. You should also update the man page: man/corosync-keygen.8 -Angus > > This option (-l or --less-secure) causes corosync-keygen to read from > /dev/urandom instead of /dev/random to ensure that no

Re: [Openais] [Corosync] Automate corosync-generate

it's maybe a problem with pacemaker, i don't know ... > > I want automate the creation of the authkeys file. That might be problematic, corosync-keygen requires you to type on the keyboard - try it by it's self. > > Thanks > > Camille > > 2011/2/20 Angus

Re: [Openais] error with master master drbd config

On Sun, Feb 20, 2011 at 12:52:32AM +0100, Thomas Elsäßer wrote: > hi all, > I suggest you try the pacemaker mailing list :"pacema...@oss.clusterlabs.org". -Angus > i have a problem wtih my cluster. I have a resource with drbd master master > here my config: the homeFS is not running (with ocfs2

Re: [Openais] Corosync compile fail in Ubuntu Server

On Sun, Feb 20, 2011 at 12:45:32AM +0100, Alessio Gennari wrote: > Hello to everyone, > I'm tryingo to compile Corosync 1.3.0 in a Ubuntu Server 10.10 64bit system: > after autogen.sh when I run configure, I receive a syntax error at row with > PKG_CHECK_MODULE(nss,nss). I have heard of this befor

Re: [Openais] [Corosync] Automate corosync-generate

On Thu, Feb 17, 2011 at 02:14:07PM +0100, Camille Néron wrote: > Hello, > > I'm French user, so sorry for my English :-). > > I need to automate the installation and configuration of Pacemaker and I > encounter a problem when I want script "corosync-generate". This command > need I tape on my key

[Openais] [PATCH] autobuild: clean the build dir first.

This deletes files like .version that cause problems. Signed-off-by: Angus Salkeld --- autobuild.sh |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/autobuild.sh b/autobuild.sh index df429ef..17e1a37 100755 --- a/autobuild.sh +++ b/autobuild.sh @@ -20,6 +20,8 @@ fi

[Openais] [PATCH] CTS: temp remove troublesome tests.

a manual ssh works fine. Basically I think it's more important the we get reliable testing than have these test in there. Signed-off-by: Angus Salkeld --- cts/corotests.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cts/corotests.py b/cts/corotests.py

[Openais] [PATCH] Fix merge markers in spec file

Signed-off-by: Angus Salkeld --- corosync.spec.in |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/corosync.spec.in b/corosync.spec.in index 1eb07f0..ba54123 100644 --- a/corosync.spec.in +++ b/corosync.spec.in @@ -2,8 +2,6 @@ %global numcomm @numcomm@ %global dirty

Re: [Openais] [PATCH] Make node state a string (not an integer)

On Mon, Feb 07, 2011 at 08:15:37AM -0700, Steven Dake wrote: > Reviewed-by: Steven Dake pushed 2 commits: Make node state a string (not an integer) CONFDB: fix parent_get response id I forgot to push the second one earier by mistake. -Angus > > On 02/05/2011 01:39 AM, Angus Salk

[Openais] [PATCH] Make node state a string (not an integer)

Ryan noticed this inconsistency, all other status's are string so this should be too. Signed-off-by: Angus Salkeld --- conf/COROSYNC-MIB.txt|6 +- tools/corosync-notifyd.c | 11 +-- 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/conf/COROSYNC-MIB.

Re: [Openais] [PATCH] MIB: expand the descriptions of the notifications

On Thu, Feb 03, 2011 at 04:11:53PM -0700, Steven Dake wrote: > Reviewed-by: Steven Dake Thanks Steven, I have now pushed all the snmp commits to topic-snmp. Merge to master at your convience. -Angus > > On 02/03/2011 04:00 PM, Angus Salkeld wrote: > > On Wed, Feb 02, 2011 at 1

Re: [Openais] [PATCH] MIB: expand the descriptions of the notifications

On Wed, Feb 02, 2011 at 12:15:46PM +1100, Angus Salkeld wrote: > Signed-off-by: Angus Salkeld > --- > conf/COROSYNC-MIB.txt | 20 +--- > 1 files changed, 17 insertions(+), 3 deletions(-) > > diff --git a/conf/COROSYNC-MIB.txt b/conf/COROSYNC-MIB.txt > i

Re: [Openais] topic-snmp patch series

On Tue, Feb 01, 2011 at 02:16:15PM +1100, Angus Salkeld wrote: > This is a first cut of the snmp series. Thanks to Lon for his mib > work! > > Reviewers please look at: > > 1) the init script (order & requires). > > 2) There is a man page. Some of the TODO section co

[Openais] [PATCH] MIB: expand the descriptions of the notifications

Signed-off-by: Angus Salkeld --- conf/COROSYNC-MIB.txt | 20 +--- 1 files changed, 17 insertions(+), 3 deletions(-) diff --git a/conf/COROSYNC-MIB.txt b/conf/COROSYNC-MIB.txt index c8a257a..b62ffa3 100644 --- a/conf/COROSYNC-MIB.txt +++ b/conf/COROSYNC-MIB.txt @@ -126,7

Re: [Openais] [PATCH 2/5] Fix plugin logic and SNMP/DBUS logic

On Tue, Feb 01, 2011 at 08:51:43AM -0700, Steven Dake wrote: > Can you amend your first patch with this change? Well, it's Lon's patch. If he doesn't mind sure. -Angus > > Regards > -steve > > On 01/31/2011 08:16 PM, Angus Salkeld wrote: > > From: Lon

Re: [Openais] [PATCH 1/5] Add dbus and snmp notifier

On Tue, Feb 01, 2011 at 07:14:22AM -0600, Russell Bryant wrote: > > +int > > +main(int argc, char *argv[]) > > +{ > > +       int ch; > > + > > +       conf[CS_NTF_FG] = 0; > > +       conf[CS_NTF_LOG] = 0; > > +       conf[CS_NTF_STDOUT] = 0; > > +       conf[CS_NTF_SNMP] = 0; > > +       conf[CS_

[Openais] [PATCH 1/5] Add dbus and snmp notifier

This is to send dbus events on major cluster events: - membership changes - application connect/dissconnet from corosync - quorum changes dbus events can then be converted into snmp traps by foghorn or corosync-notifyd can be run to directly send snmp traps. Signed-off-by: Angus Salkeld

[Openais] [PATCH 3/5] Make SNMP MIB match what is being sent over DBUS

From: Lon Hohberger Signed-off-by: Lon Hohberger Reviewed-by: Angus Salkeld --- conf/COROSYNC-MIB.txt | 237 + 1 files changed, 119 insertions(+), 118 deletions(-) diff --git a/conf/COROSYNC-MIB.txt b/conf/COROSYNC-MIB.txt index 5143190

[Openais] [PATCH 5/5] SPEC: remove duplicate corosync-blackbox

Signed-off-by: Angus Salkeld --- corosync.spec.in |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/corosync.spec.in b/corosync.spec.in index aec13c6..79d4c28 100644 --- a/corosync.spec.in +++ b/corosync.spec.in @@ -112,7 +112,6 @@ fi %files %defattr(-,root,root,-) %doc

[Openais] [PATCH 4/5] Match up MIB to notifyd & add SNMP quorum events

From: Lon Hohberger Signed-off-by: Lon Hohberger Reviewed-by: Angus Salkeld --- tools/corosync-notifyd.c | 77 ++ 1 files changed, 64 insertions(+), 13 deletions(-) diff --git a/tools/corosync-notifyd.c b/tools/corosync-notifyd.c index a78f6a3

[Openais] [PATCH 2/5] Fix plugin logic and SNMP/DBUS logic

From: Lon Hohberger Signed-off-by: Lon Hohberger Signed-off-by: Angus Salkeld --- tools/corosync-notifyd.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/tools/corosync-notifyd.c b/tools/corosync-notifyd.c index d0565de..a78f6a3 100644 --- a/tools

[Openais] topic-snmp patch series

This is a first cut of the snmp series. Thanks to Lon for his mib work! Reviewers please look at: 1) the init script (order & requires). 2) There is a man page. Some of the TODO section could be put into it. Can you check the arguments "-f -d -s -l -o -m" to make sure they don't clash with

[Openais] snmp support in corosync

ded Sato-san's link status (just to keep it simple). Feel free to contribute, just note I am going on holiday for 2 weeks and Steven will continue this work. Read the TODO section to see how to run/test and what needs doing. Regards Angus Salkeld Example dbus signals output from "dbus-mon

[Openais] [PATCH 1/4] STATS: increase the space for application names

Signed-off-by: Angus Salkeld --- exec/coroipcs.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/exec/coroipcs.c b/exec/coroipcs.c index 703802a..1897231 100644 --- a/exec/coroipcs.c +++ b/exec/coroipcs.c @@ -1545,8 +1545,8 @@ static char * pid_to_name (pid_t pid

  1   2   3   4   5   6   7   8   >