Re: [OpenBabel-Devel] Fwd: [openbabel] OBConversion improvements (#191)

2015-06-16 Thread Noel O'Boyle
I think we need to embrace a certain amount of backwards incompatability over a few releases in order to get the toolkit where it needs to be, so I've no particular problem with that. It would be nice to have the build failures fixed so I can test on Windows though... On 15 June 2015 at 20:45, Geo

Re: [OpenBabel-Devel] Fwd: [openbabel] OBConversion improvements (#191)

2015-06-16 Thread David Koes
Speaking of Windows, I forgot to mention in the pull request that I removed the DISABLE_OUTPUT_COMPRESSION macro that was turned on for Windows only. The original bug report is a few years old (http://sourceforge.net/p/openbabel/bugs/104/) and I figured it would be worth checking again with a

Re: [OpenBabel-Devel] Fwd: [openbabel] OBConversion improvements (#191)

2015-06-16 Thread Noel O'Boyle
See the links to the automated builds on the pull request. e.g. c:\openbabel\src\obconversion.cpp(803): error C4716: 'OpenBabel::OBConversion::FormatFromExt' : must return a value [C:\openbabel\build\src\openbabel.vcxproj] c:\openbabel\src\obconversion.cpp(305): error C4716: 'OpenBabel::OBConversi

Re: [OpenBabel-Devel] [openbabel] OBConversion improvements (#191)

2015-06-16 Thread David Koes
How are you suppose to auto-recognize an output file that hasn't been written yet as gzip? I think of the compression as part of the format - you shouldn't need an open stream in order to fully specify what it should be. An example of something that now works the way you would expect: babel x.m