Bugs item #2889763, was opened at 2009-10-30 19:00
Message generated for change (Tracker Item Submitted) made by fab5
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=428740&aid=2889763&group_id=40728

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Command-line Tools
Group: 2.2.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Fabian (fab5)
Assigned to: Nobody/Anonymous (nobody)
Summary: Building bonds from resdata-templates

Initial Comment:

Minor bug in data.cpp : OBResidueData::AssignBonds(...) 

the function connects atoms of a residue according to atom names defined in 
"resdata.txt" by stepping
through the atom list _vatoms and breaks when the residue information of the 
atoms under investigation
are different. Residues are only compared according to the residue name and the 
residue number, which 
is a problem when subsequent residues in a molecule have the same number and 
name, but have a different
chain identifier (see HETATM records of  1xxb.pdb : ARG residues, attached ). 
Thus the code
in data.cpp AssignBonds() should include a check if the chain identifiers 
match, otherwise artificial bonds
might be introduced since AssingBonds() does not check atom-atom distances:

line 680: 
            if (r1->GetNumString() != r2->GetNumString())
              break;
            if (r1->GetName() != r2->GetName())
              break;
            if (r1->GetChain() != r2->GetChain()) 
              break;



cheers
F


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=428740&aid=2889763&group_id=40728

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
OpenBabel-Devel mailing list
OpenBabel-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbabel-devel

Reply via email to