How are you suppose to auto-recognize an output file that hasn't been written yet as gzip? I think of the compression as part of the format - you shouldn't need an open stream in order to fully specify what it should be. An example of something that now works the way you would expect:
babel x.mol2 x.sdf.gz # previously x.sdf.gz was text output In my perfect world compression state would be embedded within the OBFormat class, but since these are singletons that doesn't work. David Koes Assistant Professor Computational and Systems Biology University of Pittsburgh On 06/16/2015 05:28 AM, Maciej Wójcikowski wrote: > Just one minor comment: why introduce additional argument for > FormatFromExt? Wouldn't a check if recognized format is "gz" and if so > returning actual format be sufficient? > > Other than that I'm all in, since the memory leak was an issue in one of > mine projects. > > — > Reply to this email directly or view it on GitHub > <https://github.com/openbabel/openbabel/pull/191#issuecomment-112361855>. > ------------------------------------------------------------------------------ _______________________________________________ OpenBabel-Devel mailing list OpenBabel-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbabel-devel
